* [Qemu-devel] [PATCH 0/2] vhost-user: release chardev on cleanup
@ 2016-04-06 15:38 marcandre.lureau
2016-04-06 15:38 ` [Qemu-devel] [PATCH 1/2] " marcandre.lureau
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: marcandre.lureau @ 2016-04-06 15:38 UTC (permalink / raw)
To: qemu-devel; +Cc: Marc-André Lureau, n.nikolaev, mst
From: Marc-André Lureau <marcandre.lureau@redhat.com>
The following 2 one-liners remove the chardev from the vhost-user
netdev it is attached to. This prevents from further reuse of the
chardev that would likely fail to setup again with the slave.
Related to:
https://bugzilla.redhat.com/show_bug.cgi?id=1256619
https://bugzilla.redhat.com/show_bug.cgi?id=1256618
rfc->v1:
- rfc was sent a few months ago, no comments: rebased & resend as
non-rfc this time.
Marc-André Lureau (2):
vhost-user: release chardev on cleanup
vhost-user: delete chardev on cleanup
net/vhost-user.c | 3 +++
1 file changed, 3 insertions(+)
--
2.5.5
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Qemu-devel] [PATCH 1/2] vhost-user: release chardev on cleanup
2016-04-06 15:38 [Qemu-devel] [PATCH 0/2] vhost-user: release chardev on cleanup marcandre.lureau
@ 2016-04-06 15:38 ` marcandre.lureau
2016-04-06 15:38 ` [Qemu-devel] [PATCH 2/2] vhost-user: delete " marcandre.lureau
2016-06-16 9:05 ` [Qemu-devel] [PATCH 0/2] vhost-user: release " Marc-André Lureau
2 siblings, 0 replies; 7+ messages in thread
From: marcandre.lureau @ 2016-04-06 15:38 UTC (permalink / raw)
To: qemu-devel; +Cc: Marc-André Lureau, n.nikolaev, mst
From: Marc-André Lureau <marcandre.lureau@redhat.com>
On init, vhost-user does qemu_chr_fe_claim_no_fail(). Do the opposite on
cleanup to allow removing or reusing the chardev.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
net/vhost-user.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/net/vhost-user.c b/net/vhost-user.c
index 1b9e73a..29fe097 100644
--- a/net/vhost-user.c
+++ b/net/vhost-user.c
@@ -142,6 +142,8 @@ static void vhost_user_cleanup(NetClientState *nc)
}
qemu_purge_queued_packets(nc);
+
+ qemu_chr_fe_release(s->chr);
}
static bool vhost_user_has_vnet_hdr(NetClientState *nc)
--
2.5.5
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [Qemu-devel] [PATCH 2/2] vhost-user: delete chardev on cleanup
2016-04-06 15:38 [Qemu-devel] [PATCH 0/2] vhost-user: release chardev on cleanup marcandre.lureau
2016-04-06 15:38 ` [Qemu-devel] [PATCH 1/2] " marcandre.lureau
@ 2016-04-06 15:38 ` marcandre.lureau
2016-06-16 9:05 ` [Qemu-devel] [PATCH 0/2] vhost-user: release " Marc-André Lureau
2 siblings, 0 replies; 7+ messages in thread
From: marcandre.lureau @ 2016-04-06 15:38 UTC (permalink / raw)
To: qemu-devel; +Cc: Marc-André Lureau, n.nikolaev, mst
From: Marc-André Lureau <marcandre.lureau@redhat.com>
Remove the chardev implicitely when cleaning up the netdev. This
prevents from reusing the chardev since it would be in an incorrect
state with the slave.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
net/vhost-user.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/vhost-user.c b/net/vhost-user.c
index 29fe097..2d7271a 100644
--- a/net/vhost-user.c
+++ b/net/vhost-user.c
@@ -144,6 +144,7 @@ static void vhost_user_cleanup(NetClientState *nc)
qemu_purge_queued_packets(nc);
qemu_chr_fe_release(s->chr);
+ qemu_chr_delete(s->chr);
}
static bool vhost_user_has_vnet_hdr(NetClientState *nc)
--
2.5.5
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH 0/2] vhost-user: release chardev on cleanup
2016-04-06 15:38 [Qemu-devel] [PATCH 0/2] vhost-user: release chardev on cleanup marcandre.lureau
2016-04-06 15:38 ` [Qemu-devel] [PATCH 1/2] " marcandre.lureau
2016-04-06 15:38 ` [Qemu-devel] [PATCH 2/2] vhost-user: delete " marcandre.lureau
@ 2016-06-16 9:05 ` Marc-André Lureau
2016-08-11 9:16 ` Marc-André Lureau
2 siblings, 1 reply; 7+ messages in thread
From: Marc-André Lureau @ 2016-06-16 9:05 UTC (permalink / raw)
To: QEMU; +Cc: Nikolay Nikolaev, Michael S. Tsirkin, Marc-André Lureau
ping
On Wed, Apr 6, 2016 at 5:38 PM, <marcandre.lureau@redhat.com> wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> The following 2 one-liners remove the chardev from the vhost-user
> netdev it is attached to. This prevents from further reuse of the
> chardev that would likely fail to setup again with the slave.
>
> Related to:
> https://bugzilla.redhat.com/show_bug.cgi?id=1256619
> https://bugzilla.redhat.com/show_bug.cgi?id=1256618
>
> rfc->v1:
> - rfc was sent a few months ago, no comments: rebased & resend as
> non-rfc this time.
>
> Marc-André Lureau (2):
> vhost-user: release chardev on cleanup
> vhost-user: delete chardev on cleanup
>
> net/vhost-user.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> --
> 2.5.5
>
--
Marc-André Lureau
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH 0/2] vhost-user: release chardev on cleanup
2016-06-16 9:05 ` [Qemu-devel] [PATCH 0/2] vhost-user: release " Marc-André Lureau
@ 2016-08-11 9:16 ` Marc-André Lureau
2016-09-27 11:44 ` Marc-André Lureau
0 siblings, 1 reply; 7+ messages in thread
From: Marc-André Lureau @ 2016-08-11 9:16 UTC (permalink / raw)
To: QEMU; +Cc: Nikolay Nikolaev, Michael S. Tsirkin
Hi
On Thu, Jun 16, 2016 at 1:05 PM Marc-André Lureau <
marcandre.lureau@gmail.com> wrote:
> ping
>
2nd ping, probably for-2.8 now
>
> On Wed, Apr 6, 2016 at 5:38 PM, <marcandre.lureau@redhat.com> wrote:
> > From: Marc-André Lureau <marcandre.lureau@redhat.com>
> >
> > The following 2 one-liners remove the chardev from the vhost-user
> > netdev it is attached to. This prevents from further reuse of the
> > chardev that would likely fail to setup again with the slave.
> >
> > Related to:
> > https://bugzilla.redhat.com/show_bug.cgi?id=1256619
> > https://bugzilla.redhat.com/show_bug.cgi?id=1256618
> >
> > rfc->v1:
> > - rfc was sent a few months ago, no comments: rebased & resend as
> > non-rfc this time.
> >
> > Marc-André Lureau (2):
> > vhost-user: release chardev on cleanup
> > vhost-user: delete chardev on cleanup
> >
> > net/vhost-user.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > --
> > 2.5.5
> >
>
>
>
> --
> Marc-André Lureau
>
--
Marc-André Lureau
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH 0/2] vhost-user: release chardev on cleanup
2016-08-11 9:16 ` Marc-André Lureau
@ 2016-09-27 11:44 ` Marc-André Lureau
2017-01-10 16:35 ` Marc-André Lureau
0 siblings, 1 reply; 7+ messages in thread
From: Marc-André Lureau @ 2016-09-27 11:44 UTC (permalink / raw)
To: QEMU; +Cc: Nikolay Nikolaev, Michael S. Tsirkin
Hi
On Thu, Aug 11, 2016 at 1:16 PM Marc-André Lureau <
marcandre.lureau@gmail.com> wrote:
> Hi
>
> On Thu, Jun 16, 2016 at 1:05 PM Marc-André Lureau <
> marcandre.lureau@gmail.com> wrote:
>
>> ping
>>
>
> 2nd ping, probably for-2.8 now
>
3rd ping, those are 2 one-liners, don't be shy :)
thanks
--
Marc-André Lureau
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH 0/2] vhost-user: release chardev on cleanup
2016-09-27 11:44 ` Marc-André Lureau
@ 2017-01-10 16:35 ` Marc-André Lureau
0 siblings, 0 replies; 7+ messages in thread
From: Marc-André Lureau @ 2017-01-10 16:35 UTC (permalink / raw)
To: QEMU; +Cc: Nikolay Nikolaev, Michael S. Tsirkin
Hi
On Tue, Sep 27, 2016 at 1:44 PM Marc-André Lureau <
marcandre.lureau@gmail.com> wrote:
> Hi
>
> On Thu, Aug 11, 2016 at 1:16 PM Marc-André Lureau <
> marcandre.lureau@gmail.com> wrote:
>
> Hi
>
> On Thu, Jun 16, 2016 at 1:05 PM Marc-André Lureau <
> marcandre.lureau@gmail.com> wrote:
>
> ping
>
>
> 2nd ping, probably for-2.8 now
>
>
> 3rd ping, those are 2 one-liners, don't be shy :)
>
>
Michael, could you look and pick those 2 patches?
thanks
--
Marc-André Lureau
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-01-10 16:35 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-06 15:38 [Qemu-devel] [PATCH 0/2] vhost-user: release chardev on cleanup marcandre.lureau
2016-04-06 15:38 ` [Qemu-devel] [PATCH 1/2] " marcandre.lureau
2016-04-06 15:38 ` [Qemu-devel] [PATCH 2/2] vhost-user: delete " marcandre.lureau
2016-06-16 9:05 ` [Qemu-devel] [PATCH 0/2] vhost-user: release " Marc-André Lureau
2016-08-11 9:16 ` Marc-André Lureau
2016-09-27 11:44 ` Marc-André Lureau
2017-01-10 16:35 ` Marc-André Lureau
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.