From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51217)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marcandre.lureau@gmail.com>) id 1bKBw7-0005oH-AL
	for qemu-devel@nongnu.org; Mon, 04 Jul 2016 18:01:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <marcandre.lureau@gmail.com>) id 1bKBw6-0000sK-IK
	for qemu-devel@nongnu.org; Mon, 04 Jul 2016 18:01:51 -0400
Received: from mail-vk0-x22f.google.com ([2607:f8b0:400c:c05::22f]:33892)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marcandre.lureau@gmail.com>) id 1bKBw6-0000s7-DH
	for qemu-devel@nongnu.org; Mon, 04 Jul 2016 18:01:50 -0400
Received: by mail-vk0-x22f.google.com with SMTP id c2so244151782vkg.1
	for <qemu-devel@nongnu.org>; Mon, 04 Jul 2016 15:01:50 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <20160704184410-mutt-send-email-mst@redhat.com>
References: <1466503372-28334-1-git-send-email-marcandre.lureau@redhat.com>
	<1466503372-28334-7-git-send-email-marcandre.lureau@redhat.com>
	<20160623072717-mutt-send-email-mst@redhat.com>
	<395281151.1343677.1466673378323.JavaMail.zimbra@redhat.com>
	<20160623200402-mutt-send-email-mst@redhat.com>
	<CAJ+F1C+xPc=vUc15k_om7UyYDtTN69n1Vov56MbSw1A=diXkAQ@mail.gmail.com>
	<20160704184410-mutt-send-email-mst@redhat.com>
From: =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= <marcandre.lureau@gmail.com>
Date: Tue, 5 Jul 2016 00:01:49 +0200
Message-ID: <CAJ+F1C+QrpsjpnZqYTu6Pq2O5o0jqKS11tW-2e0aBhBfyNxx-Q@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 06/24] vhost-user: check vhost_user_write()
 return value
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: yuanhan liu <yuanhan.liu@linux.intel.com>, Victor Kaplansky <victork@redhat.com>, QEMU <qemu-devel@nongnu.org>, jonshin@cisco.com, Tetsuya Mukawa <mukawa@igel.co.jp>

On Mon, Jul 4, 2016 at 5:46 PM, Michael S. Tsirkin <mst@redhat.com> wrote:
> Let's just work on handling it. If we need debug messages to help us
> reach that goal fine. But I don't see many reasons to propagate
> return codes back and forth if caller just prints and ignores it.
> Print it where it's detected :)


Adding more debug messages is not the point of this patch though, it
is to break the code flow when an error occurs, not later. Sure we can
add error_report() in vhost_user_write() that would be more consistent
with vhost_user_read() actually.


--=20
Marc-Andr=C3=A9 Lureau