From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49678) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aGSEn-0006lP-NQ for qemu-devel@nongnu.org; Tue, 05 Jan 2016 09:05:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aGSEj-0000J6-UE for qemu-devel@nongnu.org; Tue, 05 Jan 2016 09:05:25 -0500 Received: from mail-oi0-x236.google.com ([2607:f8b0:4003:c06::236]:35062) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aGSEj-0000J0-QC for qemu-devel@nongnu.org; Tue, 05 Jan 2016 09:05:21 -0500 Received: by mail-oi0-x236.google.com with SMTP id l9so246606985oia.2 for ; Tue, 05 Jan 2016 06:05:21 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <1450717720-9627-22-git-send-email-eblake@redhat.com> References: <1450717720-9627-1-git-send-email-eblake@redhat.com> <1450717720-9627-22-git-send-email-eblake@redhat.com> Date: Tue, 5 Jan 2016 15:05:21 +0100 Message-ID: From: =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v8 21/35] qapi: Document visitor interfaces, add assertions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: Michael Roth , QEMU , Markus Armbruster Hi On Mon, Dec 21, 2015 at 6:08 PM, Eric Blake wrote: > The visitor interface for mapping between QObject/QemuOpts/string > and qapi has formerly been documented only by reading source code, > making it difficult to propose changes to either scripts/qapi*.py > or to clients without knowing whether those changes would be safe. > This adds documentation, including mentioning when parameters can > be NULL, and where there are still some interface warts that would > be nice to remove. In particular, I have plans to remove > visit_start_union() in a future patch. > > Add some asserts to strengthen the claims of the assertions; some > of these were only made possible by recent cleanup commits. These > were made easier with the addition of a new visit_is_output() > helper (since all 2 output visitors of our 6 overall visitors use > the same .type_enum() callback). > > Signed-off-by: Eric Blake Nice doc, Reviewed-by: Marc-Andr=C3=A9 Lureau --=20 Marc-Andr=C3=A9 Lureau