From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49395)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marcandre.lureau@gmail.com>) id 1aGSDs-00053f-Pr
	for qemu-devel@nongnu.org; Tue, 05 Jan 2016 09:04:29 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <marcandre.lureau@gmail.com>) id 1aGSDr-0008V8-Sy
	for qemu-devel@nongnu.org; Tue, 05 Jan 2016 09:04:28 -0500
Received: from mail-ob0-x235.google.com ([2607:f8b0:4003:c01::235]:33856)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marcandre.lureau@gmail.com>) id 1aGSDr-0008V4-Og
	for qemu-devel@nongnu.org; Tue, 05 Jan 2016 09:04:27 -0500
Received: by mail-ob0-x235.google.com with SMTP id wp13so139421645obc.1
	for <qemu-devel@nongnu.org>; Tue, 05 Jan 2016 06:04:27 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <1450717720-9627-28-git-send-email-eblake@redhat.com>
References: <1450717720-9627-1-git-send-email-eblake@redhat.com>
	<1450717720-9627-28-git-send-email-eblake@redhat.com>
Date: Tue, 5 Jan 2016 15:04:27 +0100
Message-ID: <CAJ+F1C+SQXn022s0H3suBJOQyZ7XMcVD=D9rysjjbCBj8Z5nYQ@mail.gmail.com>
From: =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= <marcandre.lureau@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v8 27/35] qapi: Fix command with named
 empty argument type
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: Michael Roth <mdroth@linux.vnet.ibm.com>, QEMU <qemu-devel@nongnu.org>, Markus Armbruster <armbru@redhat.com>

Hi

On Mon, Dec 21, 2015 at 6:08 PM, Eric Blake <eblake@redhat.com> wrote:
> The generator special-cased
>  { 'command':'foo', 'data': {} }
> to avoid emitting a visitor variable, but failed to see that
>  { 'struct':'NamedEmptyType, 'data': {} }
>  { 'command':'foo', 'data':'NamedEmptyType' }
> needs the same treatment.  Without a fix to the generator, the
> change to qapi-schema-test.json fails to compile with:
>
> tests/test-qmp-marshal.c: In function =E2=80=98qmp_marshal_user_def_cmd0=
=E2=80=99:
> tests/test-qmp-marshal.c:264:14: error: variable =E2=80=98v=E2=80=99 set =
but not used [-Werror=3Dunused-but-set-variable]
>      Visitor *v;
>               ^
>
> Signed-off-by: Eric Blake <eblake@redhat.com>

Reviewed-by: Marc-Andr=C3=A9 Lureau <marcandre.lureau@redhat.com>


--=20
Marc-Andr=C3=A9 Lureau