From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50148) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aGSGE-00017z-Mb for qemu-devel@nongnu.org; Tue, 05 Jan 2016 09:06:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aGSGD-0000eK-S5 for qemu-devel@nongnu.org; Tue, 05 Jan 2016 09:06:54 -0500 Received: from mail-oi0-x230.google.com ([2607:f8b0:4003:c06::230]:35462) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aGSGD-0000eE-OH for qemu-devel@nongnu.org; Tue, 05 Jan 2016 09:06:53 -0500 Received: by mail-oi0-x230.google.com with SMTP id l9so246633384oia.2 for ; Tue, 05 Jan 2016 06:06:53 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <1450717720-9627-5-git-send-email-eblake@redhat.com> References: <1450717720-9627-1-git-send-email-eblake@redhat.com> <1450717720-9627-5-git-send-email-eblake@redhat.com> Date: Tue, 5 Jan 2016 15:06:53 +0100 Message-ID: From: =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v8 04/35] hmp: Improve use of qapi visitor List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: Luiz Capitulino , QEMU , Markus Armbruster Hi On Mon, Dec 21, 2015 at 6:08 PM, Eric Blake wrote: > Cache the visitor in a local variable instead of repeatedly > calling the accessor. Pass NULL for the visit_start_struct() > object (which matches the fact that we were already passing 0 > for the size argument, because we aren't using the visit to > allocate a qapi struct). > > Signed-off-by: Eric Blake Reviewed-by: Marc-Andr=C3=A9 Lureau --=20 Marc-Andr=C3=A9 Lureau