From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B3C6C43460 for ; Wed, 5 May 2021 21:51:49 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9117C61164 for ; Wed, 5 May 2021 21:51:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9117C61164 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:42278 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lePQp-0005OB-Kq for qemu-devel@archiver.kernel.org; Wed, 05 May 2021 17:51:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42760) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1leP0z-00009o-JY; Wed, 05 May 2021 17:25:05 -0400 Received: from mail-ej1-x633.google.com ([2a00:1450:4864:20::633]:40732) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1leP0w-0003N9-Vh; Wed, 05 May 2021 17:25:05 -0400 Received: by mail-ej1-x633.google.com with SMTP id n2so5072778ejy.7; Wed, 05 May 2021 14:25:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mgVC5GAwCd579XQfB/Z8UQnM5xXmOIgrDlNOTtuLVrM=; b=gvv7T2hnHBdLIzK0PD1d6riDSQd5lSHn/MVsQC+pyQnCiu5uXDiSQVEJuqg/YE0aDx MhbcfzdMYGUuJzvv4LU+VE+gsNINUaOEEt41UW5qrYF/X25hj/rpYAOrDFgwV9sfRLuM RKPXFmIfcZ3q/349aM6H1tGOk2LkOrKS7HXkOnf4dYM/SU3VPAeUDOEtP2O7bBVZpkE+ /cPftIZTs+z+metWqqQumv75sXDq40H8Bl0K0C6DWEL1jLZFLohzL2ZbuM/6F8yL0zGe lH60R5RGl79Z3Sg/6pjqph7uTG5kyYuW9/okk+zmFt1i78rdylUFmtsPhHXdEf8lZK/W bu5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mgVC5GAwCd579XQfB/Z8UQnM5xXmOIgrDlNOTtuLVrM=; b=XmLyTFf1GCN/+/qZAP+K8pxYtcK+7N/i0pFQ9stfuEjaH/WRY2Oj94yoF9ZA8UhCGY zjKWdVgMnX1RqF1jBJWubv4nojkmfJNe1DUj6RgSs9DfkpxoUkIUgQ5F4sS84nzzrwLH jYzaC4jXa/0uVD6heoHUTWAPm00egQD3PP0zew8isOKXHRZ/HLWx8twbi+0+JIZMcKbF sFV7jLx1lxKSyWRk207mljFQBXjeKjUiNPwrnREd0INTsAKwt5aGjekeZ24ZrOmJpJFM RzsTRpVHjqkSYXTV5KVVOaeObVnbgh3baDS9es7cH8Q+VSw1i9FBiAFTRKNgA/U4ZfXL F/4w== X-Gm-Message-State: AOAM531s0TISSq3QTrZyxTyAb3j+IMbDn3aPHLPn51oq4+gZvP3LTGis /1105Sjj6RWjO/d9G5+rAZYe87y5Vh7NodhOhA0= X-Google-Smtp-Source: ABdhPJzrVQH7vYHncArE+O9Rc9YYdl4xBBkv2U+T2sKjJrkqSyeV29MfQDO0DPUaloSQ4/rntRCzHEyv4P47ulcJJbs= X-Received: by 2002:a17:906:b03:: with SMTP id u3mr725300ejg.381.1620249900449; Wed, 05 May 2021 14:25:00 -0700 (PDT) MIME-Version: 1.0 References: <20210505211047.1496765-1-philmd@redhat.com> <20210505211047.1496765-3-philmd@redhat.com> In-Reply-To: <20210505211047.1496765-3-philmd@redhat.com> From: =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= Date: Thu, 6 May 2021 01:24:48 +0400 Message-ID: Subject: Re: [PATCH 02/23] chardev/baum: Replace magic values by X_MAX / Y_MAX definitions To: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Content-Type: multipart/alternative; boundary="000000000000c3821005c19bd346" Received-SPF: pass client-ip=2a00:1450:4864:20::633; envelope-from=marcandre.lureau@gmail.com; helo=mail-ej1-x633.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?Q?Daniel_P=2E_Berrang=C3=A9?= , "open list:Block layer core" , Richard Henderson , QEMU , "open list:sPAPR pseries" , Gerd Hoffmann , Paolo Bonzini , Samuel Thibault Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --000000000000c3821005c19bd346 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, May 6, 2021 at 1:13 AM Philippe Mathieu-Daud=C3=A9 wrote: > Replace '84' magic value by the X_MAX definition, and '1' by Y_MAX. > > Signed-off-by: Philippe Mathieu-Daud=C3=A9 > Reviewed-by: Marc-Andr=C3=A9 Lureau > --- > chardev/baum.c | 11 +++++++---- > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git a/chardev/baum.c b/chardev/baum.c > index 5deca778bc4..adc3d7b3b56 100644 > --- a/chardev/baum.c > +++ b/chardev/baum.c > @@ -87,6 +87,9 @@ > > #define BUF_SIZE 256 > > +#define X_MAX 84 > +#define Y_MAX 1 > + > struct BaumChardev { > Chardev parent; > > @@ -244,11 +247,11 @@ static int baum_deferred_init(BaumChardev *baum) > brlapi_perror("baum: brlapi__getDisplaySize"); > return 0; > } > - if (baum->y > 1) { > - baum->y =3D 1; > + if (baum->y > Y_MAX) { > + baum->y =3D Y_MAX; > } > - if (baum->x > 84) { > - baum->x =3D 84; > + if (baum->x > X_MAX) { > + baum->x =3D X_MAX; > } > > con =3D qemu_console_lookup_by_index(0); > -- > 2.26.3 > > > --=20 Marc-Andr=C3=A9 Lureau --000000000000c3821005c19bd346 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Thu, May 6, 2021 at 1:13 AM Philip= pe Mathieu-Daud=C3=A9 <philmd@redha= t.com> wrote:
Replace '84' magic value by the X_MAX definition, and '1&#= 39; by Y_MAX.

Signed-off-by: Philippe Mathieu-Daud=C3=A9 <philmd@redhat.com>
<= br>
Reviewed-by: Marc-Andr=C3=A9 Lureau <marcandre.lureau@redhat.com>
---
=C2=A0chardev/baum.c | 11 +++++++----
=C2=A01 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/chardev/baum.c b/chardev/baum.c
index 5deca778bc4..adc3d7b3b56 100644
--- a/chardev/baum.c
+++ b/chardev/baum.c
@@ -87,6 +87,9 @@

=C2=A0#define BUF_SIZE 256

+#define X_MAX=C2=A0 =C2=A084
+#define Y_MAX=C2=A0 =C2=A01
+
=C2=A0struct BaumChardev {
=C2=A0 =C2=A0 =C2=A0Chardev parent;

@@ -244,11 +247,11 @@ static int baum_deferred_init(BaumChardev *baum)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0brlapi_perror("baum: brlapi__getDisp= laySize");
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0return 0;
=C2=A0 =C2=A0 =C2=A0}
-=C2=A0 =C2=A0 if (baum->y > 1) {
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 baum->y =3D 1;
+=C2=A0 =C2=A0 if (baum->y > Y_MAX) {
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 baum->y =3D Y_MAX;
=C2=A0 =C2=A0 =C2=A0}
-=C2=A0 =C2=A0 if (baum->x > 84) {
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 baum->x =3D 84;
+=C2=A0 =C2=A0 if (baum->x > X_MAX) {
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 baum->x =3D X_MAX;
=C2=A0 =C2=A0 =C2=A0}

=C2=A0 =C2=A0 =C2=A0con =3D qemu_console_lookup_by_index(0);
--
2.26.3




--
Marc-Andr=C3=A9 Lureau
--000000000000c3821005c19bd346--