From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=0.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79C0CC433C1 for ; Mon, 29 Mar 2021 16:33:10 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0B90E61960 for ; Mon, 29 Mar 2021 16:33:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0B90E61960 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:48608 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lQupB-0006ed-4d for qemu-devel@archiver.kernel.org; Mon, 29 Mar 2021 12:33:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49808) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lQuma-0005H5-2w for qemu-devel@nongnu.org; Mon, 29 Mar 2021 12:30:29 -0400 Received: from mail-ed1-x52f.google.com ([2a00:1450:4864:20::52f]:41554) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lQumT-000467-OE for qemu-devel@nongnu.org; Mon, 29 Mar 2021 12:30:27 -0400 Received: by mail-ed1-x52f.google.com with SMTP id z1so14922784edb.8 for ; Mon, 29 Mar 2021 09:30:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6DDePH8GNSXZJyWtB92ehNzCh60HyFoOXyUe/mlN56E=; b=T6U1o8vRw7vTsphixZlg2Ofe1ncRBtW85EY065ekDUprwPZOFC1dRqca9wUXSvaISQ xmjO6csF93lOM1zDMZt0xb6j7PU0Dh65FCOvOJ3wXaFvGQ8/7VgCWtZ5ZvA3fccezs2b djdsT+h7N2xG9SJgIz2+FltC2TVEnEfNFyX5CR35hYDANDJqxwAvfHYcjeEiq7eaVDCu BZ8Bmcp619erp6uZf+dAEsHAyO9chfven6Hp/ALn+190m+cJwBk7afwfBBfzxW8l2J7z rozPC5yL16gKJmFfK2NCZFPa18Hlk/gspo82Forxj5Ql7fMZIh6vfWr6reKHw8QuI1pJ x61Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6DDePH8GNSXZJyWtB92ehNzCh60HyFoOXyUe/mlN56E=; b=GyV76PwYVn9axUL1frW7YkdErrmGic+DthbteeEqIF65RMuzX4wbYupfe5A6O2Y2VR Ed97+AXzUuN47c/eQ1+vJ7JJGytf94fNHjxCbA9K4nF+94krD13RBsS4UBfACazesnU7 upKBqhRk5PgmzyUIbqOgsC7y1EgadGj0f/HjEq8+mv+pgsDagxFNOCVNZ2svS6wST32d Iiz52/TfX/3+8tjYShxSoi+l3CzA8Z74jyMBVYn06DieojGziUXc6IDyCBwCy5qfgW6x bIyz8TMOnSTbjDdb7O84QPaEdoJfKDgKfhCBbzKZB5dB3tCXVdAvngRm3yACBx+vbaFy 5fPQ== X-Gm-Message-State: AOAM5336co+W+zgN2V39GuQvoZvJ7nmqilhuKlqfAKdzRP3JwzXLyh8r kGGAsAO4omELFZqvCefWdLstMzph/ZpSpxaqZFE= X-Google-Smtp-Source: ABdhPJyfZlAnpyruXJjmz/lEP6zwcHwuYCMLahfFdlUa/m1NzjxB8MweF3FCuMgvZfEqp3axkyJOaKiowOx4LQX0Juo= X-Received: by 2002:aa7:d642:: with SMTP id v2mr29757369edr.257.1617035420014; Mon, 29 Mar 2021 09:30:20 -0700 (PDT) MIME-Version: 1.0 References: <20210328184533.752840-1-marcandre.lureau@redhat.com> In-Reply-To: From: =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= Date: Mon, 29 Mar 2021 20:30:08 +0400 Message-ID: Subject: Re: [PULL 00/10] For 6.0 patches To: Peter Maydell Content-Type: multipart/alternative; boundary="000000000000cc9c8a05beaf65d7" Received-SPF: pass client-ip=2a00:1450:4864:20::52f; envelope-from=marcandre.lureau@gmail.com; helo=mail-ed1-x52f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lukas Straub , QEMU Developers Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --000000000000cc9c8a05beaf65d7 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi On Mon, Mar 29, 2021 at 7:56 PM Peter Maydell wrote: > On Mon, 29 Mar 2021 at 15:17, Marc-Andr=C3=A9 Lureau > wrote: > > > > Hi > > > > On Mon, Mar 29, 2021 at 5:54 PM Peter Maydell > wrote: > >> > >> This produces a backtrace from sphinx-build which nonetheless doesn't > >> cause a build failure: > >> > >> > >> Program sphinx-build found: YES > >> ../docs/meson.build:30: WARNING: /usr/bin/sphinx-build: > >> Configuration error: > >> There is a programable error in your configuration file: > >> > >> Traceback (most recent call last): > >> File "conf.py", line 154, in > >> import sphinx_rtd_theme > >> ModuleNotFoundError: No module named 'sphinx_rtd_theme' > >> > >> During handling of the above exception, another exception occurred: > >> > >> Traceback (most recent call last): > >> File "/usr/lib/python3/dist-packages/sphinx/config.py", line 157, in > __init__ > >> execfile_(filename, config) > >> File "/usr/lib/python3/dist-packages/sphinx/util/pycompat.py", line > >> 150, in execfile_ > >> exec_(code, _globals) > >> File "conf.py", line 157, in > >> 'The Sphinx \'sphinx_rtd_theme\' HTML theme was not found.\n' > >> sphinx.errors.ConfigError: The Sphinx 'sphinx_rtd_theme' HTML theme > >> was not found. > >> > > > > > > ../docs/meson.build:30: WARNING: /usr/bin/sphinx-build-3: > > Configuration error: > > The Sphinx 'sphinx_rtd_theme' HTML theme was not found. > > > > ../docs/meson.build:32:6: ERROR: Problem encountered: Install a Python = 3 > version of python-sphinx and the readthedoc theme > > > So why do you get that message, and I see the above? Older > sphinx-build ? > It's strange, it's like ModuleNotFoundError was not catched by the "except ImportError". What's the version of python? > Also, if this isn't fatal (the build does continue), meson > shouldn't print ERROR here, ideally. > Something is again unexpected here. If you have the meson error, it should stop the build there with an error. And the error is only raised when docs is enabled. For me it doesn't continue: $ make ... ../docs/meson.build:32:6: ERROR: Problem encountered: Install a Python 3 version of python-sphinx and the readthedoc theme A full log can be found at /home/elmarco/src/qemu/build/meson-logs/meson-log.txt ninja: error: rebuilding 'build.ninja': subcommand failed FAILED: build.ninja /usr/bin/meson --internal regenerate /home/elmarco/src/qemu /home/elmarco/src/qemu/build --backend ninja make: *** [Makefile:152: run-ninja] Error 1 > >> Program python3 found: YES (/usr/bin/python3) > >> > >> > >> In particular I see that on all the BSD VMs. If we're going to > >> require rtd that means we need to ensure it's present on all > >> the VM configs, docker configs, everything the CI uses, etc. > >> You should also flag up new build-deps in the pullreq cover > >> letter. > > > > > > I updated all docker configs. We don't have sphinx in the BSD VMs > apparently, am I wrong? > > We must do, because trying to build this merge in the VMs produces > errors from sphinx-build... > > I am trying to reproduce.. I tried with vm-build-openbsd, but it reaches console read timeout error... Now trying with freebsd (looking for a mirror for iso, because 40kb/s atm for me) --=20 Marc-Andr=C3=A9 Lureau --000000000000cc9c8a05beaf65d7 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi

On Mon, Mar 29, 2021 at 7:56 PM Pet= er Maydell <peter.maydell@li= naro.org> wrote:
On Mon, 29 Mar 2021 at 15:17, Marc-Andr=C3=A9 Lureau
<marcand= re.lureau@gmail.com> wrote:
>
> Hi
>
> On Mon, Mar 29, 2021 at 5:54 PM Peter Maydell <peter.maydell@linaro.org> = wrote:
>>
>> This produces a backtrace from sphinx-build which nonetheless does= n't
>> cause a build failure:
>>
>>
>> Program sphinx-build found: YES
>> ../docs/meson.build:30: WARNING: /usr/bin/sphinx-build:
>> Configuration error:
>> There is a programable error in your configuration file:
>>
>> Traceback (most recent call last):
>>=C2=A0 =C2=A0File "conf.py", line 154, in <module><= br> >>=C2=A0 =C2=A0 =C2=A0import sphinx_rtd_theme
>> ModuleNotFoundError: No module named 'sphinx_rtd_theme' >>
>> During handling of the above exception, another exception occurred= :
>>
>> Traceback (most recent call last):
>>=C2=A0 =C2=A0File "/usr/lib/python3/dist-packages/sphinx/confi= g.py", line 157, in __init__
>>=C2=A0 =C2=A0 =C2=A0execfile_(filename, config)
>>=C2=A0 =C2=A0File "/usr/lib/python3/dist-packages/sphinx/util/= pycompat.py", line
>> 150, in execfile_
>>=C2=A0 =C2=A0 =C2=A0exec_(code, _globals)
>>=C2=A0 =C2=A0File "conf.py", line 157, in <module><= br> >>=C2=A0 =C2=A0 =C2=A0'The Sphinx \'sphinx_rtd_theme\' HT= ML theme was not found.\n'
>> sphinx.errors.ConfigError: The Sphinx 'sphinx_rtd_theme' H= TML theme
>> was not found.
>>
>
>
> ../docs/meson.build:30: WARNING: /usr/bin/sphinx-build-3:
> Configuration error:
> The Sphinx 'sphinx_rtd_theme' HTML theme was not found.
>
> ../docs/meson.build:32:6: ERROR: Problem encountered: Install a Python= 3 version of python-sphinx and the readthedoc theme


So why do you get that message, and I see the above? Older
sphinx-build ?


It's = strange, it's like ModuleNotFoundError was not catched by the "exc= ept ImportError".

What's the version of p= ython?


>> Program python3 found: YES (/usr/bin/python3)
>>
>>
>> In particular I see that on all the BSD VMs. If we're going to=
>> require rtd that means we need to ensure it's present on all >> the VM configs, docker configs, everything the CI uses, etc.
>> You should also flag up new build-deps in the pullreq cover
>> letter.
>
>
> I updated all docker configs. We don't have sphinx in the BSD VMs = apparently, am I wrong?

We must do, because trying to build this merge in the VMs produces
errors from sphinx-build...


I am trying to reproduce.. I tried with=C2=A0 vm-build-openbsd, but = it reaches console read timeout error... Now trying with freebsd (looking f= or a mirror for iso, because 40kb/s atm for me)

--
<= div dir=3D"ltr" class=3D"gmail_signature">Marc-Andr=C3=A9 Lureau
<= /div> --000000000000cc9c8a05beaf65d7--