All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Marc-André Lureau" <marcandre.lureau@gmail.com>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>, QEMU <qemu-devel@nongnu.org>,
	Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [PATCH] RFC: replace qemu_real_host_page variables with inlined functions
Date: Tue, 8 Mar 2022 15:34:16 +0400	[thread overview]
Message-ID: <CAJ+F1CJ5XU3g+CiLEwq7hWbtom4UEu-ud2wMV8tAgdcD4p8f9Q@mail.gmail.com> (raw)
In-Reply-To: <fedbc4bc-c5de-4320-4103-f46730680dbe@linaro.org>

[-- Attachment #1: Type: text/plain, Size: 598 bytes --]

Hi

On Mon, Mar 7, 2022 at 9:41 PM Richard Henderson <
richard.henderson@linaro.org> wrote:

> On 3/1/22 04:46, marcandre.lureau@redhat.com wrote:
> > Replace the global variables with inlined helper functions.
> getpagesize() is very
> > likely annotated with a "const" function attribute (at least with
> glibc), and thus
> > optimization should apply even better.
> >
> > This avoids the need for a constructor initialization too.
>
> What's the change in the size of the qemu text section with this change?
>

I get +496 bytes  (on a 58Mb binary ;)

-- 
Marc-André Lureau

[-- Attachment #2: Type: text/html, Size: 1085 bytes --]

      reply	other threads:[~2022-03-08 11:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-01 14:46 [PATCH] RFC: replace qemu_real_host_page variables with inlined functions marcandre.lureau
2022-03-07 11:52 ` Marc-André Lureau
2022-03-07 17:41 ` Richard Henderson
2022-03-08 11:34   ` Marc-André Lureau [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJ+F1CJ5XU3g+CiLEwq7hWbtom4UEu-ud2wMV8tAgdcD4p8f9Q@mail.gmail.com \
    --to=marcandre.lureau@gmail.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.