From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59154)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marcandre.lureau@gmail.com>) id 1a6pXc-0008Dk-RW
	for qemu-devel@nongnu.org; Wed, 09 Dec 2015 19:57:05 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <marcandre.lureau@gmail.com>) id 1a6pXc-000612-4H
	for qemu-devel@nongnu.org; Wed, 09 Dec 2015 19:57:04 -0500
Received: from mail-oi0-x233.google.com ([2607:f8b0:4003:c06::233]:33413)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marcandre.lureau@gmail.com>) id 1a6pXb-00060w-Uq
	for qemu-devel@nongnu.org; Wed, 09 Dec 2015 19:57:04 -0500
Received: by oixx65 with SMTP id x65so36640881oix.0
	for <qemu-devel@nongnu.org>; Wed, 09 Dec 2015 16:57:03 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <1449708810-17891-1-git-send-email-marcandre.lureau@redhat.com>
References: <1449708810-17891-1-git-send-email-marcandre.lureau@redhat.com>
Date: Thu, 10 Dec 2015 01:57:02 +0100
Message-ID: <CAJ+F1CJG9pZQWgfnDex6eL1SFrjdcu_E0=SJcjJNVEyjMHNwBA@mail.gmail.com>
From: =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= <marcandre.lureau@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] configure: remove bashism (since 2010)
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: QEMU <qemu-devel@nongnu.org>

Hi

On Thu, Dec 10, 2015 at 1:53 AM,  <marcandre.lureau@redhat.com> wrote:
> From: Marc-Andr=C3=A9 Lureau <marcandre.lureau@redhat.com>
>
> "type" is not POSIX shell, but a bashism. (found thanks to shellcheck)
>

A subsidiary question is whether qemu really care about using POSIX
shell, or we can just depend on bashism. That would help with
simplifying some Makefile lines too.

> Signed-off-by: Marc-Andr=C3=A9 Lureau <marcandre.lureau@redhat.com>
> ---
>  configure | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index ba57b3f..90eff82 100755
> --- a/configure
> +++ b/configure
> @@ -158,7 +158,7 @@ symlink() {
>  # check whether a command is available to this shell (may be either an
>  # executable or a builtin)
>  has() {
> -    type "$1" >/dev/null 2>&1
> +    which "$1" >/dev/null 2>&1
>  }
>
>  # search for an executable in PATH
> --
> 2.5.0
>
>



--=20
Marc-Andr=C3=A9 Lureau