Hi

On Mon, Mar 29, 2021 at 5:54 PM Peter Maydell <peter.maydell@linaro.org>
wrote:

> On Sun, 28 Mar 2021 at 19:45, <marcandre.lureau@redhat.com> wrote:
> >
> > From: Marc-André Lureau <marcandre.lureau@redhat.com>
> >
> > The following changes since commit
> 7b9a3c9f94bcac23c534bc9f42a9e914b433b299:
> >
> >   Merge remote-tracking branch
> 'remotes/kraxel/tags/fixes-20210326-pull-request' into staging (2021-03-26
> 12:58:58 +0000)
> >
> > are available in the Git repository at:
> >
> >   git@gitlab.com:marcandre.lureau/qemu.git tags/for-6.0-pull-request
> >
> > for you to fetch changes up to f57d44b452e11d8b7c9743476c30a8d0f80926de:
> >
> >   tests: Add tests for yank with the chardev-change case (2021-03-27
> 13:57:40 +0400)
> >
> > ----------------------------------------------------------------
> > For 6.0 misc patches under my radar.
> >
> > Peter, let me know if you would rather split that PR.
> >
> > ----------------------------------------------------------------
>
> This produces a backtrace from sphinx-build which nonetheless doesn't
> cause a build failure:
>
>
> Program sphinx-build found: YES
> ../docs/meson.build:30: WARNING: /usr/bin/sphinx-build:
> Configuration error:
> There is a programable error in your configuration file:
>
> Traceback (most recent call last):
>   File "conf.py", line 154, in <module>
>     import sphinx_rtd_theme
> ModuleNotFoundError: No module named 'sphinx_rtd_theme'
>
> During handling of the above exception, another exception occurred:
>
> Traceback (most recent call last):
>   File "/usr/lib/python3/dist-packages/sphinx/config.py", line 157, in
> __init__
>     execfile_(filename, config)
>   File "/usr/lib/python3/dist-packages/sphinx/util/pycompat.py", line
> 150, in execfile_
>     exec_(code, _globals)
>   File "conf.py", line 157, in <module>
>     'The Sphinx \'sphinx_rtd_theme\' HTML theme was not found.\n'
> sphinx.errors.ConfigError: The Sphinx 'sphinx_rtd_theme' HTML theme
> was not found.
>
>

../docs/meson.build:30: WARNING: /usr/bin/sphinx-build-3:
Configuration error:
The Sphinx 'sphinx_rtd_theme' HTML theme was not found.

../docs/meson.build:32:6: ERROR: Problem encountered: Install a Python 3
version of python-sphinx and the readthedoc theme

It's only fatal if you explicitely enabled docs. Otherwise, it just prints
a warning and disable it (just like sphinx 3.6 version requirement).


>
>
> Program python3 found: YES (/usr/bin/python3)
>
>
> In particular I see that on all the BSD VMs. If we're going to
> require rtd that means we need to ensure it's present on all
> the VM configs, docker configs, everything the CI uses, etc.
> You should also flag up new build-deps in the pullreq cover
> letter.
>

I updated all docker configs. We don't have sphinx in the BSD VMs
apparently, am I wrong?


> I dunno if we can get the error message neater (I know sphinx-build,
> especially older versions, is a bit unhelpful about what it lets us
> report.)
>
> The test-yank stuff also failed on OSX:
>
> Unexpected error in inet_connect_addr() at ../../util/qemu-sockets.c:380:
> Failed to connect to '127.0.0.1:63820': Operation timed out
> ERROR test-yank - too few tests run (expected 6, got 1)
>
>
Lukas, can you have a look too?

thanks

-- 
Marc-André Lureau