From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,INCLUDES_PULL_REQUEST, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,NUMERIC_HTTP_ADDR,SPF_HELO_NONE, SPF_PASS,WEIRD_PORT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEF4CC433DB for ; Mon, 29 Mar 2021 14:18:05 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3A60761927 for ; Mon, 29 Mar 2021 14:18:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3A60761927 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:48734 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lQsiS-0008LE-0U for qemu-devel@archiver.kernel.org; Mon, 29 Mar 2021 10:18:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33534) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lQshf-0007sJ-2o for qemu-devel@nongnu.org; Mon, 29 Mar 2021 10:17:15 -0400 Received: from mail-ed1-x52a.google.com ([2a00:1450:4864:20::52a]:33345) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lQshd-00009V-1i for qemu-devel@nongnu.org; Mon, 29 Mar 2021 10:17:14 -0400 Received: by mail-ed1-x52a.google.com with SMTP id w18so14501381edc.0 for ; Mon, 29 Mar 2021 07:17:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=khBfSoiP07rxsriYEWbezpvjGpbJCcBSnxoytsf5Ysw=; b=TVlgw58kkYXL6l/qpcU6YfvZOczDOkzIWLDHo3eRvva60nDw8gydp1Q5jhE2ZC0zlJ PxIlPdP6fCEenpdSRCzIIDUKnt52jnvIlW7NfFavqpW6Wus5Z0oNRnOfgcKDu86bzJ0I 6jVSzsV9bB1d0kWIYY/U6zYRgSkmvS/+/BV3QvwO7XVMKAIjs8wUoZx3gkYpWpqWb2QT hk/XCQjNZxcUNTo0Gk6NqZkMGzqA6ChisS9nVZcXRjTmuR18vdbQ6fKfgYLyrtdzaGRf gqoSybrX0fKebtFMeogsIlFQqZq8yJtsHZW6muZIEnW8a4mgDXK202okz2K229/+kGwz FRmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=khBfSoiP07rxsriYEWbezpvjGpbJCcBSnxoytsf5Ysw=; b=jDdST+QfMbQLKtS2lMCCcwkhcNUDV2xXHQZRBqHvFmdHrXkCDPtbLVeUKSG2hz97+O jerhk8k5OAMhvTqIIMPylGYfbaTWBWUMAooHJVbelMGZPvHbTpRgnuQbf0A9MAoggWic MjfVEKmPmDAoVmv8g1WIruihCvzunjkr+5k0NjKB3o0V5J0adjgUu8qJpo2Op+152FKg TSvgkFn0/bG6JWDxFSMRtBaV5Sznn9wNodHJL0hddQgyA366TBiTXdAXjGhq1iSfIQ/S lfP2RzHSe3Ds54cS4F1iyAPbhE6McFI3rgFa2BpxHfrRz1HfL9om8tJbgmkdzirErX5e 40qQ== X-Gm-Message-State: AOAM5333zJgewUIuM9JjCDxM2V2F68/j5xCi9eglA9mFLbu9nhIpAn/a eYoS+5SV7IEJ9g2TS2SkWlqUZGzp9W6UDrCAKRw= X-Google-Smtp-Source: ABdhPJwWIUZykewWBJlhpdiYbdlEhmybKvemUuNXVnKy+YmZjdC1FT6k7jt0O3GXcSKHvfB+gv63xRKNdamQuvDW0r8= X-Received: by 2002:aa7:cf17:: with SMTP id a23mr29541318edy.30.1617027430780; Mon, 29 Mar 2021 07:17:10 -0700 (PDT) MIME-Version: 1.0 References: <20210328184533.752840-1-marcandre.lureau@redhat.com> In-Reply-To: From: =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= Date: Mon, 29 Mar 2021 18:16:59 +0400 Message-ID: Subject: Re: [PULL 00/10] For 6.0 patches To: Peter Maydell , Lukas Straub Content-Type: multipart/alternative; boundary="0000000000009a906c05bead896a" Received-SPF: pass client-ip=2a00:1450:4864:20::52a; envelope-from=marcandre.lureau@gmail.com; helo=mail-ed1-x52a.google.com X-Spam_score_int: -8 X-Spam_score: -0.9 X-Spam_bar: / X-Spam_report: (-0.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, NUMERIC_HTTP_ADDR=1.242, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, WEIRD_PORT=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: QEMU Developers Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --0000000000009a906c05bead896a Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi On Mon, Mar 29, 2021 at 5:54 PM Peter Maydell wrote: > On Sun, 28 Mar 2021 at 19:45, wrote: > > > > From: Marc-Andr=C3=A9 Lureau > > > > The following changes since commit > 7b9a3c9f94bcac23c534bc9f42a9e914b433b299: > > > > Merge remote-tracking branch > 'remotes/kraxel/tags/fixes-20210326-pull-request' into staging (2021-03-2= 6 > 12:58:58 +0000) > > > > are available in the Git repository at: > > > > git@gitlab.com:marcandre.lureau/qemu.git tags/for-6.0-pull-request > > > > for you to fetch changes up to f57d44b452e11d8b7c9743476c30a8d0f80926de= : > > > > tests: Add tests for yank with the chardev-change case (2021-03-27 > 13:57:40 +0400) > > > > ---------------------------------------------------------------- > > For 6.0 misc patches under my radar. > > > > Peter, let me know if you would rather split that PR. > > > > ---------------------------------------------------------------- > > This produces a backtrace from sphinx-build which nonetheless doesn't > cause a build failure: > > > Program sphinx-build found: YES > ../docs/meson.build:30: WARNING: /usr/bin/sphinx-build: > Configuration error: > There is a programable error in your configuration file: > > Traceback (most recent call last): > File "conf.py", line 154, in > import sphinx_rtd_theme > ModuleNotFoundError: No module named 'sphinx_rtd_theme' > > During handling of the above exception, another exception occurred: > > Traceback (most recent call last): > File "/usr/lib/python3/dist-packages/sphinx/config.py", line 157, in > __init__ > execfile_(filename, config) > File "/usr/lib/python3/dist-packages/sphinx/util/pycompat.py", line > 150, in execfile_ > exec_(code, _globals) > File "conf.py", line 157, in > 'The Sphinx \'sphinx_rtd_theme\' HTML theme was not found.\n' > sphinx.errors.ConfigError: The Sphinx 'sphinx_rtd_theme' HTML theme > was not found. > > ../docs/meson.build:30: WARNING: /usr/bin/sphinx-build-3: Configuration error: The Sphinx 'sphinx_rtd_theme' HTML theme was not found. ../docs/meson.build:32:6: ERROR: Problem encountered: Install a Python 3 version of python-sphinx and the readthedoc theme It's only fatal if you explicitely enabled docs. Otherwise, it just prints a warning and disable it (just like sphinx 3.6 version requirement). > > > Program python3 found: YES (/usr/bin/python3) > > > In particular I see that on all the BSD VMs. If we're going to > require rtd that means we need to ensure it's present on all > the VM configs, docker configs, everything the CI uses, etc. > You should also flag up new build-deps in the pullreq cover > letter. > I updated all docker configs. We don't have sphinx in the BSD VMs apparently, am I wrong? > I dunno if we can get the error message neater (I know sphinx-build, > especially older versions, is a bit unhelpful about what it lets us > report.) > > The test-yank stuff also failed on OSX: > > Unexpected error in inet_connect_addr() at ../../util/qemu-sockets.c:380: > Failed to connect to '127.0.0.1:63820': Operation timed out > ERROR test-yank - too few tests run (expected 6, got 1) > > Lukas, can you have a look too? thanks --=20 Marc-Andr=C3=A9 Lureau --0000000000009a906c05bead896a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi

On Mon, Mar 29, 2021 at 5:54 PM Pet= er Maydell <peter.maydell@li= naro.org> wrote:
On Sun, 28 Mar 2021 at 19:45, <marcandre.lureau@redhat.com> wrote:<= br> >
> From: Marc-Andr=C3=A9 Lureau <marcandre.lureau@redhat.com>
>
> The following changes since commit 7b9a3c9f94bcac23c534bc9f42a9e914b43= 3b299:
>
>=C2=A0 =C2=A0Merge remote-tracking branch 'remotes/kraxel/tags/fixe= s-20210326-pull-request' into staging (2021-03-26 12:58:58 +0000)
>
> are available in the Git repository at:
>
>=C2=A0 =C2=A0git@gitlab.com:marcandre.lureau/qemu.git tags/for-6.0-pull= -request
>
> for you to fetch changes up to f57d44b452e11d8b7c9743476c30a8d0f80926d= e:
>
>=C2=A0 =C2=A0tests: Add tests for yank with the chardev-change case (20= 21-03-27 13:57:40 +0400)
>
> ----------------------------------------------------------------
> For 6.0 misc patches under my radar.
>
> Peter, let me know if you would rather split that PR.
>
> ----------------------------------------------------------------

This produces a backtrace from sphinx-build which nonetheless doesn't cause a build failure:


Program sphinx-build found: YES
../docs/meson.build:30: WARNING: /usr/bin/sphinx-build:
Configuration error:
There is a programable error in your configuration file:

Traceback (most recent call last):
=C2=A0 File "conf.py", line 154, in <module>
=C2=A0 =C2=A0 import sphinx_rtd_theme
ModuleNotFoundError: No module named 'sphinx_rtd_theme'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
=C2=A0 File "/usr/lib/python3/dist-packages/sphinx/config.py", li= ne 157, in __init__
=C2=A0 =C2=A0 execfile_(filename, config)
=C2=A0 File "/usr/lib/python3/dist-packages/sphinx/util/pycompat.py&qu= ot;, line
150, in execfile_
=C2=A0 =C2=A0 exec_(code, _globals)
=C2=A0 File "conf.py", line 157, in <module>
=C2=A0 =C2=A0 'The Sphinx \'sphinx_rtd_theme\' HTML theme was n= ot found.\n'
sphinx.errors.ConfigError: The Sphinx 'sphinx_rtd_theme' HTML theme=
was not found.



../docs/meson.build:30:= WARNING: /usr/bin/sphinx-build-3:
Configuration error:
The Sphinx &= #39;sphinx_rtd_theme' HTML theme was not found.

../docs/meson.bu= ild:32:6: ERROR: Problem encountered: Install a Python 3 version of python-= sphinx and the readthedoc theme

It's only = fatal if you explicitely enabled docs. Otherwise, it just prints a warning = and disable it (just like sphinx 3.6 version requirement).
= =C2=A0


Program python3 found: YES (/usr/bin/python3)


In particular I see that on all the BSD VMs. If we're going to
require rtd that means we need to ensure it's present on all
the VM configs, docker configs, everything the CI uses, etc.
You should also flag up new build-deps in the pullreq cover
letter.

I updated all docker configs. W= e don't have sphinx in the BSD VMs apparently, am I wrong?


I dunno if we can get the error message neater (I know sphinx-build,
especially older versions, is a bit unhelpful about what it lets us
report.)

The test-yank stuff also failed on OSX:

Unexpected error in inet_connect_addr() at ../../util/qemu-sockets.c:380: Failed to connect to '127.0.0.1:63820': Operation timed out
ERROR test-yank - too few tests run (expected 6, got 1)


Lukas, can you have a look too?

<= div>thanks

--
Marc-Andr=C3=A9 Lureau
--0000000000009a906c05bead896a--