Re: [Qemu-devel] [PATCH v2 1/3] char: clean up remaining chardevs when leaving

["Marc-André Lureau" <marcandre.lureau@gmail.com>]

Hi

On Wed, Jun 29, 2016 at 12:53 PM, Paolo Bonzini <pbonzini@redhat.com> wrote:
>
>
> On 16/06/2016 21:28, marcandre.lureau@redhat.com wrote:
>> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>>
>> This helps to remove various chardev resources leaks when leaving qemu.
>>
>> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
>> ---
>>  qemu-char.c | 11 +++++++++++
>>  1 file changed, 11 insertions(+)
>>
>> diff --git a/qemu-char.c b/qemu-char.c
>> index c926e9a..98dcd49 100644
>> --- a/qemu-char.c
>> +++ b/qemu-char.c
>> @@ -4541,6 +4541,15 @@ void qmp_chardev_remove(const char *id, Error **errp)
>>      qemu_chr_delete(chr);
>>  }
>>
>> +static void qemu_chr_cleanup(void)
>> +{
>> +    CharDriverState *chr;
>> +
>> +    QTAILQ_FOREACH(chr, &chardevs, next) {
>> +        qemu_chr_delete(chr);
>> +    }
>> +}
>
> FYI, this patch is necessary on top:
>
> diff --git a/qemu-char.c b/qemu-char.c
> index 016badb..bc04ced 100644
> --- a/qemu-char.c
> +++ b/qemu-char.c
> @@ -4551,9 +4551,9 @@
>
>  static void qemu_chr_cleanup(void)
>  {
> -    CharDriverState *chr;
> +    CharDriverState *chr, *tmp;
>
> -    QTAILQ_FOREACH(chr, &chardevs, next) {
> +    QTAILQ_FOREACH_SAFE(chr, &chardevs, next, tmp) {
>          qemu_chr_delete(chr);
>      }
>  }
>

ack, I guess you'll have it in your pull request? squash or seperate, anyhow.

thanks



-- 
Marc-André Lureau