From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFDEEC433DB for ; Wed, 24 Mar 2021 08:40:57 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 42084619F3 for ; Wed, 24 Mar 2021 08:40:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 42084619F3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:35758 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lOz4S-0006cZ-Bq for qemu-devel@archiver.kernel.org; Wed, 24 Mar 2021 04:40:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35678) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lOyym-0003P4-Py for qemu-devel@nongnu.org; Wed, 24 Mar 2021 04:35:04 -0400 Received: from mail-ej1-x632.google.com ([2a00:1450:4864:20::632]:38635) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lOyyk-0000b8-EE for qemu-devel@nongnu.org; Wed, 24 Mar 2021 04:35:04 -0400 Received: by mail-ej1-x632.google.com with SMTP id r12so31464825ejr.5 for ; Wed, 24 Mar 2021 01:35:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=nV+/3vN86Qa4nDdhgJJ5f5B6akJxHtpKUrSP/TVK5QU=; b=EkYTGO0vPnYk1SPa+jSxFsbWIDc78VC/Liv3GTgBgZvx+yQnHb7hX2xeKP9zCmR+r3 2wdRVq7EZPuq3oP9vR8eVpyI1F3loZGSlvyFKrTAdefbJenfDV76Nwd/B1QV0Wn9qH9x NuWtbTajI99r1ROVsWkVPn1DdN5tjCk5BEs55/Z99ixpsRR1u20BZ30TgjXLAU/DXVrH 9xRmDAzI2NXxgHxY1u7mv0SN1BzOPgTcUcqpNN0UNNpoOA1iBADVomykwwd1aLelzhCK 2/5kL5uMsBiH/JWykVgLx9KrttvRmbIQeRZOkdGdeyI2MO/A5noGmXmDpOGbm5jm7kZ4 EQ9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nV+/3vN86Qa4nDdhgJJ5f5B6akJxHtpKUrSP/TVK5QU=; b=bIjfW4egI8d6nIeYYVQhhShLmd3xmVEf5DceobpPoArOtMnYt8ScqnlCcdim/d/yDh N238PH7vV943UF7IzUWabHyeyrtzsvuscegbUxJ6vjxXzvAKMBejgXcIrMDvvFZNPXbH DhWylRrYMV8DJMbJyTBUWgyToghDKUI2qiuVGUUFSSQyje8JNZW0wNBme58+smbNElni V4JRUe2kd6y0rztF+xvNIHBHkSsqvFjC83CRCsewxrVrDX0YopsTKrHDhIv6CEGmLKIj HJTxFiL7kQsRiKDDTNzOUJtHSb658SYYwY3MDoTvStJ8KoqqiUX4HIEnh5DAiC6e4IYD 9FSg== X-Gm-Message-State: AOAM531lB7f7oarCkgtG17NP/nFidlDIl8EsNkJFSUw43Zmt/7L+Jjho ODNdD8A8/+9KUrWUh6EgZbnx8p4kYkq09qcuhxQ= X-Google-Smtp-Source: ABdhPJxIAaTl8rX/9BqqNQBpCNNvQ9Aw/T5w/WrgAdqAzec4C7a8SZ5+QEup6oXvf01+VTfnFsBfa2qnrG5HFUsOYQM= X-Received: by 2002:a17:906:cf90:: with SMTP id um16mr2431477ejb.389.1616574899432; Wed, 24 Mar 2021 01:34:59 -0700 (PDT) MIME-Version: 1.0 References: <20210323221539.3532660-1-crosa@redhat.com> <20210323221539.3532660-9-crosa@redhat.com> In-Reply-To: <20210323221539.3532660-9-crosa@redhat.com> From: =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= Date: Wed, 24 Mar 2021 12:34:47 +0400 Message-ID: Subject: Re: [PATCH v2 08/10] tests/acceptance/virtiofs_submounts.py: remove launch_vm() To: Cleber Rosa Content-Type: multipart/alternative; boundary="000000000000a2325c05be442ccd" Received-SPF: pass client-ip=2a00:1450:4864:20::632; envelope-from=marcandre.lureau@gmail.com; helo=mail-ej1-x632.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Aleksandar Rikalo , Eduardo Habkost , John Snow , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= , Wainer dos Santos Moschetta , QEMU , Willian Rampazzo , Eric Auger , Willian Rampazzo , Thomas Huth , Max Reitz , =?UTF-8?B?QWxleCBCZW5uw6ll?= , Aurelien Jarno , Beraldo Leal Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --000000000000a2325c05be442ccd Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Mar 24, 2021 at 2:32 AM Cleber Rosa wrote: > The LinuxTest class' launch_and_wait() method now behaves the same way > as this test's custom launch_vm(), so let's just use the upper layer > (common) method. > > Signed-off-by: Cleber Rosa > Reviewed-by: Marc-Andr=C3=A9 Lureau > --- > tests/acceptance/virtiofs_submounts.py | 13 +++++-------- > 1 file changed, 5 insertions(+), 8 deletions(-) > > diff --git a/tests/acceptance/virtiofs_submounts.py > b/tests/acceptance/virtiofs_submounts.py > index e019d3b896..d77ee35674 100644 > --- a/tests/acceptance/virtiofs_submounts.py > +++ b/tests/acceptance/virtiofs_submounts.py > @@ -134,9 +134,6 @@ def set_up_virtiofs(self): > '-numa', > 'node,memdev=3Dmem') > > - def launch_vm(self): > - self.launch_and_wait() > - > def set_up_nested_mounts(self): > scratch_dir =3D os.path.join(self.shared_dir, 'scratch') > try: > @@ -225,7 +222,7 @@ def test_pre_virtiofsd_set_up(self): > self.set_up_nested_mounts() > > self.set_up_virtiofs() > - self.launch_vm() > + self.launch_and_wait() > self.mount_in_guest() > self.check_in_guest() > > @@ -235,14 +232,14 @@ def test_pre_launch_set_up(self): > > self.set_up_nested_mounts() > > - self.launch_vm() > + self.launch_and_wait() > self.mount_in_guest() > self.check_in_guest() > > def test_post_launch_set_up(self): > self.set_up_shared_dir() > self.set_up_virtiofs() > - self.launch_vm() > + self.launch_and_wait() > > self.set_up_nested_mounts() > > @@ -252,7 +249,7 @@ def test_post_launch_set_up(self): > def test_post_mount_set_up(self): > self.set_up_shared_dir() > self.set_up_virtiofs() > - self.launch_vm() > + self.launch_and_wait() > self.mount_in_guest() > > self.set_up_nested_mounts() > @@ -265,7 +262,7 @@ def test_two_runs(self): > self.set_up_nested_mounts() > > self.set_up_virtiofs() > - self.launch_vm() > + self.launch_and_wait() > self.mount_in_guest() > self.check_in_guest() > > -- > 2.25.4 > > > --=20 Marc-Andr=C3=A9 Lureau --000000000000a2325c05be442ccd Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Wed, Mar 24, 2021 at 2:32 AM Clebe= r Rosa <crosa@redhat.com> wro= te:
The LinuxTes= t class' launch_and_wait() method now behaves the same way
as this test's custom launch_vm(), so let's just use the upper laye= r
(common) method.

Signed-off-by: Cleber Rosa <crosa@redhat.com>

Re= viewed-by: Marc-Andr=C3=A9 Lureau <marcandre.lureau@redhat.com>
<= div>

=C2=A0
---
=C2=A0tests/acceptance/virtiofs_submounts.py | 13 +++++--------
=C2=A01 file changed, 5 insertions(+), 8 deletions(-)

diff --git a/tests/acceptance/virtiofs_submounts.py b/tests/acceptance/virt= iofs_submounts.py
index e019d3b896..d77ee35674 100644
--- a/tests/acceptance/virtiofs_submounts.py
+++ b/tests/acceptance/virtiofs_submounts.py
@@ -134,9 +134,6 @@ def set_up_virtiofs(self):
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 '-numa',
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 'node,memdev=3Dmem')

-=C2=A0 =C2=A0 def launch_vm(self):
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 self.launch_and_wait()
-
=C2=A0 =C2=A0 =C2=A0def set_up_nested_mounts(self):
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0scratch_dir =3D os.path.join(self.shared_= dir, 'scratch')
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0try:
@@ -225,7 +222,7 @@ def test_pre_virtiofsd_set_up(self):
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0self.set_up_nested_mounts()

=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0self.set_up_virtiofs()
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 self.launch_vm()
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 self.launch_and_wait()
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0self.mount_in_guest()
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0self.check_in_guest()

@@ -235,14 +232,14 @@ def test_pre_launch_set_up(self):

=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0self.set_up_nested_mounts()

-=C2=A0 =C2=A0 =C2=A0 =C2=A0 self.launch_vm()
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 self.launch_and_wait()
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0self.mount_in_guest()
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0self.check_in_guest()

=C2=A0 =C2=A0 =C2=A0def test_post_launch_set_up(self):
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0self.set_up_shared_dir()
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0self.set_up_virtiofs()
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 self.launch_vm()
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 self.launch_and_wait()

=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0self.set_up_nested_mounts()

@@ -252,7 +249,7 @@ def test_post_launch_set_up(self):
=C2=A0 =C2=A0 =C2=A0def test_post_mount_set_up(self):
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0self.set_up_shared_dir()
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0self.set_up_virtiofs()
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 self.launch_vm()
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 self.launch_and_wait()
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0self.mount_in_guest()

=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0self.set_up_nested_mounts()
@@ -265,7 +262,7 @@ def test_two_runs(self):
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0self.set_up_nested_mounts()

=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0self.set_up_virtiofs()
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 self.launch_vm()
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 self.launch_and_wait()
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0self.mount_in_guest()
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0self.check_in_guest()

--
2.25.4




--
Marc-Andr=C3=A9 Lureau
--000000000000a2325c05be442ccd--