Re: [PATCH] tests/vhost-user-bridge.c: Sanity check socket path length - Marc-André Lureau

From: "Marc-André Lureau" <marcandre.lureau@gmail.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU <qemu-devel@nongnu.org>, "Michael S . Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH] tests/vhost-user-bridge.c: Sanity check socket path length
Date: Wed, 1 Sep 2021 20:48:57 +0400	[thread overview]
Message-ID: <CAJ+F1CJok+8MvmLLgwb10=+Pz=YetZBBQbuYaHu_5gLSR-hydA@mail.gmail.com> (raw)
In-Reply-To: <20210901152632.25511-1-peter.maydell@linaro.org>

[-- Attachment #1: Type: text/plain, Size: 1136 bytes --]

On Wed, Sep 1, 2021 at 8:36 PM Peter Maydell <peter.maydell@linaro.org>
wrote:

> The vhost-user-bridge binary accepts a UNIX socket path on
> the command line. Sanity check that this is short enough to
> fit into a sockaddr_un before copying it in.
>
> Fixes: Coverity CID 1432866
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
>

Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>

---
>  tests/vhost-user-bridge.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/tests/vhost-user-bridge.c b/tests/vhost-user-bridge.c
> index 24815920b2b..cb009545fa5 100644
> --- a/tests/vhost-user-bridge.c
> +++ b/tests/vhost-user-bridge.c
> @@ -540,6 +540,11 @@ vubr_new(const char *path, bool client)
>      CallbackFunc cb;
>      size_t len;
>
> +    if (strlen(path) >= sizeof(un.sun_path)) {
> +        fprintf(stderr, "unix domain socket path '%s' is too long\n",
> path);
> +        exit(1);
> +    }
> +
>      /* Get a UNIX socket. */
>      dev->sock = socket(AF_UNIX, SOCK_STREAM, 0);
>      if (dev->sock == -1) {
> --
> 2.20.1
>
>
>

-- 
Marc-André Lureau

[-- Attachment #2: Type: text/html, Size: 1919 bytes --]