From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E3623C433F5 for ; Wed, 27 Apr 2022 10:44:03 +0000 (UTC) Received: from localhost ([::1]:41204 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1njf9P-0004Gp-0r for qemu-devel@archiver.kernel.org; Wed, 27 Apr 2022 06:44:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60360) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njf4o-0001ic-Nf for qemu-devel@nongnu.org; Wed, 27 Apr 2022 06:39:19 -0400 Received: from mail-qt1-x82f.google.com ([2607:f8b0:4864:20::82f]:39632) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1njf4n-0000Hi-3N for qemu-devel@nongnu.org; Wed, 27 Apr 2022 06:39:18 -0400 Received: by mail-qt1-x82f.google.com with SMTP id x9so799664qts.6 for ; Wed, 27 Apr 2022 03:39:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=bMFKpGPI7GGZnUf2AbunAheONGkvKapZaP4WHQnQQHs=; b=oFlMvg16bbmDX80QaJAK475Q/DRne8nfArgciiC5wlfdA2rmyP/Gu8mVxY3FFdtSxX x1qOzqCzS98Sc7TCeyrtH/CqNGm346U61mgpEWG9PfQI3Ew2yzQBox0CzYUvENngo92l gH2m7TlGVcmv038rer+KZlzU5v8BKkgxXPkgR3YnMaxR+QjiCH2oxfuaYVDE5hPF12Mm zlN3WGMda2yVs9/8ZXw36/6gn9CBzav9EU7eDMd/oXBLnD8Zx4FXL84mRv12yMJLiNkU AbFqNgrgoeXP9EW9x4fvQAIIQ0hoNksg5sMn/RYv197kNIknvVKeTIiVFyyjjZzLJBCN TUPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=bMFKpGPI7GGZnUf2AbunAheONGkvKapZaP4WHQnQQHs=; b=Ud4BbOHXcX5a2piaGI0QS76a81xQBRBugbK5ICItntx6ZWDSfjr30/tpbSSkjQSsDv 01jw/GUPbebu6jmdErJ3BIPKyc8/lDM8ya7ny95scOVVPo6n4EukTcE0nrtyBa8Uz1ez dumir9d+qIAyaYsbs2SKMsIhiwrxUL+aaapIx+rv89fp3WmqyLusMyYwHSOHkAeThUAc fjHmPo2rpoleYgv6DiPvFEbxrr1g9oxEAKTImgyqFItnhR6iuFoWaYA9ritVQh2SMJ6N aj0QHsxglrC3ooNXcbZCO/KrdULP/HuIckrW6S2bySXX8igSyqIT/FVlRVG8M+bVK3P2 ZaNw== X-Gm-Message-State: AOAM530cuUrL37t8B3CkPrulHVMgm12r3vj+8JlvD18vkoYNb+aFTPpU LRz6Y1UQ6y1CjqLlbeZMdEkXYzjj6qmMFfKGNpc= X-Google-Smtp-Source: ABdhPJwn+bTV+hnBE4agjdNEXl7M4TfvEG/Th8N2XjcCWQXcCxiAydWhzsW/iKPVONh8jY1OF8+AHx7ZqIFl+xH4Xcg= X-Received: by 2002:a05:622a:144e:b0:2f3:4da8:6a77 with SMTP id v14-20020a05622a144e00b002f34da86a77mr18123566qtx.574.1651055952609; Wed, 27 Apr 2022 03:39:12 -0700 (PDT) MIME-Version: 1.0 References: <20220426092715.3931705-1-marcandre.lureau@redhat.com> <20220426092715.3931705-27-marcandre.lureau@redhat.com> In-Reply-To: From: =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= Date: Wed, 27 Apr 2022 14:39:01 +0400 Message-ID: Subject: Re: [PATCH v2 26/26] util: rename qemu_*block() socket functions To: Stefan Hajnoczi Content-Type: multipart/alternative; boundary="0000000000008f432205dda06bf3" Received-SPF: pass client-ip=2607:f8b0:4864:20::82f; envelope-from=marcandre.lureau@gmail.com; helo=mail-qt1-x82f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?Q?Daniel_P=2E_Berrang=C3=A9?= , "Michael S. Tsirkin" , Michael Roth , Jason Wang , QEMU , Coiby Xu , Stefan Weil , Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --0000000000008f432205dda06bf3 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Stefan On Tue, Apr 26, 2022 at 6:33 PM Stefan Hajnoczi wrote: > On Tue, Apr 26, 2022 at 01:27:15PM +0400, marcandre.lureau@redhat.com > wrote: > > From: Marc-Andr=C3=A9 Lureau > > > > The qemu_*block() functions are meant to be be used with sockets (the > > win32 implementation expects SOCKET) > > > > Over time, those functions where used with Win32 SOCKET or > > file-descriptors interchangeably. But for portability, they must only b= e > > used with socket-like file-descriptors. FDs can use > > g_unix_set_fd_nonblocking() instead. > > > > Rename the functions with "socket" in the name to prevent bad usages. > > > > Signed-off-by: Marc-Andr=C3=A9 Lureau > > --- > > include/qemu/sockets.h | 6 +++--- > > chardev/char-socket.c | 2 +- > > contrib/ivshmem-server/ivshmem-server.c | 2 +- > > hw/hyperv/syndbg.c | 2 +- > > hw/virtio/vhost-user.c | 2 +- > > io/channel-socket.c | 6 +++--- > > net/l2tpv3.c | 2 +- > > net/socket.c | 10 +++++----- > > qga/channel-posix.c | 2 +- > > tests/unit/socket-helpers.c | 2 +- > > tests/unit/test-crypto-tlssession.c | 8 ++++---- > > util/oslib-posix.c | 8 ++++---- > > util/oslib-win32.c | 8 ++++---- > > util/vhost-user-server.c | 4 ++-- > > 14 files changed, 32 insertions(+), 32 deletions(-) > > Thanks for fixing this! > > Reviewed-by: Stefan Hajnoczi > Thanks, could you also review the preliminary patches 19-25 ? They reduce the usage of qemu_socket* functions, and use glib API instead. --=20 Marc-Andr=C3=A9 Lureau --0000000000008f432205dda06bf3 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Stefan

On Tue, Apr 26, 2022 at 6:33= PM Stefan Hajnoczi <stefanha@gmai= l.com> wrote:
On Tue, Apr 26, 2022 at 01:27:15PM +0400, marcandre.lureau@redhat.com wrote:=
> From: Marc-Andr=C3=A9 Lureau <marcandre.lureau@redhat.com>
>
> The qemu_*block() functions are meant to be be used with sockets (the<= br> > win32 implementation expects SOCKET)
>
> Over time, those functions where used with Win32 SOCKET or
> file-descriptors interchangeably. But for portability, they must only = be
> used with socket-like file-descriptors. FDs can use
> g_unix_set_fd_nonblocking() instead.
>
> Rename the functions with "socket" in the name to prevent ba= d usages.
>
> Signed-off-by: Marc-Andr=C3=A9 Lureau <marcandre.lureau@redhat.com> > ---
>=C2=A0 include/qemu/sockets.h=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 |=C2=A0 6 +++---
>=C2=A0 chardev/char-socket.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 2 +-
>=C2=A0 contrib/ivshmem-server/ivshmem-server.c |=C2=A0 2 +-
>=C2=A0 hw/hyperv/syndbg.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0 2 +-
>=C2=A0 hw/virtio/vhost-user.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 |=C2=A0 2 +-
>=C2=A0 io/channel-socket.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 6 +++---
>=C2=A0 net/l2tpv3.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0 2 +-
>=C2=A0 net/socket.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 | 10 +++++-----
>=C2=A0 qga/channel-posix.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 2 +-
>=C2=A0 tests/unit/socket-helpers.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0|=C2=A0 2 +-
>=C2=A0 tests/unit/test-crypto-tlssession.c=C2=A0 =C2=A0 =C2=A0|=C2=A0 8= ++++----
>=C2=A0 util/oslib-posix.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0 8 ++++----
>=C2=A0 util/oslib-win32.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0 8 ++++----
>=C2=A0 util/vhost-user-server.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 |=C2=A0 4 ++--
>=C2=A0 14 files changed, 32 insertions(+), 32 deletions(-)

Thanks for fixing this!

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

<= div>Thanks, could you also review the preliminary patches 19-25 ? They redu= ce the usage of qemu_socket* functions, and use glib API instead.

--
Marc-Andr=C3= =A9 Lureau
--0000000000008f432205dda06bf3--