From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,INCLUDES_PULL_REQUEST, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A974C11F64 for ; Thu, 1 Jul 2021 06:30:33 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0A1EB6145A for ; Thu, 1 Jul 2021 06:30:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0A1EB6145A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:43500 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lyqDY-0002bx-3w for qemu-devel@archiver.kernel.org; Thu, 01 Jul 2021 02:30:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34292) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lyqCf-0001vP-CZ for qemu-devel@nongnu.org; Thu, 01 Jul 2021 02:29:37 -0400 Received: from mail-ej1-x62e.google.com ([2a00:1450:4864:20::62e]:39574) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lyqCc-0001aH-S7 for qemu-devel@nongnu.org; Thu, 01 Jul 2021 02:29:37 -0400 Received: by mail-ej1-x62e.google.com with SMTP id yy20so8563066ejb.6 for ; Wed, 30 Jun 2021 23:29:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8YKIHO/FVQv45lvLjIsNJHrQfhXYidPceUDg13XbKDU=; b=nkdgtEPf17v4s8u1nykLLrupODBrl1/ZFHSgkjZwGxH1kw3k3bw9wzlijhVn4BZoOg rTX7wTHi/Lwoe/1jw3GUpESYv2BS7hZ9VSod7iuK6ufFf0w6ml8c83MjGWWcXyT0xchN D6Z1cw/JRNoWGIkG/GTg5hVl1Lj93UFUoTLm7AprVDL3E7kuEN0dwAJbYJHNyjNSsnRu 9dHom3crjE8F6gCPVcRfG0WXnrxse5N22XdrKOprPIRBkpcsigrae2D62PX8TOThkPnZ hrbDqdcLBzQFeJYCmaN/XHtx9gA8DiyII7RVDEp1i9CEtJasEbZcPB8VYC/ibAT8v9LE oKeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8YKIHO/FVQv45lvLjIsNJHrQfhXYidPceUDg13XbKDU=; b=t6N714PyX7wwsM1khKuM/fkTzT3VQraXw7uBXHoC85jfJEBzpJW5svYR+1YA93Hkng PbCdDJ868C8DPqX3fxRilYREqUW9EJ3uS6wKsoECLknvfourCGmBawPQyOC9ojrZKz23 8ItsNmHecSA+4wZ9kqqrNK1M2LSBnuSJuVEyUVN8k9kpGYwD2iIjeWQQkw/dKFbgwgqj LA1SfwfZMApxc86msnAK0FN0Y+Laz1Nq54+HTsFRkOEV0+mfzUu4uP8lhinj3qQ8vJWY LMtUKKbMUIdzJGrPzeD0XTf/KPRs3DeNk5qDsgBv+M055c2lCCNoMhQG+jlB93NWeyoO F+uQ== X-Gm-Message-State: AOAM5318SgScFFiDvxTP0M/k+oO///zd0MAIz6M/MwdT1AvQoajgjlxa su9kfgfiEVev/3EICzhYEKONMXfFsS5mIMc1n/o= X-Google-Smtp-Source: ABdhPJzAEpPfI6CDIjofZ5xBIM8FdC9FZqZblrAm4KEnVKDi3o3RjZj11fHWsF4RQHv8oN/QAkCDZ6ByEQHD4IMO8Lg= X-Received: by 2002:a17:907:ea5:: with SMTP id ho37mr9890022ejc.109.1625120973344; Wed, 30 Jun 2021 23:29:33 -0700 (PDT) MIME-Version: 1.0 References: <20210510132051.2208563-1-kraxel@redhat.com> In-Reply-To: From: =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= Date: Thu, 1 Jul 2021 10:29:21 +0400 Message-ID: Subject: Re: [PULL 00/25] Vga 20210510 patches To: Peter Maydell , Gerd Hoffmann Content-Type: multipart/alternative; boundary="00000000000055534a05c609f694" Received-SPF: pass client-ip=2a00:1450:4864:20::62e; envelope-from=marcandre.lureau@gmail.com; helo=mail-ej1-x62e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , QEMU Developers , "Michael S. Tsirkin" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --00000000000055534a05c609f694 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi On Wed, Jun 30, 2021 at 10:16 PM Marc-Andr=C3=A9 Lureau < marcandre.lureau@gmail.com> wrote: > Hi > > On Wed, May 12, 2021 at 7:07 PM Peter Maydell > wrote: > >> On Mon, 10 May 2021 at 14:22, Gerd Hoffmann wrote: >> > >> > The following changes since commit >> d90f154867ec0ec22fd719164b88716e8fd48672: >> > >> > Merge remote-tracking branch >> 'remotes/dg-gitlab/tags/ppc-for-6.1-20210504' into staging (2021-05-05 >> 20:29:14 +0100) >> > >> > are available in the Git repository at: >> > >> > git://git.kraxel.org/qemu tags/vga-20210510-pull-request >> > >> > for you to fetch changes up to b36eb8860f8f4a9c6f131c3fd380116a3017e02= 2: >> > >> > virtio-gpu: add virtio-vga-gl (2021-05-10 13:55:28 +0200) >> > >> > ---------------------------------------------------------------- >> > edid: display id support (for 5k+), bugfixes. >> > virtio-gpu: iommu fix, device split. >> > >> >> >> Applied, thanks. >> >> Please update the changelog at https://wiki.qemu.org/ChangeLog/6.1 >> for any user-visible changes. >> >> -- PMM >> >> > After that series, the console is flooded with GTK warnings. When the > machine/device is reset, virgl crashes (also reported at > https://gitlab.freedesktop.org/virgl/virglrenderer/-/issues/226) > > Unfortunately, it's not easy to pinpoint the responsible patch since it's > not easily bisectable (and it breaks the CLI). I will continue to > investigate. > It turns out that I was using -device to add the VGA device, and qemu didn't treat virtio-vga-gl the same way virtio-vga was. See "[PATCH] vl: add virtio-vga-gl to the default_list". The reason for the warnings and virgl crash is that the secondary gfx console GTK widgets aren't realized by the time virgl needs a context. This is a pre-existing issue (-display gtk,gl=3Don -device virtio-vga,virgl=3Don -device virtio-gpu,virgl=3Don qemu crashes) --=20 Marc-Andr=C3=A9 Lureau --00000000000055534a05c609f694 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi

On Wed, Jun 30, 2021 at 10:16 PM Ma= rc-Andr=C3=A9 Lureau <marc= andre.lureau@gmail.com> wrote:
Hi

On Wed, May 1= 2, 2021 at 7:07 PM Peter Maydell <peter.maydell@linaro.org> wrote:
On Mon, 10 May 2021 at 14:2= 2, Gerd Hoffmann <kraxel@redhat.com> wrote:
>
> The following changes since commit d90f154867ec0ec22fd719164b88716e8fd= 48672:
>
>=C2=A0 =C2=A0Merge remote-tracking branch 'remotes/dg-gitlab/tags/p= pc-for-6.1-20210504' into staging (2021-05-05 20:29:14 +0100)
>
> are available in the Git repository at:
>
>=C2=A0 =C2=A0git://git.kraxel.org/qemu tags/vga-20210510-pull-requ= est
>
> for you to fetch changes up to b36eb8860f8f4a9c6f131c3fd380116a3017e02= 2:
>
>=C2=A0 =C2=A0virtio-gpu: add virtio-vga-gl (2021-05-10 13:55:28 +0200)<= br> >
> ----------------------------------------------------------------
> edid: display id support (for 5k+), bugfixes.
> virtio-gpu: iommu fix, device split.
>


Applied, thanks.

Please update the changelog at https://wiki.qemu.org/ChangeLog/6.= 1
for any user-visible changes.

-- PMM


After that series, the console is fl= ooded with GTK warnings. When the machine/device is reset, virgl crashes (a= lso reported at https://gitlab.freedesktop.org/virgl/vir= glrenderer/-/issues/226)

Unfortunately, it'= ;s not easy to pinpoint the responsible patch since it's not easily bis= ectable (and it breaks the CLI). I will continue to investigate.
<= /div>


It turns out that I wa= s using -device to add the VGA device, and qemu didn't treat virtio-vga= -gl the same way virtio-vga was. See "[PATCH] vl: add virtio-vga-gl to= the default_list".

The reason for the warnin= gs and virgl crash is that the secondary gfx console GTK widgets aren't= realized by the time virgl needs a context. This is a pre-existing issue (= -display gtk,gl=3Don -device virtio-vga,virgl=3Don -device virtio-gpu,virgl= =3Don qemu crashes)
=C2=A0

--
Marc-Andr=C3=A9 Lureau
--00000000000055534a05c609f694--