From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D9BDC433F5 for ; Thu, 7 Oct 2021 20:43:43 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4E26060EDF for ; Thu, 7 Oct 2021 20:43:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4E26060EDF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:60076 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mYaEw-0007QG-FU for qemu-devel@archiver.kernel.org; Thu, 07 Oct 2021 16:43:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39050) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mYaD4-0004cE-EF for qemu-devel@nongnu.org; Thu, 07 Oct 2021 16:41:46 -0400 Received: from mail-wr1-x433.google.com ([2a00:1450:4864:20::433]:44867) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mYaD2-0005lT-N3 for qemu-devel@nongnu.org; Thu, 07 Oct 2021 16:41:46 -0400 Received: by mail-wr1-x433.google.com with SMTP id s15so22928440wrv.11 for ; Thu, 07 Oct 2021 13:41:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Bj73rBD9ayCjQXjXHbefp/qKoW99F+eZx5bwwRLCTY8=; b=lhb/cSasr7jqoI9VxcXZ7LCJR/W8rHO6HRcjXFdnxSB0pIB8aX/4oKBhWfKP34HIe1 fNOYjpONxWpGHIGoAPQhzbi80eA0tpNoCcX8I+1erZgYVY2e+wMmit9+hLyQ30fgmecH uDzbJwrVT3QDK7RPJ+YVC4TlCTO9jZbUMq1kjVrS5000ERxvAVPjJy2qHJsKHTeBLTai b6mZNu3GRaCFoAHFfu7OnC/2VHsgSXN4W+upebScbbCC7AntD4TamKG/9isNmBlESTcc S+1gJwOSu1yPyh2mVu5j8ZMFGQhVlNhkGjxU2AIValT6WMwKv+twpbhcGO53Bv9wZh7G 37Aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Bj73rBD9ayCjQXjXHbefp/qKoW99F+eZx5bwwRLCTY8=; b=M4ixWPiun3otl06Urc13HWQKnRDkK2D3hPrFXOAPgcfFRl9bU3Nzm2dyL1CDfHY7fT eO/zOAEp8gRBRDs3Qjy5c7SjYIpuZUsUiuqZIYLBXsFEBxxtBMi/oTc3Ko2rB6iDH9BU /IoRmj3Ictnub+oGLFyrpfT48Bb1aJB7fjo+8azc3dFiZ3TfXRKLt5ihzyvoIzXuXzCk hQedzGp2BeI6PB/tyQiG2ABue1zsb1O3BX0hhhAnW6imyMIHfkioB9cWgF1FtDhiU26q amsAjCszwQo+DkgxCZVkoAsllx0XbKSSVlJFI1HBwy4A05pElZh3WkRwPXfbSAljVbey ISlg== X-Gm-Message-State: AOAM530A1CaBGvN5Lco5iJlGciz3sMMq5ZMx8xrdoiKpjHll/EiYqmQs Tb+efI3SpU5rbgyxSFXx/5s9SPez6uZlCkm4nmU= X-Google-Smtp-Source: ABdhPJyu8jEdNO+XIdtfKmR6iPLDIOKH//sxV+VUla8Ycw1Vmn5Lh75WCCxCV9jeVnhRlxTTN7oMI9XugB7gP6QqpQE= X-Received: by 2002:a1c:ed0a:: with SMTP id l10mr7255640wmh.140.1633639303322; Thu, 07 Oct 2021 13:41:43 -0700 (PDT) MIME-Version: 1.0 References: <20211007130630.632028-1-pbonzini@redhat.com> <20211007130829.632254-14-pbonzini@redhat.com> In-Reply-To: <20211007130829.632254-14-pbonzini@redhat.com> From: =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= Date: Fri, 8 Oct 2021 00:41:28 +0400 Message-ID: Subject: Re: [PATCH 19/24] configure: remove obsolete Solaris ar check To: Paolo Bonzini Content-Type: multipart/alternative; boundary="0000000000005da27e05cdc94a30" Received-SPF: pass client-ip=2a00:1450:4864:20::433; envelope-from=marcandre.lureau@gmail.com; helo=mail-wr1-x433.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: QEMU Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --0000000000005da27e05cdc94a30 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Oct 7, 2021 at 5:17 PM Paolo Bonzini wrote: > Meson already has its own logic to find the "ar" binary, so remove the > Solaris specific check. > > Signed-off-by: Paolo Bonzini > Reviewed-by: Marc-Andr=C3=A9 Lureau > --- > configure | 15 --------------- > 1 file changed, 15 deletions(-) > > diff --git a/configure b/configure > index 016814d23b..2091844ad6 100755 > --- a/configure > +++ b/configure > @@ -2284,21 +2284,6 @@ EOF > fi > fi > > -######################################### > -# Solaris specific configure tool chain decisions > - > -if test "$solaris" =3D "yes" ; then > - if has ar; then > - : > - else > - if test -f /usr/ccs/bin/ar ; then > - error_exit "No path includes ar" \ > - "Add /usr/ccs/bin to your path and rerun configure" > - fi > - error_exit "No path includes ar" > - fi > -fi > - > if test "$tcg" =3D "enabled"; then > git_submodules=3D"$git_submodules tests/fp/berkeley-testfloat-3" > git_submodules=3D"$git_submodules tests/fp/berkeley-softfloat-3" > -- > 2.31.1 > > > > --=20 Marc-Andr=C3=A9 Lureau --0000000000005da27e05cdc94a30 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Thu, Oct 7, 2021 at 5:17 PM Paolo = Bonzini <pbonzi= ni@redhat.com> wrote:
Meson already has its own logic to find the "ar" bin= ary, so remove the
Solaris specific check.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

<= div>
Reviewed-by: Marc-Andr=C3=A9 Lureau <marcandre.lureau@redhat.com><= /div>=C2=A0
---
=C2=A0configure | 15 ---------------
=C2=A01 file changed, 15 deletions(-)

diff --git a/configure b/configure
index 016814d23b..2091844ad6 100755
--- a/configure
+++ b/configure
@@ -2284,21 +2284,6 @@ EOF
=C2=A0 =C2=A0fi
=C2=A0fi

-#########################################
-# Solaris specific configure tool chain decisions
-
-if test "$solaris" =3D "yes" ; then
-=C2=A0 if has ar; then
-=C2=A0 =C2=A0 :
-=C2=A0 else
-=C2=A0 =C2=A0 if test -f /usr/ccs/bin/ar ; then
-=C2=A0 =C2=A0 =C2=A0 error_exit "No path includes ar" \
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 "Add /usr/ccs/bin to your path and= rerun configure"
-=C2=A0 =C2=A0 fi
-=C2=A0 =C2=A0 error_exit "No path includes ar"
-=C2=A0 fi
-fi
-
=C2=A0if test "$tcg" =3D "enabled"; then
=C2=A0 =C2=A0 =C2=A0git_submodules=3D"$git_submodules tests/fp/berkele= y-testfloat-3"
=C2=A0 =C2=A0 =C2=A0git_submodules=3D"$git_submodules tests/fp/berkele= y-softfloat-3"
--
2.31.1





--
Marc-Andr= =C3=A9 Lureau
--0000000000005da27e05cdc94a30--