Re: [PATCH v2 3/4] Add virtio gpu driver. - Marc-André Lureau

From: "Marc-André Lureau" <marcandre.lureau@gmail.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: virtio-dev@lists.oasis-open.org,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"open list:ABI/API" <linux-api@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>,
	dri-devel@lists.freedesktop.org, "open list:VIRTIO CORE,
	NET..." <virtualization@lists.linux-foundation.org>,
	David Airlie <airlied@redhat.com>
Subject: Re: [PATCH v2 3/4] Add virtio gpu driver.
Date: Thu, 2 Apr 2015 17:52:40 +0200	[thread overview]
Message-ID: <CAJ+F1CK3ibbn8e1-rUY4OUJuaCt_=JmuT00Fqx4YDD9M5zJv=A__41566.6942870759$1427994414$gmane$org@mail.gmail.com> (raw)
In-Reply-To: <1427894130-14228-4-git-send-email-kraxel@redhat.com>

[-- Attachment #1.1: Type: text/plain, Size: 766 bytes --]

Hi Gerd

While doing some testing with your brance, I reached that:

On Wed, Apr 1, 2015 at 3:15 PM, Gerd Hoffmann <kraxel@redhat.com> wrote:

> +#define MAX_INLINE_CMD_SIZE   96
>

[  750.446449] kernel BUG at drivers/gpu/drm/virtio/virtgpu_vq.c:132!
[  750.447005] Call Trace:
[  750.447005]  [<ffffffffa00f3592>] virtio_gpu_alloc_cmd+0x22/0x50
[virtio_gpu]
[  750.447005]  [<ffffffffa00f4580>]
virtio_gpu_cmd_context_create+0x30/0xa0 [virtio_gpu]

struct virtio_gpu_ctx_create {
        struct virtio_gpu_ctrl_hdr hdr;
        __le32 nlen;
        __le32 padding;
        char debug_name[64];
};

Is actually 96 bytes.

Perhaps that condition should be changed:
+       BUG_ON(size >= MAX_INLINE_CMD_SIZE);

-- 
Marc-André Lureau

[-- Attachment #1.2: Type: text/html, Size: 1489 bytes --]

[-- Attachment #2: Type: text/plain, Size: 183 bytes --]

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization