From: "Marc-André Lureau" <marcandre.lureau@gmail.com>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: QEMU <qemu-devel@nongnu.org>, Alberto Garcia <berto@igalia.com>
Subject: Re: [Qemu-devel] [PATCH 0/6] crypto: improve performance of XTS cipher mode
Date: Tue, 9 Oct 2018 17:59:46 +0400 [thread overview]
Message-ID: <CAJ+F1CKAZU+aHuzO8Y-aT20uX-rywZB3BK0=1hqecSrPkUEp1Q@mail.gmail.com> (raw)
In-Reply-To: <20181009125541.24455-1-berrange@redhat.com>
Hi
On Tue, Oct 9, 2018 at 4:57 PM Daniel P. Berrangé <berrange@redhat.com> wrote:
>
> The XTS cipher mode is significantly slower than CBC mode. This series
> approximately doubles the XTS performance which will improve the I/O
> rate for LUKS disks.
>
> Daniel P. Berrangé (6):
> crypto: expand algorithm coverage for cipher benchmark
> crypto: remove code duplication in tweak encrypt/decrypt
> crypto: introduce a xts_uint128 data type
> crypto: convert xts_tweak_encdec to use xts_uint128 type
> crypto: convert xts_mult_x to use xts_uint128 type
> crypto: annotate xts_tweak_encdec as inlineable
>
> crypto/xts.c | 147 ++++++++++++++-----------------
> tests/benchmark-crypto-cipher.c | 149 +++++++++++++++++++++++++++-----
> 2 files changed, 191 insertions(+), 105 deletions(-)
By using a constant amount of data to process, it's easier to measure
perfomance with perf stat:
diff --git a/tests/benchmark-crypto-cipher.c b/tests/benchmark-crypto-cipher.c
index a8325a9510..32a19987e6 100644
--- a/tests/benchmark-crypto-cipher.c
+++ b/tests/benchmark-crypto-cipher.c
@@ -65,7 +65,7 @@ static void test_cipher_speed(size_t chunk_size,
chunk_size,
&err) == 0);
total += chunk_size;
- } while (g_test_timer_elapsed() < 1.0);
+ } while (total / MiB < 500);
total /= MiB;
g_print("Enc chunk %zu bytes ", chunk_size);
@@ -80,7 +80,7 @@ static void test_cipher_speed(size_t chunk_size,
chunk_size,
&err) == 0);
total += chunk_size;
- } while (g_test_timer_elapsed() < 1.0);
+ } while (total / MiB < 500);
On my laptop: before your series:
3701.625051 task-clock:u (msec) # 0.997 CPUs
utilized
0 context-switches:u # 0.000 K/sec
0 cpu-migrations:u # 0.000 K/sec
438 page-faults:u # 0.118 K/sec
10,823,305,761 cycles:u # 2.924 GHz
29,774,419,538 instructions:u # 2.75 insn per
cycle
4,919,267,782 branches:u # 1328.948 M/sec
32,923,105 branch-misses:u # 0.67% of all
branches
3.712998264 seconds time elapsed
Ater:
2151.201355 task-clock:u (msec) # 1.000 CPUs
utilized
0 context-switches:u # 0.000 K/sec
0 cpu-migrations:u # 0.000 K/sec
431 page-faults:u # 0.200 K/sec
7,073,869,618 cycles:u # 3.288 GHz
8,573,595,534 instructions:u # 1.21 insn per
cycle
1,576,926,668 branches:u # 733.045 M/sec
148,987 branch-misses:u # 0.01% of all
branches
2.151520872 seconds time elapsed
--
Marc-André Lureau
next prev parent reply other threads:[~2018-10-09 14:00 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-09 12:55 [Qemu-devel] [PATCH 0/6] crypto: improve performance of XTS cipher mode Daniel P. Berrangé
2018-10-09 12:55 ` [Qemu-devel] [PATCH 1/6] crypto: expand algorithm coverage for cipher benchmark Daniel P. Berrangé
2018-10-09 14:04 ` Marc-André Lureau
2018-10-10 11:45 ` Alberto Garcia
2018-10-09 12:55 ` [Qemu-devel] [PATCH 2/6] crypto: remove code duplication in tweak encrypt/decrypt Daniel P. Berrangé
2018-10-09 13:43 ` Alberto Garcia
2018-10-09 13:51 ` Marc-André Lureau
2018-10-09 12:55 ` [Qemu-devel] [PATCH 3/6] crypto: introduce a xts_uint128 data type Daniel P. Berrangé
2018-10-09 14:40 ` Alberto Garcia
2018-10-09 14:50 ` Alberto Garcia
2018-10-09 14:58 ` Daniel P. Berrangé
2018-10-09 15:14 ` Alberto Garcia
2018-10-09 12:55 ` [Qemu-devel] [PATCH 4/6] crypto: convert xts_tweak_encdec to use xts_uint128 type Daniel P. Berrangé
2018-10-09 15:02 ` Alberto Garcia
2018-10-09 15:06 ` Daniel P. Berrangé
2018-10-09 15:30 ` Alberto Garcia
2018-10-09 15:31 ` Daniel P. Berrangé
2018-10-11 12:16 ` Alberto Garcia
2018-10-09 12:55 ` [Qemu-devel] [PATCH 5/6] crypto: convert xts_mult_x " Daniel P. Berrangé
2018-10-09 13:52 ` Alberto Garcia
2018-10-09 13:55 ` Daniel P. Berrangé
2018-10-09 14:25 ` Alberto Garcia
2018-10-09 12:55 ` [Qemu-devel] [PATCH 6/6] crypto: annotate xts_tweak_encdec as inlineable Daniel P. Berrangé
2018-10-09 15:37 ` Alberto Garcia
2018-10-09 13:59 ` Marc-André Lureau [this message]
2018-10-09 14:13 ` [Qemu-devel] [PATCH 0/6] crypto: improve performance of XTS cipher mode Daniel P. Berrangé
2018-10-09 14:27 ` Marc-André Lureau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJ+F1CKAZU+aHuzO8Y-aT20uX-rywZB3BK0=1hqecSrPkUEp1Q@mail.gmail.com' \
--to=marcandre.lureau@gmail.com \
--cc=berrange@redhat.com \
--cc=berto@igalia.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.