From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60647) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z8W5c-0000Qp-7P for qemu-devel@nongnu.org; Fri, 26 Jun 2015 12:02:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z8W5b-000342-2M for qemu-devel@nongnu.org; Fri, 26 Jun 2015 12:02:52 -0400 Received: from mail-oi0-x230.google.com ([2607:f8b0:4003:c06::230]:33774) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z8W5a-00033r-T0 for qemu-devel@nongnu.org; Fri, 26 Jun 2015 12:02:51 -0400 Received: by oiyy130 with SMTP id y130so78547314oiy.0 for ; Fri, 26 Jun 2015 09:02:50 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <558D7592.6000607@suse.de> References: <1435330185-23248-1-git-send-email-marcandre.lureau@gmail.com> <1435330185-23248-40-git-send-email-marcandre.lureau@gmail.com> <558D6AF2.2080606@suse.de> <558D7592.6000607@suse.de> Date: Fri, 26 Jun 2015 18:02:50 +0200 Message-ID: From: =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= Content-Type: multipart/alternative; boundary=089e0115e7f830898f05196ddf0d Subject: Re: [Qemu-devel] [PATCH 39/39] tests: Add ivshmem qtest List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?Andreas_F=C3=A4rber?= Cc: cam , QEMU , stefanha@redhat.com, Alexander Graf --089e0115e7f830898f05196ddf0d Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi On Fri, Jun 26, 2015 at 5:53 PM, Andreas F=C3=A4rber wro= te: > Please don't use HTML mails, that breaks quoting as you can see below. > > I mostly use gmail, afaik it's multipart, never had issues with that. Am 26.06.2015 um 17:27 schrieb Marc-Andr=C3=A9 Lureau: > > On Fri, Jun 26, 2015 at 5:08 PM, Andreas F=C3=A4rber > > wrote: > > > > > > For the second time within days you're posting a patch for somethin= g > > that's been on the list already... The commit message above is > entirely > > > > > > Sorry which patch are you refering to? > > This one vs. my http://patchwork.ozlabs.org/patch/336367/ > > And my "[PATCH for-2.3? 0/7] tests: Fix TCG make test" series vs. > your http://patchwork.ozlabs.org/patch/487719/ > See my previous reply. > > > Is it wrong to repost a old patch and adding, while adding signoff and > > modifications? > > (what I just did in this series for David patches) > > "contrib: add ivshmem client and server" looks (formally) okay except > for the final [...], which should go before your Signed-off-by. > Ok, thanks I'll check that. > That's not what you've done here though, as I complained. You did not > ask me about the state of my patch either before you posted this. > I don't see what that changes. You can give the status of your patch now. > > > Tbh, your patch was just launching one instance of qemu with ivshmem. I= f > you > > look at the one I proposed, you'll notice that it is completely > > different: I don't think your > > signoff or copyright should be added here. > > Well, I disagree. Extending a test case does not give you the right to > replace SUSE with Red Hat. Makes it look like an NIH problem. > It's really a different patch, sorry. > Also, see the discussion on my RFC: CONFIG_LINUX is wrong here. It would > need to depend on KVM/eventfd, and for that there is no easy config > option available here, which stopped my patch at the time. > Right, I don't have good answer for that. I'd need more help. cheers --=20 Marc-Andr=C3=A9 Lureau --089e0115e7f830898f05196ddf0d Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi

On Fri, Jun 26, 2015 at 5:53 PM, And= reas F=C3=A4rber <afaerber@suse.de> wrote:
Pl= ease don't use HTML mails, that breaks quoting as you can see below.

I mostly use gmail,= afaik it's multipart, never had issues with that.

Am 26.06.2015 um 17:27 schrieb Marc-Andr=C3=A9 Lureau:
> On Fri, Jun 26, 2015 at 5:08 PM, Andreas F=C3=A4rber <afaerber@suse.de
> <mailto:afaerber@suse.de>> wrote:
>
>
>=C2=A0 =C2=A0 =C2=A0For the second time within days you're posting = a patch for something
>=C2=A0 =C2=A0 =C2=A0that's been on the list already... The commit m= essage above is entirely
>
>
> Sorry which patch are you refering to?

This one vs. my http://patchwork.ozlabs.org/patch/33= 6367/

And my "[PATCH for-2.3? 0/7] tests: Fix TCG make test" series vs.=
your http://patchwork.ozlabs.org/patch/487719/

See my previous reply.

> Is it wrong to repost a old patch and adding, while adding signoff and=
> modifications?
> (what I just did in this series for David patches)

"contrib: add ivshmem client and server" looks (formally) = okay except
for the final [...], which should go before your Signed-off-by.
=C2=A0
Ok, thanks I'll check that.
=C2=A0
That's not what you've done here though, as I complained. You did n= ot
ask me about the state of my patch either before you posted this.
=

I don't see what that changes. You can= give the status of your patch now.
=C2=A0
=C2=A0<= span class=3D"">
> Tbh, your patch was just launching one instance of qemu with ivshmem. = If you
> look at the one I proposed, you'll notice that it is completely > different: I don't think your
> signoff or copyright should be added here.

Well, I disagree. Extending a test case does not give you the right = to
replace SUSE with Red Hat. Makes it look like an NIH problem.

It's really a different patch, sorry.
= =C2=A0
Also, see the discussion on my RFC: CONFIG_LINUX is wrong here. It would need to depend on KVM/eventfd, and for that there is no easy config
option available here, which stopped my patch at the time.

Right, I don't have good a= nswer for that. I'd need more help.

cheers

--
Marc-Andr=C3=A9 Lureau
--089e0115e7f830898f05196ddf0d--