From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F957C5517A for ; Fri, 30 Oct 2020 07:35:05 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 95E74221E2 for ; Fri, 30 Oct 2020 07:35:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ujrjISZg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 95E74221E2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:39704 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kYOwB-0003i4-Ie for qemu-devel@archiver.kernel.org; Fri, 30 Oct 2020 03:35:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36740) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kYOvZ-0003DE-Hp; Fri, 30 Oct 2020 03:34:25 -0400 Received: from mail-ed1-x543.google.com ([2a00:1450:4864:20::543]:39804) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kYOvX-0005Ps-Vz; Fri, 30 Oct 2020 03:34:25 -0400 Received: by mail-ed1-x543.google.com with SMTP id g25so4776797edm.6; Fri, 30 Oct 2020 00:34:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=QecOoWQ/HZb8eLncR1EKgGqUdTzbd3QYBazcsejlCn8=; b=ujrjISZg77YgswczqnGmqLCmD8a6h4MPRyt1NHmMmnkpJXhbeT0O+rgJX3GZi8Si+G rDQQy2PQOnNsF3XnHMVYDOXCJuPB6/0XoU81UkR6yMofcbFZcrJX5FvkALRY0hrLJkDh 248wTeLxRhp6GMHvTgkum4wjs1iTw4rKjQ8zRRIsL07x7XxJF5bZomRWcCdRhSyzh4Eh OUGvXipVheIUlmdsYhB8w29X+83G04YAkrQuHd7PpDPMbls4tSr6AF4Eb8Uvebwf1Rtu xcFq8d7jGjV/OA7eeY0MnLVz/t3jEs42qWSICjUZYIAK8btREG2Qj3lmlqizcKYz4yDb fdJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QecOoWQ/HZb8eLncR1EKgGqUdTzbd3QYBazcsejlCn8=; b=Py9C4mw5ugJTWMuyMJJtb/pKoWjnQX1l5F1tRFMD/jFUgVu5mg1XeqFbZXwbF2Okyh nB9jHwFL5YO09CJ2hQA89/bbItF5fZTNfq1AW5PmVHtPdx2g+Iar6lPN8W/D73SzDmFn 6dr3evk2nDaR03rDqqiDcdpIfSalGbdJmlegWUvYrzWX8B9jXGWh9fK/pxFQAkZn7W72 wvqmPEaLhx6NqTIYfx8EyOu+fUtqpTzhaDFUmGwKrFwT+mLsVXdd9o3gZOcvftZl+9vu EB4riSdzTlXCvEhd8JhRr/1YanFOUlhxntaOcFp0KAVGgOZe+9jDMfRJHZDnNmP64Ez3 QjDg== X-Gm-Message-State: AOAM533XWGlPSH3aLTd+FnXwprPZhKsIrCaeOBpiJBY51HymCOE/MSsP isYjwKLfFzufZaimCHx/PXWdUzwyNxVUwvwkyAA= X-Google-Smtp-Source: ABdhPJwHdlUXIcvql7BaxkEQ5qq2IjRF1QtV14hIqZo+aMFSkt+speVDDuk/H/QhE4pezbuAlNycJUmN/TXFmcdeYIA= X-Received: by 2002:a05:6402:6ca:: with SMTP id n10mr927720edy.314.1604043261375; Fri, 30 Oct 2020 00:34:21 -0700 (PDT) MIME-Version: 1.0 References: <20201029220246.472693-1-ehabkost@redhat.com> <20201029220246.472693-10-ehabkost@redhat.com> In-Reply-To: From: =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= Date: Fri, 30 Oct 2020 11:34:09 +0400 Message-ID: Subject: Re: [PATCH 09/36] qdev: Make qdev_get_prop_ptr() get Object* arg To: Eduardo Habkost Content-Type: multipart/alternative; boundary="000000000000cc7dc705b2de6c6f" Received-SPF: pass client-ip=2a00:1450:4864:20::543; envelope-from=marcandre.lureau@gmail.com; helo=mail-ed1-x543.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Matthew Rosato , Paul Durrant , QEMU , Stefano Stabellini , "open list:Block layer core" , Stefan Berger , David Hildenbrand , Markus Armbruster , Halil Pasic , Christian Borntraeger , Anthony Perard , xen-devel@lists.xenproject.org, =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= , Thomas Huth , Qemu-s390x list , Igor Mammedov , John Snow , Richard Henderson , Kevin Wolf , "Daniel P. Berrange" , Cornelia Huck , Alex Williamson , Max Reitz , Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --000000000000cc7dc705b2de6c6f Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Oct 30, 2020 at 11:29 AM Marc-Andr=C3=A9 Lureau < marcandre.lureau@gmail.com> wrote: > > > On Fri, Oct 30, 2020 at 2:07 AM Eduardo Habkost > wrote: > >> Make the code more generic and not specific to TYPE_DEVICE. >> >> Signed-off-by: Eduardo Habkost >> > > Nice cleanup!, but fails to build atm > > ../hw/block/xen-block.c:403:9: error: =E2=80=98dev=E2=80=99 undeclared (f= irst use in this > function); did you mean =E2=80=98vdev=E2=80=99? > 403 | if (dev->realized) { > > That seems to be the only issue though, so with that fixed: Reviewed-by: Marc-Andr=C3=A9 Lureau --=20 Marc-Andr=C3=A9 Lureau --000000000000cc7dc705b2de6c6f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Fri, Oct 30, 2020 at 11:29 AM Marc= -Andr=C3=A9 Lureau <marcan= dre.lureau@gmail.com> wrote:


On Fri, Oct 30, 2= 020 at 2:07 AM Eduardo Habkost <ehabkost@redhat.com> wrote:
Make the code more generic and not spec= ific to TYPE_DEVICE.

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>

Nice cleanup!, but fails to build atm

../hw/= block/xen-block.c:403:9: error: =E2=80=98dev=E2=80=99 undeclared (first use= in this function); did you mean =E2=80=98vdev=E2=80=99?
=C2=A0 403 | = =C2=A0 =C2=A0 if (dev->realized) {


That see= ms to be the only issue though, so with that fixed:
Reviewed-by: Marc-Andr=C3=A9 Lureau <marcandre.lureau@redhat.com>

--
M= arc-Andr=C3=A9 Lureau
--000000000000cc7dc705b2de6c6f-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E069DC5517A for ; Fri, 30 Oct 2020 07:34:33 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4EA0F221E2 for ; Fri, 30 Oct 2020 07:34:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ujrjISZg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4EA0F221E2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.15428.38430 (Exim 4.92) (envelope-from ) id 1kYOvY-0001Gm-SC; Fri, 30 Oct 2020 07:34:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 15428.38430; Fri, 30 Oct 2020 07:34:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kYOvY-0001Gf-OL; Fri, 30 Oct 2020 07:34:24 +0000 Received: by outflank-mailman (input) for mailman id 15428; Fri, 30 Oct 2020 07:34:23 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kYOvX-0001Ga-0W for xen-devel@lists.xenproject.org; Fri, 30 Oct 2020 07:34:23 +0000 Received: from mail-ed1-x543.google.com (unknown [2a00:1450:4864:20::543]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 879efc71-4952-4112-8859-2501a4f17b6d; Fri, 30 Oct 2020 07:34:22 +0000 (UTC) Received: by mail-ed1-x543.google.com with SMTP id k9so5614658edo.5 for ; Fri, 30 Oct 2020 00:34:22 -0700 (PDT) Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kYOvX-0001Ga-0W for xen-devel@lists.xenproject.org; Fri, 30 Oct 2020 07:34:23 +0000 X-Inumbo-ID: 879efc71-4952-4112-8859-2501a4f17b6d Received: from mail-ed1-x543.google.com (unknown [2a00:1450:4864:20::543]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 879efc71-4952-4112-8859-2501a4f17b6d; Fri, 30 Oct 2020 07:34:22 +0000 (UTC) Received: by mail-ed1-x543.google.com with SMTP id k9so5614658edo.5 for ; Fri, 30 Oct 2020 00:34:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=QecOoWQ/HZb8eLncR1EKgGqUdTzbd3QYBazcsejlCn8=; b=ujrjISZg77YgswczqnGmqLCmD8a6h4MPRyt1NHmMmnkpJXhbeT0O+rgJX3GZi8Si+G rDQQy2PQOnNsF3XnHMVYDOXCJuPB6/0XoU81UkR6yMofcbFZcrJX5FvkALRY0hrLJkDh 248wTeLxRhp6GMHvTgkum4wjs1iTw4rKjQ8zRRIsL07x7XxJF5bZomRWcCdRhSyzh4Eh OUGvXipVheIUlmdsYhB8w29X+83G04YAkrQuHd7PpDPMbls4tSr6AF4Eb8Uvebwf1Rtu xcFq8d7jGjV/OA7eeY0MnLVz/t3jEs42qWSICjUZYIAK8btREG2Qj3lmlqizcKYz4yDb fdJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QecOoWQ/HZb8eLncR1EKgGqUdTzbd3QYBazcsejlCn8=; b=mFMrKMXrAu1b8vARL7vveGhLeH+Sw+YAtFUoAnijs7lBahYv4Rs42f0QkCNLxs5l0l T+rNA10G/GMv5Q/XZ0zcCvYpQ8ithW1KD8qP7u94UfjQU4E4MNABb/um1Dbxb8GccwaP 657V8u/DgYbGCmfhvrk7hkkhM9aGKiR8UHSDqJChLYYgKStKBpY2s+noWjbzwi31sKJ8 gJ8edkECiD+sS7YwnNUAszOGsSmkyN4fKGTs/TIqitAmXXUCcEDCc9/kx33qfgFLsHjq j3/GkSIJhTNgewCSyK47x+jaht72uzJyA9ETGuxkWqt8XOQeOvvnbyDBCmdSyur8FRpJ UCbQ== X-Gm-Message-State: AOAM531nJ5WMzfMxe69vgNQqH4hFurD9hYfPI0svHyQg3SM/ue0JcIrw wM20S+7sILHQ2hzhaM6SkzWS+sENb96rbzl9rSA= X-Google-Smtp-Source: ABdhPJwHdlUXIcvql7BaxkEQ5qq2IjRF1QtV14hIqZo+aMFSkt+speVDDuk/H/QhE4pezbuAlNycJUmN/TXFmcdeYIA= X-Received: by 2002:a05:6402:6ca:: with SMTP id n10mr927720edy.314.1604043261375; Fri, 30 Oct 2020 00:34:21 -0700 (PDT) MIME-Version: 1.0 References: <20201029220246.472693-1-ehabkost@redhat.com> <20201029220246.472693-10-ehabkost@redhat.com> In-Reply-To: From: =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= Date: Fri, 30 Oct 2020 11:34:09 +0400 Message-ID: Subject: Re: [PATCH 09/36] qdev: Make qdev_get_prop_ptr() get Object* arg To: Eduardo Habkost Cc: QEMU , Matthew Rosato , Paul Durrant , Stefano Stabellini , "open list:Block layer core" , Stefan Berger , David Hildenbrand , Markus Armbruster , Halil Pasic , Christian Borntraeger , Anthony Perard , xen-devel@lists.xenproject.org, =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= , Thomas Huth , Alex Williamson , Paolo Bonzini , John Snow , Richard Henderson , Kevin Wolf , "Daniel P. Berrange" , Cornelia Huck , Qemu-s390x list , Max Reitz , Igor Mammedov Content-Type: multipart/alternative; boundary="000000000000cc7dc705b2de6c6f" --000000000000cc7dc705b2de6c6f Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Oct 30, 2020 at 11:29 AM Marc-Andr=C3=A9 Lureau < marcandre.lureau@gmail.com> wrote: > > > On Fri, Oct 30, 2020 at 2:07 AM Eduardo Habkost > wrote: > >> Make the code more generic and not specific to TYPE_DEVICE. >> >> Signed-off-by: Eduardo Habkost >> > > Nice cleanup!, but fails to build atm > > ../hw/block/xen-block.c:403:9: error: =E2=80=98dev=E2=80=99 undeclared (f= irst use in this > function); did you mean =E2=80=98vdev=E2=80=99? > 403 | if (dev->realized) { > > That seems to be the only issue though, so with that fixed: Reviewed-by: Marc-Andr=C3=A9 Lureau --=20 Marc-Andr=C3=A9 Lureau --000000000000cc7dc705b2de6c6f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Fri, Oct 30, 2020 at 11:29 AM Marc= -Andr=C3=A9 Lureau <marcan= dre.lureau@gmail.com> wrote:


On Fri, Oct 30, 2= 020 at 2:07 AM Eduardo Habkost <ehabkost@redhat.com> wrote:
Make the code more generic and not spec= ific to TYPE_DEVICE.

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>

Nice cleanup!, but fails to build atm

../hw/= block/xen-block.c:403:9: error: =E2=80=98dev=E2=80=99 undeclared (first use= in this function); did you mean =E2=80=98vdev=E2=80=99?
=C2=A0 403 | = =C2=A0 =C2=A0 if (dev->realized) {


That see= ms to be the only issue though, so with that fixed:
Reviewed-by: Marc-Andr=C3=A9 Lureau <marcandre.lureau@redhat.com>

--
M= arc-Andr=C3=A9 Lureau
--000000000000cc7dc705b2de6c6f--