From: elmarco <marcandre.lureau@gmail.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [Bug 1658634] [PATCH] console: fix console resize
Date: Tue, 24 Jan 2017 10:37:26 -0000 [thread overview]
Message-ID: <CAJ+F1CKV8R7bpOjVHjHt=N2QqGdV-O3-Tb8DGs=ZWfKf4WYPDA@mail.gmail.com> (raw)
In-Reply-To: 1485253217-7405-1-git-send-email-kraxel@redhat.com
Hi
On Tue, Jan 24, 2017 at 2:31 PM Gerd Hoffmann <1658634@bugs.launchpad.net>
wrote:
> Only skip surface reallocation in case the old surface was created using
> qemu_alloc_display (via qemu_create_displaysurface) too, otherwise we
> might end up with a DisplaySurface with the wrong backing storage.
>
> Cc: 1658634@bugs.launchpad.net
> Cc: Marc-André Lureau <marcandre.lureau@redhat.com>
> Fixes: cd958edb1fae85d0c7d1e1acbff82d22724e8d64
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
> ui/console.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ui/console.c b/ui/console.c
> index b9575f2..67c65b7 100644
> --- a/ui/console.c
> +++ b/ui/console.c
> @@ -2121,7 +2121,7 @@ void qemu_console_resize(QemuConsole *s, int width,
> int height)
>
> assert(s->console_type == GRAPHIC_CONSOLE);
>
> - if (s->surface &&
> + if (s->surface && (surface->flags & QEMU_ALLOCATED_FLAG) &&
> pixman_image_get_width(s->surface->image) == width &&
> pixman_image_get_height(s->surface->image) == height) {
> return;
>
You are missing the 's->' !
with that,
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
--
> 1.8.3.1
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1658634
>
> Title:
> Can't get correct display with latest QEMU and OVMF BIOS
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/qemu/+bug/1658634/+subscriptions
>
--
Marc-André Lureau
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1658634
Title:
Can't get correct display with latest QEMU and OVMF BIOS
Status in QEMU:
Confirmed
Bug description:
I tried to install a Ubuntu 16.04.1 Desktop 64bits with latest QEMU and OVMF UEFI BIOS, however I can't get correct display output with default vga configuration (-vga std). However, qemu works with a couple of different configurations:
1. "-vga cirrus" + "-bios OVMF.fd": works
2. "-vga std" + non-UEFI bios: works
The same error with QEMU 2.8.0 release. Everything works well on
2.7.0/1.
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1658634/+subscriptions
next prev parent reply other threads:[~2017-01-24 10:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-23 9:57 [Qemu-devel] [Bug 1658634] [NEW] Can't get correct display with latest QEMU and OVMF BIOS Kai Cong
2017-01-23 12:50 ` [Qemu-devel] [Bug 1658634] " Laszlo Ersek (Red Hat)
2017-01-24 4:04 ` Kai Cong
2017-01-24 9:06 ` Laszlo Ersek (Red Hat)
2017-01-24 9:09 ` Laszlo Ersek (Red Hat)
2017-01-24 9:12 ` Laszlo Ersek (Red Hat)
2017-01-24 10:20 ` [Qemu-devel] [PATCH] console: fix console resize Gerd Hoffmann
2017-01-24 10:37 ` elmarco [this message]
2017-01-24 11:10 ` [Qemu-devel] [Bug 1658634] " Gerd Hoffmann
2017-01-24 11:20 ` Laszlo Ersek (Red Hat)
2017-01-24 11:13 ` [Qemu-devel] " no-reply
2017-01-24 22:59 ` [Qemu-devel] [Bug 1658634] Re: Can't get correct display with latest QEMU and OVMF BIOS Kai Cong
2020-08-12 11:58 ` Laszlo Ersek (Red Hat)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJ+F1CKV8R7bpOjVHjHt=N2QqGdV-O3-Tb8DGs=ZWfKf4WYPDA@mail.gmail.com' \
--to=marcandre.lureau@gmail.com \
--cc=1658634@bugs.launchpad.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.