From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED7E7C4741F for ; Fri, 30 Oct 2020 08:08:11 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 44C4422228 for ; Fri, 30 Oct 2020 08:08:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="H7Kvgh4A" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 44C4422228 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:55012 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kYPSD-0006Jb-FD for qemu-devel@archiver.kernel.org; Fri, 30 Oct 2020 04:08:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43410) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kYPPo-0004ma-CQ; Fri, 30 Oct 2020 04:05:40 -0400 Received: from mail-ed1-x52a.google.com ([2a00:1450:4864:20::52a]:44052) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kYPPm-0008OA-F8; Fri, 30 Oct 2020 04:05:39 -0400 Received: by mail-ed1-x52a.google.com with SMTP id w1so4533947edv.11; Fri, 30 Oct 2020 01:05:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+W8Syh9vDrLxoDxx3JbwPAyYgekK9oE44RncrvpEX1E=; b=H7Kvgh4A71Iou9ViSAqjmbvaEh2Xohe1FbjT8oYVIfSr+/2jhwib63AROFHMJVi36w H1e7hfNXNmvLqKP0FLoU0nXpKcbP58eKa6f+H+q/VHJi1SgMqyEbTEQXu9db9zlx49Xw 3QYWg4zRtHnp0JXW6512Byo71YUBZMxZQb7SpdZZtoX2QhC0F/fx4jvGO6JZtbn/tdb8 UOa2y5jmBV9zi6nmpMAT/8h1/DRWFtAcTcArGS1zob97KEbwC7uoc4j2q0uhTwADbT3w Kd2fVAfoS/KtDBRJvhHBvTjspS5Kd63/0RMsb+dCCtkRlD3e98V4CSm5wpr5YJKoNbAh u/EQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+W8Syh9vDrLxoDxx3JbwPAyYgekK9oE44RncrvpEX1E=; b=YE6a6NlVujpHpwFwljus024FOkFSCYSjXp8NWVZ56DzSFRU8CI8JBZbcOu7Sh5YmL3 fJ9rdKk7Qm/WxG4hNh6j8x934Jcb+5qvfnMd5r1UI6ul+TXe/RBrxO3MFAUDrYlt6Wq9 I2c9b+Qz1A+9jFSLHyaCNb1zHk1LSgzJ+8ziCU0uhIdMKRPBp79YOD9FS2QavRtONExV eaGGBCBkablRuIDNMKXqGpro76SMjsdtagAShDtRmqpCSCaBSz/V/GL/1r8D06QeK3lh AV1M9j/g4+FIh+mnddzqYqu7QNWsCYXh3w+KdpMWZ8UB//eb7kD9jNUVJbiaoGyWGgkb 2bqw== X-Gm-Message-State: AOAM5314nqzuDVxrgG3wr3V62nn0TfV6j4dhka2bfpgniWXoEgkey82M RKtB3vZFm9J/KI0w0w2FGFpSR4z8YaJ4FuCFKZ0= X-Google-Smtp-Source: ABdhPJwAzHJL/B15MxhX4Scz95CdufOBBB/pgX/hI7IUh5HrGvbAVvyFTs9OP8Zyv5YfMRK7pRXf/vq+wy4ae/8OsKY= X-Received: by 2002:aa7:dd42:: with SMTP id o2mr998428edw.53.1604045134553; Fri, 30 Oct 2020 01:05:34 -0700 (PDT) MIME-Version: 1.0 References: <20201029220246.472693-1-ehabkost@redhat.com> <20201029220246.472693-15-ehabkost@redhat.com> In-Reply-To: <20201029220246.472693-15-ehabkost@redhat.com> From: =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= Date: Fri, 30 Oct 2020 12:05:23 +0400 Message-ID: Subject: Re: [PATCH 14/36] qdev: Move dev->realized check to qdev_property_set() To: Eduardo Habkost Content-Type: multipart/alternative; boundary="00000000000072e65e05b2dedc08" Received-SPF: pass client-ip=2a00:1450:4864:20::52a; envelope-from=marcandre.lureau@gmail.com; helo=mail-ed1-x52a.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Matthew Rosato , Paul Durrant , Mark Cave-Ayland , QEMU , Stefano Stabellini , "open list:Block layer core" , Stefan Berger , David Hildenbrand , Markus Armbruster , Halil Pasic , Christian Borntraeger , Anthony Perard , xen-devel@lists.xenproject.org, =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= , Artyom Tarasenko , Thomas Huth , Alex Williamson , Igor Mammedov , John Snow , Richard Henderson , Kevin Wolf , "Daniel P. Berrange" , Cornelia Huck , Qemu-s390x list , Max Reitz , Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --00000000000072e65e05b2dedc08 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Oct 30, 2020 at 2:10 AM Eduardo Habkost wrote= : > Every single qdev property setter function manually checks > dev->realized. We can just check dev->realized inside > qdev_property_set() instead. > > The check is being added as a separate function > (qdev_prop_allow_set()) because it will become a callback later. > > Signed-off-by: Eduardo Habkost > nice Reviewed-by: Marc-Andr=C3=A9 Lureau --=20 Marc-Andr=C3=A9 Lureau --00000000000072e65e05b2dedc08 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Fri, Oct 30, 2020 at 2:10 AM Eduar= do Habkost <ehabkost@redhat.com> wrote:
Ev= ery single qdev property setter function manually checks
dev->realized.=C2=A0 We can just check dev->realized inside
qdev_property_set() instead.

The check is being added as a separate function
(qdev_prop_allow_set()) because it will become a callback later.

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>

nice
Reviewed-by: Marc-Andr=C3=A9 Lureau <marcandre.lureau@redhat.com>=C2= =A0

--
M= arc-Andr=C3=A9 Lureau
--00000000000072e65e05b2dedc08-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7E69C55179 for ; Fri, 30 Oct 2020 08:05:56 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3EC82206DD for ; Fri, 30 Oct 2020 08:05:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="H7Kvgh4A" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3EC82206DD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.15456.38466 (Exim 4.92) (envelope-from ) id 1kYPPm-0004jP-Nt; Fri, 30 Oct 2020 08:05:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 15456.38466; Fri, 30 Oct 2020 08:05:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kYPPm-0004jI-Jn; Fri, 30 Oct 2020 08:05:38 +0000 Received: by outflank-mailman (input) for mailman id 15456; Fri, 30 Oct 2020 08:05:36 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kYPPk-0004jD-H8 for xen-devel@lists.xenproject.org; Fri, 30 Oct 2020 08:05:36 +0000 Received: from mail-ed1-x52e.google.com (unknown [2a00:1450:4864:20::52e]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 0e054684-22f0-4b32-b28d-76acc7bf1673; Fri, 30 Oct 2020 08:05:35 +0000 (UTC) Received: by mail-ed1-x52e.google.com with SMTP id dg9so5617000edb.12 for ; Fri, 30 Oct 2020 01:05:35 -0700 (PDT) Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kYPPk-0004jD-H8 for xen-devel@lists.xenproject.org; Fri, 30 Oct 2020 08:05:36 +0000 X-Inumbo-ID: 0e054684-22f0-4b32-b28d-76acc7bf1673 Received: from mail-ed1-x52e.google.com (unknown [2a00:1450:4864:20::52e]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 0e054684-22f0-4b32-b28d-76acc7bf1673; Fri, 30 Oct 2020 08:05:35 +0000 (UTC) Received: by mail-ed1-x52e.google.com with SMTP id dg9so5617000edb.12 for ; Fri, 30 Oct 2020 01:05:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+W8Syh9vDrLxoDxx3JbwPAyYgekK9oE44RncrvpEX1E=; b=H7Kvgh4A71Iou9ViSAqjmbvaEh2Xohe1FbjT8oYVIfSr+/2jhwib63AROFHMJVi36w H1e7hfNXNmvLqKP0FLoU0nXpKcbP58eKa6f+H+q/VHJi1SgMqyEbTEQXu9db9zlx49Xw 3QYWg4zRtHnp0JXW6512Byo71YUBZMxZQb7SpdZZtoX2QhC0F/fx4jvGO6JZtbn/tdb8 UOa2y5jmBV9zi6nmpMAT/8h1/DRWFtAcTcArGS1zob97KEbwC7uoc4j2q0uhTwADbT3w Kd2fVAfoS/KtDBRJvhHBvTjspS5Kd63/0RMsb+dCCtkRlD3e98V4CSm5wpr5YJKoNbAh u/EQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+W8Syh9vDrLxoDxx3JbwPAyYgekK9oE44RncrvpEX1E=; b=Ull6y97MGKr2T/k1WdUDdnmVae0lB6z7NO2rdjh1Aa5yoR/ArJMHUiCYFcg7DxuN2F 7AfZulfBhi3OTtzMSEhSvXkah0H6OAOE6U1H79s3odM+EYtQZ5YOj0S6X1v3kPee0Wmm cu2Zq3z7A54CX0q83BbVbdquKJ+TYu1vQK8ztwin/HHLqNu3Wg7yuukBB6paLXaCUvn4 x3mlWp1jt2PJEC2h9FhUo2KkA+2LQc0sjJ107CvZFNA1WGbDbW0Jjmf3hQ0jUvU3UZFC Q2M6HjbU8nBDINwJTVmVpNKbC1yoG8CqkC+dgBmdcBfEpl8C0Amw7MV70+0JoNJsvPvf AeSQ== X-Gm-Message-State: AOAM533m6NGCURsbxUvSC7n9KGVjGW/lQg3nvlVw8mNK4OyLjfCx1UTR fiy0nJcP2HP3ycN8upTLWo15Y7XYS5b+TZv1nvc= X-Google-Smtp-Source: ABdhPJwAzHJL/B15MxhX4Scz95CdufOBBB/pgX/hI7IUh5HrGvbAVvyFTs9OP8Zyv5YfMRK7pRXf/vq+wy4ae/8OsKY= X-Received: by 2002:aa7:dd42:: with SMTP id o2mr998428edw.53.1604045134553; Fri, 30 Oct 2020 01:05:34 -0700 (PDT) MIME-Version: 1.0 References: <20201029220246.472693-1-ehabkost@redhat.com> <20201029220246.472693-15-ehabkost@redhat.com> In-Reply-To: <20201029220246.472693-15-ehabkost@redhat.com> From: =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= Date: Fri, 30 Oct 2020 12:05:23 +0400 Message-ID: Subject: Re: [PATCH 14/36] qdev: Move dev->realized check to qdev_property_set() To: Eduardo Habkost Cc: QEMU , Matthew Rosato , Paul Durrant , Mark Cave-Ayland , Stefano Stabellini , "open list:Block layer core" , Stefan Berger , David Hildenbrand , Markus Armbruster , Halil Pasic , Christian Borntraeger , Anthony Perard , xen-devel@lists.xenproject.org, =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= , Artyom Tarasenko , Thomas Huth , Alex Williamson , Paolo Bonzini , John Snow , Richard Henderson , Kevin Wolf , "Daniel P. Berrange" , Cornelia Huck , Qemu-s390x list , Max Reitz , Igor Mammedov Content-Type: multipart/alternative; boundary="00000000000072e65e05b2dedc08" --00000000000072e65e05b2dedc08 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Oct 30, 2020 at 2:10 AM Eduardo Habkost wrote= : > Every single qdev property setter function manually checks > dev->realized. We can just check dev->realized inside > qdev_property_set() instead. > > The check is being added as a separate function > (qdev_prop_allow_set()) because it will become a callback later. > > Signed-off-by: Eduardo Habkost > nice Reviewed-by: Marc-Andr=C3=A9 Lureau --=20 Marc-Andr=C3=A9 Lureau --00000000000072e65e05b2dedc08 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable