From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45920) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fVeDQ-0001eF-70 for qemu-devel@nongnu.org; Wed, 20 Jun 2018 10:36:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fVeDP-0008Pq-Av for qemu-devel@nongnu.org; Wed, 20 Jun 2018 10:36:08 -0400 Received: from mail-wm0-x242.google.com ([2a00:1450:400c:c09::242]:53508) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fVeDP-0008Pd-3Z for qemu-devel@nongnu.org; Wed, 20 Jun 2018 10:36:07 -0400 Received: by mail-wm0-x242.google.com with SMTP id x6-v6so120945wmc.3 for ; Wed, 20 Jun 2018 07:36:06 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <20180618161729.334-1-marcandre.lureau@redhat.com> <20180618161729.334-3-marcandre.lureau@redhat.com> From: =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= Date: Wed, 20 Jun 2018 16:36:05 +0200 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v3 02/26] chardev: remove qemu_chr_fe_write_all() counter List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: QEMU Developers , Gerd Hoffmann On Wed, Jun 20, 2018 at 4:03 PM, Peter Maydell w= rote: > On 18 June 2018 at 17:17, Marc-Andr=C3=A9 Lureau wrote: >> There is no obvious reason to have a loop counter. This limits from >> reading several megabytes large buffers in one go, since socket >> read/write usually have a limit. >> >> Signed-off-by: Marc-Andr=C3=A9 Lureau >> --- >> chardev/char-fe.c | 6 +----- >> 1 file changed, 1 insertion(+), 5 deletions(-) > >> diff --git a/chardev/char-fe.c b/chardev/char-fe.c >> index b1f228e8b5..f158f158f8 100644 >> --- a/chardev/char-fe.c >> +++ b/chardev/char-fe.c >> @@ -56,7 +56,7 @@ int qemu_chr_fe_write_all(CharBackend *be, const uint8= _t *buf, int len) >> int qemu_chr_fe_read_all(CharBackend *be, uint8_t *buf, int len) >> { >> Chardev *s =3D be->chr; >> - int offset =3D 0, counter =3D 10; >> + int offset =3D 0; >> int res; > > Subject says "qemu_char_fe_write_all()" but patch is changing > qemu_chr_fe_read_all()... > indeed, fixed. thanks --=20 Marc-Andr=C3=A9 Lureau