Re: [Qemu-devel] [PATCH 05/11] paaudio: do not move stream when sink/source name is specified - Marc-André Lureau

From: "Marc-André Lureau" <marcandre.lureau@gmail.com>
To: "Kővágó, Zoltán" <dirty.ice.hu@gmail.com>
Cc: QEMU <qemu-devel@nongnu.org>, Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 05/11] paaudio: do not move stream when sink/source name is specified
Date: Wed, 10 Jul 2019 23:58:38 +0400	[thread overview]
Message-ID: <CAJ+F1CKefJn4M7Kmr+Qyv0J4hiuMVnTyr_Vvc5HT1+q70+9EZQ@mail.gmail.com> (raw)
In-Reply-To: <d4f8933c22ec6cce1ca0f65d01c42ef974aee9c9.1562695780.git.DirtY.iCE.hu@gmail.com>

On Tue, Jul 9, 2019 at 10:53 PM Kővágó, Zoltán <dirty.ice.hu@gmail.com> wrote:
>
> Unless we disable stream moving, pulseaudio can easily move the stream
> on connect, effectively ignoring the source/sink specified by the user.
>
> Signed-off-by: Kővágó, Zoltán <DirtY.iCE.hu@gmail.com>

Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>


> ---
>  audio/paaudio.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/audio/paaudio.c b/audio/paaudio.c
> index cc3a34c2ea..24d98b344a 100644
> --- a/audio/paaudio.c
> +++ b/audio/paaudio.c
> @@ -517,6 +517,11 @@ static pa_stream *qpa_simple_new (
>  #endif
>          | PA_STREAM_AUTO_TIMING_UPDATE;
>
> +    if (dev) {
> +        /* don't move the stream if the user specified a sink/source */
> +        flags |= PA_STREAM_DONT_MOVE;
> +    }
> +
>      if (dir == PA_STREAM_PLAYBACK) {
>          r = pa_stream_connect_playback(stream, dev, attr, flags, NULL, NULL);
>      } else {
> --
> 2.22.0
>
>


--
Marc-André Lureau