From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50500) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dDXN0-0004od-PK for qemu-devel@nongnu.org; Wed, 24 May 2017 10:34:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dDXMz-0006ZR-Im for qemu-devel@nongnu.org; Wed, 24 May 2017 10:34:38 -0400 Received: from mail-lf0-x244.google.com ([2a00:1450:4010:c07::244]:36487) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dDXMz-0006Yv-7U for qemu-devel@nongnu.org; Wed, 24 May 2017 10:34:37 -0400 Received: by mail-lf0-x244.google.com with SMTP id h4so11146948lfj.3 for ; Wed, 24 May 2017 07:34:37 -0700 (PDT) MIME-Version: 1.0 References: <1494921494-33717-1-git-send-email-amarnath.valluri@intel.com> <1494921494-33717-2-git-send-email-amarnath.valluri@intel.com> In-Reply-To: <1494921494-33717-2-git-send-email-amarnath.valluri@intel.com> From: =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= Date: Wed, 24 May 2017 14:34:24 +0000 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v4 1/8] tpm-backend: Remove unneeded member variable from backend class List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amarnath Valluri , qemu-devel@nongnu.org Hi On Tue, May 16, 2017 at 12:00 PM Amarnath Valluri < amarnath.valluri@intel.com> wrote: > TPMDriverOps inside TPMBackend is not required, as it is supposed to be a > class > member. The only possible reason for keeping in TPMBackend was, to get th= e > backend type in tpm.c where dedicated backend api, tpm_backend_get_type() > is > present. > > Signed-off-by: Amarnath Valluri > Please add & keep my r-b tags from previous iterations in commit message if they are no or only minor changes. > --- > hw/tpm/tpm_passthrough.c | 4 ---- > include/sysemu/tpm_backend.h | 1 - > tpm.c | 2 +- > 3 files changed, 1 insertion(+), 6 deletions(-) > > diff --git a/hw/tpm/tpm_passthrough.c b/hw/tpm/tpm_passthrough.c > index 9234eb3..a0baf5f 100644 > --- a/hw/tpm/tpm_passthrough.c > +++ b/hw/tpm/tpm_passthrough.c > @@ -46,8 +46,6 @@ > #define TPM_PASSTHROUGH(obj) \ > OBJECT_CHECK(TPMPassthruState, (obj), TYPE_TPM_PASSTHROUGH) > > -static const TPMDriverOps tpm_passthrough_driver; > - > /* data structures */ > typedef struct TPMPassthruThreadParams { > TPMState *tpm_state; > @@ -462,8 +460,6 @@ static TPMBackend *tpm_passthrough_create(QemuOpts > *opts, const char *id) > /* let frontend set the fe_model to proper value */ > tb->fe_model =3D -1; > > - tb->ops =3D &tpm_passthrough_driver; > - > if (tpm_passthrough_handle_device_opts(opts, tb)) { > goto err_exit; > } > diff --git a/include/sysemu/tpm_backend.h b/include/sysemu/tpm_backend.h > index b58f52d..e7f590d 100644 > --- a/include/sysemu/tpm_backend.h > +++ b/include/sysemu/tpm_backend.h > @@ -50,7 +50,6 @@ struct TPMBackend { > enum TpmModel fe_model; > char *path; > char *cancel_path; > - const TPMDriverOps *ops; > > QLIST_ENTRY(TPMBackend) list; > }; > diff --git a/tpm.c b/tpm.c > index 9a7c711..0ee021a 100644 > --- a/tpm.c > +++ b/tpm.c > @@ -258,7 +258,7 @@ static TPMInfo *qmp_query_tpm_inst(TPMBackend *drv) > res->model =3D drv->fe_model; > res->options =3D g_new0(TpmTypeOptions, 1); > > - switch (drv->ops->type) { > + switch (tpm_backend_get_type(drv)) { > case TPM_TYPE_PASSTHROUGH: > res->options->type =3D TPM_TYPE_OPTIONS_KIND_PASSTHROUGH; > tpo =3D g_new0(TPMPassthroughOptions, 1); > -- > 2.7.4 > > > -- Marc-Andr=C3=A9 Lureau