Hi On Wed, Aug 26, 2020 at 1:52 PM Philippe Mathieu-Daudé wrote: > Hi Peter, > > Le lun. 24 août 2020 17:20, Peter Maydell a > écrit : > >> On Sat, 22 Aug 2020 at 21:00, Philippe Mathieu-Daudé >> wrote: >> > >> > On 8/6/20 3:03 PM, Philippe Mathieu-Daudé wrote: >> > > This series improve tracing of multiple UART device in the same >> > > chipset, and allow to use the Clock API to feed each device with >> > > an (updatable) input clock. >> > > >> > > Based-on: <20200730165900.7030-1-philmd@redhat.com> >> > > "hw/char: Remove TYPE_SERIAL_IO" >> > > >> > > Philippe Mathieu-Daudé (4): >> > > hw/char/serial: Replace commented DPRINTF() by trace event >> > > hw/char/serial: Remove old DEBUG_SERIAL commented code >> > > hw/char/serial: Let SerialState have an 'id' field >> > > hw/char/serial: Use the Clock API to feed the UART reference clock >> > > >> > > include/hw/char/serial.h | 4 +++ >> > > hw/char/serial.c | 55 >> +++++++++++++++++++++++----------------- >> > > hw/char/trace-events | 5 ++-- >> > > 3 files changed, 39 insertions(+), 25 deletions(-) >> > > >> > >> > ping? Should I resend with the typo from patch 4 fixed? >> >> Which tree are you expecting the patches to go in via ? >> > > I cc'ed you because having reviewed the Clock API series you are familiar > with it. > However I expect this series to be merged by the chardev maintainers. > In particular to verify the default values (when no input clock provided). > Sorry, I am not of much help here. (other than it looks reasonable to me) -- Marc-André Lureau