From: "Marc-André Lureau" <marcandre.lureau@gmail.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: QEMU <qemu-devel@nongnu.org>
Subject: Re: [PATCH 3/4] configure: accept --enable-slirp
Date: Thu, 17 Dec 2020 14:22:59 +0400 [thread overview]
Message-ID: <CAJ+F1CLOz2jHnfhJMOHdGef2P1P=Pe4KrOwYq+x2wZwkJB1rnQ@mail.gmail.com> (raw)
In-Reply-To: <20201217085005.10644-4-pbonzini@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 785 bytes --]
On Thu, Dec 17, 2020 at 12:52 PM Paolo Bonzini <pbonzini@redhat.com> wrote:
> Meson understands -Dslirp=enabled, so there is no reason not to
> accept the configure option as well.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
> configure | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/configure b/configure
> index 18af8207d9..568818e72d 100755
> --- a/configure
> +++ b/configure
> @@ -1083,6 +1083,8 @@ for opt do
> ;;
> --disable-slirp) slirp="disabled"
> ;;
> + --enable-slirp) slirp="enabled"
> + ;;
> --enable-slirp=git) slirp="internal"
> ;;
> --enable-slirp=system) slirp="system"
> --
> 2.29.2
>
>
>
>
--
Marc-André Lureau
[-- Attachment #2: Type: text/html, Size: 1560 bytes --]
next prev parent reply other threads:[~2020-12-17 10:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-17 8:50 [PATCH 0/4] First batch of configure cleanups Paolo Bonzini
2020-12-17 8:50 ` [PATCH 1/4] configure: remove useless code to check for Xen PCI passthrough Paolo Bonzini
2020-12-17 10:20 ` Marc-André Lureau
2020-12-17 8:50 ` [PATCH 2/4] configure: remove variable bogus_os Paolo Bonzini
2020-12-17 9:04 ` Thomas Huth
2020-12-17 10:21 ` Marc-André Lureau
2020-12-17 8:50 ` [PATCH 3/4] configure: accept --enable-slirp Paolo Bonzini
2020-12-17 9:06 ` Thomas Huth
2020-12-17 10:22 ` Marc-André Lureau [this message]
2020-12-17 8:50 ` [PATCH 4/4] configure: remove CONFIG_FILEVERSION and CONFIG_PRODUCTVERSION Paolo Bonzini
2020-12-17 10:30 ` Marc-André Lureau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJ+F1CLOz2jHnfhJMOHdGef2P1P=Pe4KrOwYq+x2wZwkJB1rnQ@mail.gmail.com' \
--to=marcandre.lureau@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.