From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BADC5C433E0 for ; Thu, 14 Jan 2021 11:10:46 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3D3C4238A1 for ; Thu, 14 Jan 2021 11:10:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3D3C4238A1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:58080 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l00Wb-0004ht-AS for qemu-devel@archiver.kernel.org; Thu, 14 Jan 2021 06:10:45 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:45056) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l00U2-0002HK-V3 for qemu-devel@nongnu.org; Thu, 14 Jan 2021 06:08:07 -0500 Received: from mail-ej1-x636.google.com ([2a00:1450:4864:20::636]:46107) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l00Tz-0006V0-2c for qemu-devel@nongnu.org; Thu, 14 Jan 2021 06:08:06 -0500 Received: by mail-ej1-x636.google.com with SMTP id t16so7501472ejf.13 for ; Thu, 14 Jan 2021 03:08:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=nFV3fnoBttIPC4FHFJe7231DjI6DUzmxJwtVO04koJg=; b=N1JxENp9AzPRpJsaTgfcHbOtV/Ntlspw5iHLL0QV6jnw7kTKZ1KpUguidvkmibBLs7 dirtdGU2fkStX9cIRJt1IbxJUiESA45lCEzlLSqZEqq/jQb81xZyXuCh2Fy06yw3+Mw+ JlpFAz+fta0PrRIIEN6okn+DdqQzCcVVM+LkibMF0RpRyj4cdRg+DN/P5Uja+52QKehE VREbmjyVbcgFXR5Jr4gcgWeamyDNFdui4FcPTNUiuFhUwEkzowDpKxELG0Pox/HtSqy2 MyAmU2WrkP5r+Ky4KIYAHJvra5y3OFGCt4Kl6JTLn/FqnH0jjHBQscM1RqUZ1E/ikCIl 1qKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nFV3fnoBttIPC4FHFJe7231DjI6DUzmxJwtVO04koJg=; b=Evk25QZDRtCTiIGHM3T2wfo9tMGECs5wf+SoKYMXcrLQ0MfJpLIVf/HJlgSmEV3Gdp EJc3relVD3Hdon2vhHEtPX/UueI7mkbVzjKaHtPylVc9rhEQyK8K6SbiA2XSNN38wpf1 /Put56VqRD+M8GPJzgUtlnLX29zUj7GxPXkY/6etkIAO71tVCM8trACm8/bqZsdvCuv/ kw31wAHajXXY49QaA017YZEZGRyfOvMesAfbixV94NQURV6OH28zopUfFCoIPycV01ts jwIv2eh3Vvk0ZYqN/BelArmG7opyOVgxUuUxg4eN08BxzLHICSMTkIwXBdtH6/zLU1at 0NUA== X-Gm-Message-State: AOAM5339cabFEUGGHVFSs8dPwBB2VDct41HIUpmqQ8TrpB/lF/HO4Up3 EFIg/jWJeNIUcTSGr5sGcoGNEQL/dMUaw1fQLUA= X-Google-Smtp-Source: ABdhPJwJczRSA10lUGSe+cGFaaULp9EJmV030sCgJrQcxDiTRcs7WX+SJS4s/+j/+bRBZcO68IBXVlsePxXctjdI+vY= X-Received: by 2002:a17:906:98d4:: with SMTP id zd20mr4849571ejb.532.1610622481585; Thu, 14 Jan 2021 03:08:01 -0800 (PST) MIME-Version: 1.0 References: <20210105022055.12113-1-j@getutm.app> <20210105022055.12113-7-j@getutm.app> <1b4c4f34-8b27-3b45-7de8-19eed100f6f8@redhat.com> In-Reply-To: <1b4c4f34-8b27-3b45-7de8-19eed100f6f8@redhat.com> From: =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= Date: Thu, 14 Jan 2021 15:07:49 +0400 Message-ID: Subject: Re: [Slirp] [PATCH v6 6/7] slirp: update build flags for iOS resolv fix To: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Content-Type: multipart/alternative; boundary="000000000000e1ddf705b8da44ac" Received-SPF: pass client-ip=2a00:1450:4864:20::636; envelope-from=marcandre.lureau@gmail.com; helo=mail-ej1-x636.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: slirp@lists.freedesktop.org, QEMU , Roman Bolshakov , Joelle van Dyne , Stefan Hajnoczi , Samuel Thibault , Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --000000000000e1ddf705b8da44ac Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi On Tue, Jan 12, 2021 at 3:52 PM Philippe Mathieu-Daud=C3=A9 wrote: > Hi Joelle, > > On 1/5/21 3:20 AM, Joelle van Dyne wrote: > > A future libslirp update will use libresolv on Darwin systems, so we ad= d > the > > flags in QEMU build now. > > > > Reviewed-by: Stefan Hajnoczi > > Signed-off-by: Joelle van Dyne > > --- > > meson.build | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/meson.build b/meson.build > > index 900dbc36c8..d8951d4d6c 100644 > > --- a/meson.build > > +++ b/meson.build > > @@ -1205,6 +1205,8 @@ if have_system > > slirp_deps =3D [] > > if targetos =3D=3D 'windows' > > slirp_deps =3D cc.find_library('iphlpapi') > > + elif targetos =3D=3D 'darwin' > > + slirp_deps =3D cc.find_library('resolv') > > This is done in libSLiRP commit 9f82a47 ("Add DNS resolving for iOS"). > > Maybe this commit need to be backported in the stable branch, > or QEMU should use a newer commit. Cc'ing Samuel and Marc-Andr=C3=A9 > who maintain the project (and the SLiRP list). > Yes, I am going to send an update to git upstream. thanks --=20 Marc-Andr=C3=A9 Lureau --000000000000e1ddf705b8da44ac Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi

On Tue, Jan 12, 2021 at 3:52 PM Phi= lippe Mathieu-Daud=C3=A9 <philmd@re= dhat.com> wrote:
Hi Joelle,

On 1/5/21 3:20 AM, Joelle van Dyne wrote:
> A future libslirp update will use libresolv on Darwin systems, so we a= dd the
> flags in QEMU build now.
>
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
> Signed-off-by: Joelle van Dyne <j@getutm.app>
> ---
>=C2=A0 meson.build | 2 ++
>=C2=A0 1 file changed, 2 insertions(+)
>
> diff --git a/meson.build b/meson.build
> index 900dbc36c8..d8951d4d6c 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -1205,6 +1205,8 @@ if have_system
>=C2=A0 =C2=A0 =C2=A0 slirp_deps =3D []
>=C2=A0 =C2=A0 =C2=A0 if targetos =3D=3D 'windows'
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 slirp_deps =3D cc.find_library('iphlpap= i')
> +=C2=A0 =C2=A0 elif targetos =3D=3D 'darwin'
> +=C2=A0 =C2=A0 =C2=A0 slirp_deps =3D cc.find_library('resolv')=

This is done in libSLiRP commit 9f82a47 ("Add DNS resolving for iOS&qu= ot;).

Maybe this commit need to be backported in the stable branch,
or QEMU should use a newer commit. Cc'ing Samuel and Marc-Andr=C3=A9 who maintain the project (and the SLiRP list).

Yes, I am going to send an update to git upstream.

thanks

--
Mar= c-Andr=C3=A9 Lureau
--000000000000e1ddf705b8da44ac--