From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60016)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marcandre.lureau@gmail.com>) id 1bGPup-0002dy-2o
	for qemu-devel@nongnu.org; Fri, 24 Jun 2016 08:08:55 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <marcandre.lureau@gmail.com>) id 1bGPuo-0003lG-2T
	for qemu-devel@nongnu.org; Fri, 24 Jun 2016 08:08:54 -0400
Received: from mail-vk0-x234.google.com ([2607:f8b0:400c:c05::234]:34163)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marcandre.lureau@gmail.com>) id 1bGPun-0003lB-U8
	for qemu-devel@nongnu.org; Fri, 24 Jun 2016 08:08:53 -0400
Received: by mail-vk0-x234.google.com with SMTP id c2so116884996vkg.1
	for <qemu-devel@nongnu.org>; Fri, 24 Jun 2016 05:08:53 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <20160623194541-mutt-send-email-mst@redhat.com>
References: <1466105332-10285-1-git-send-email-marcandre.lureau@redhat.com>
	<1466105332-10285-4-git-send-email-marcandre.lureau@redhat.com>
	<20160623073840-mutt-send-email-mst@redhat.com>
	<20160623074849-mutt-send-email-mst@redhat.com>
	<934708551.1342481.1466672883154.JavaMail.zimbra@redhat.com>
	<20160623194541-mutt-send-email-mst@redhat.com>
From: =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= <marcandre.lureau@gmail.com>
Date: Fri, 24 Jun 2016 14:08:52 +0200
Message-ID: <CAJ+F1CLu9LidBh3x-wWdtoqWt5gaaiw3McJQMGCbfTbYJwYMaQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v2 3/3] socket: unlink unix socket on remove
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>, "Daniel P. Berrange" <berrange@redhat.com>
Cc: QEMU <qemu-devel@nongnu.org>, Paolo Bonzini <pbonzini@redhat.com>

On Thu, Jun 23, 2016 at 7:01 PM, Michael S. Tsirkin <mst@redhat.com> wrote:
>> > Maybe what you want is a need_unlink feature.
>> > Set it for unix sockets only, that would make some sense.
>>
>> Oh perhaps what you mean is that if the fd was passed, we should cleanup=
 the unix socket? Yes, I think we should do that then. I'll update the seri=
es.

Actually it's not possible to pass a listening fd to a socket chardev
today (the path argument doesn't understand /dev/fdset), so only path
created by qemu will be cleaned up.

>
> I'd like it better contained - that's all. So let's set a flag that says
> "must unlink" as opposed to "it's listening".

You suggest to rename QIO_CHANNEL_FEATURE_LISTEN to
QIO_CHANNEL_FEATURE_LISTEN_MUST_UNLINK ? Or to add another feature
flag? I don't think that brings anything useful here.

What would you think Daniel?

--=20
Marc-Andr=C3=A9 Lureau