From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3901C433E0 for ; Wed, 20 May 2020 17:19:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A56FC206B6 for ; Wed, 20 May 2020 17:19:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="smVMN+od" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726560AbgETRTE (ORCPT ); Wed, 20 May 2020 13:19:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54514 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726548AbgETRTD (ORCPT ); Wed, 20 May 2020 13:19:03 -0400 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 623A6C061A0E; Wed, 20 May 2020 10:19:02 -0700 (PDT) Received: by mail-wr1-x443.google.com with SMTP id e1so3969168wrt.5; Wed, 20 May 2020 10:19:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=WjoBWssVHBqyFxbEQ95THjA8DwdaA15bcQxmRjylmZg=; b=smVMN+odCBqaMwnw8ELsWxRi0g2b8Dea1GDPoSNlGKc9bqV9kiVDTqHpCLmee2h6vA 9az6vKmyX1eDQzNIhrFuWAR1UyCLsDArmdY/yFdhxYG3t7Q6KVr/6/tXHdx4S27rDljv wwWgvXYvsWTuGsSrWivIGnPH4Cd8uts5/8xBpQWzDBVN+fo66BHwu9onOVvevV80/SMk J7NU8rUTSGM+ckuNCagujX8hsbFGvGD09cbXyOAqzrZYJDppzhY/QIlhjrU1NHAykaKa pmQVTsZFVkCv8mTsRcPyTmBcTvDhiMD0iIG9eRxEMGD1J3AL5QeCQh8DDrfJ5Lu5S7kJ tTmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=WjoBWssVHBqyFxbEQ95THjA8DwdaA15bcQxmRjylmZg=; b=aIJHLJRa+qbCjh7zgOlgcKOL5U0AH5Bf0mO0Yp+9Wd2wKN31vqO/rLjMf0t/WTBBaD 4hK1/TzwsWpVm6/B7TaWI8TLdRm/Dn03YeKHB6TQk3q11NrwcnKn89dzhto/qImkSAPV K9ka1MH3ZH0Ui1FeNDE3S3abokA51YItfL0/cypiW/0KrhuTsDCKL4fzrdXAKL+F0mT/ NgXXK7rgzE+02SRBZlGc8M21DRN0nQqtPJhz9Bs282sF3RC/p9wFD5veE+LqHiahJe/e 4S/HgGO7/HzEptPvYzp4kOtlvEQTPHzXeaVgcnFEICR02wmJnWLhkV9n9XL0GXdv4t50 +Meg== X-Gm-Message-State: AOAM530dRl4EAV6QOfimF7/tVOoCEVnqH6ZKdL8MFNsSn2TcyqK72C2G w2x0LXmDpCRXi5K5sSdFdGVR8eRub9YkC0Tf2SQ= X-Google-Smtp-Source: ABdhPJyZBIZqLYSG4g785vCGsXo0DwKM/I7MoLWiEIcWCbvk0lXAiMYbJ38VU2g5O3IRznEAv7e7WWgWLGb51/knXQ4= X-Received: by 2002:a5d:5642:: with SMTP id j2mr4942061wrw.52.1589995141127; Wed, 20 May 2020 10:19:01 -0700 (PDT) MIME-Version: 1.0 References: <20200520094742.337678-1-bjorn.topel@gmail.com> <20200520094742.337678-4-bjorn.topel@gmail.com> <20200520095743.0d6dda04@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20200520095743.0d6dda04@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> From: =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= Date: Wed, 20 May 2020 19:18:49 +0200 Message-ID: Subject: Re: [PATCH bpf-next v4 03/15] xsk: move driver interface to xdp_sock_drv.h To: Jakub Kicinski Cc: Alexei Starovoitov , Daniel Borkmann , David Miller , Jesper Dangaard Brouer , John Fastabend , Netdev , bpf , "Karlsson, Magnus" , Jonathan Lemon , Jeff Kirsher , Maxim Mikityanskiy , "Fijalkowski, Maciej" , =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Wed, 20 May 2020 at 18:57, Jakub Kicinski wrote: > > On Wed, 20 May 2020 11:47:30 +0200 Bj=C3=B6rn T=C3=B6pel wrote: > > From: Magnus Karlsson > > > > Move the AF_XDP zero-copy driver interface to its own include file > > called xdp_sock_drv.h. This, hopefully, will make it more clear for > > NIC driver implementors to know what functions to use for zero-copy > > support. > > > > Signed-off-by: Magnus Karlsson > > With W=3D1: > > net/xdp/xsk_queue.c:67:26: warning: symbol 'xsk_reuseq_prepare' was not d= eclared. Should it be static? > net/xdp/xsk_queue.c:86:26: warning: symbol 'xsk_reuseq_swap' was not decl= ared. Should it be static? > net/xdp/xsk_queue.c:108:6: warning: symbol 'xsk_reuseq_free' was not decl= ared. Should it be static? > net/xdp/xsk_queue.c:67:27: warning: no previous prototype for xsk_reuseq_= prepare [-Wmissing-prototypes] > 67 | struct xdp_umem_fq_reuse *xsk_reuseq_prepare(u32 nentries) > | ^~~~~~~~~~~~~~~~~~ > net/xdp/xsk_queue.c:86:27: warning: no previous prototype for xsk_reuseq_= swap [-Wmissing-prototypes] > 86 | struct xdp_umem_fq_reuse *xsk_reuseq_swap(struct xdp_umem *umem, > | ^~~~~~~~~~~~~~~ > net/xdp/xsk_queue.c:108:6: warning: no previous prototype for xsk_reuseq_= free [-Wmissing-prototypes] > 108 | void xsk_reuseq_free(struct xdp_umem_fq_reuse *rq) > | ^~~~~~~~~~~~~~~ Yes, missing include there. After the series these functions are removed, but still good to get rid of the (bisect) noise. I'll fix this in a v5. Thanks, Jakub! Bj=C3=B6rn