From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5CF5BC433F5 for ; Wed, 19 Jan 2022 10:24:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Icoha5eHZU/KGVHjLcQcvpyvVy/4ZwweTMUkxfBhhqc=; b=GGE/Tqi3V7CUfX /OgjK+YHP9VaNy3GPc3AbDgNX1TbVCZ4I45RJdpZgS83/q+De5S5L+gIZKjKS0AqVc7fki9h1kjPZ s9+N301NQAFXIsjms2aUDL2yhAXyn3Tudi8L96JatBJ21RlyGm2Lir68t2GIbbQY/oQCms3FvvYWF Uyhn9/23lrEM2woc/BH4VEqEWeU+lE3ohQhQZj/7N6847FbswyN/q64sVm+9fneVQxE9KB4A+Uv0P nRVw59lVzUJ9T6md34+WTJ98EcMy5JR4nIV1Y4azRc8h40IN1DN9knCPoY0uVQsvoxVsnnB4+yZtY 6IIn7NgOkAxRboaAiS0A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nA88n-004u32-7r; Wed, 19 Jan 2022 10:24:33 +0000 Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nA88k-004u1u-Ig for linux-riscv@lists.infradead.org; Wed, 19 Jan 2022 10:24:31 +0000 Received: by mail-wm1-x334.google.com with SMTP id n8so4361914wmk.3 for ; Wed, 19 Jan 2022 02:24:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=23T4xOW2I0F1J8h1VBHMXa/Hl9U+ZT3rpxlsT4/aGfc=; b=YsEHE2FoxTIEDYdQkjHZoP/fMCSt7QDmBQ4JdVPHxM4mlnOCzYop6XchK4rNHKQtf+ EB550obMnV3f5ZhHcIk/AxpQ8rIFuitjP2WoGDxLwZPMERXqneeB/TZ8sQCaB/Na7dAD gBFFTaU95S2gXYoC1ejMoGbHiqPSliY7DgwtbQkFJB0qfSMMdRfOMiiSSiPIlGi9YkfW SF6KUmqLmY0Vm9eUK4+qdupPRPxxj4ZT74ftdKfK9m/t115DOzfVBBOGbky0j7JF+4xS /laydDlP6PnfNM7FjGBWQC6AyMUnubEMwTk5FqFL60694tozYxQKd8zFSgAVHk04Owxb LpWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=23T4xOW2I0F1J8h1VBHMXa/Hl9U+ZT3rpxlsT4/aGfc=; b=T2gvdjFzy86XC40HyvJaYVwn98xQDup9a9/CGioXsMsDBWm5xuixhfPl68M/CPGBQN 2xRoJiGRY+8QWiiRCvmXAlqP+b0Pb4Wu1A82h0MiaYRQXAzKCoyUsc75nKDobpPTtueV smlwinW1RMcPOhCHAqYTW0PBgdBWpELnUbJctZIAlNbglgzkHFuDUV5Jcuvm9rrZCA74 Hpl6KzNOTXbgsnoSesWiQ3F721b4ampNnx8YJDOHyZoAzHuOApn0qf2kkoBGQU6gaSqR NXdNQJK4hdKl8hh2VGqelCOHmyChi8fZIzf1w05Jco9nmSDpBqFvwzXyrpmIKKJnKSjR KzLQ== X-Gm-Message-State: AOAM532LgQhOJ6bd6t473FSStuF/Wln10TuASCQsi7NCezYZvk6MUtoR m0o1xw2aFr3W/0+jJGK7sncSgsiXV2mom3LHWKJwouMNUz0= X-Google-Smtp-Source: ABdhPJyQ5Tdq7m8t7iLiOJAS4JTEijMM4at1JFtGA1ZF2R8mUGyIx8zXbXyxAiL39Qfm4S+aXM2whQ60Ky+y/NvZSKQ= X-Received: by 2002:adf:d08b:: with SMTP id y11mr27706022wrh.384.1642587868723; Wed, 19 Jan 2022 02:24:28 -0800 (PST) MIME-Version: 1.0 References: <20220110165208.1826-1-jszhang@kernel.org> In-Reply-To: From: =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= Date: Wed, 19 Jan 2022 11:24:16 +0100 Message-ID: Subject: Re: [PATCH riscv-next] riscv: bpf: Fix eBPF's exception tables To: Jisheng Zhang , Palmer Dabbelt , palmer@rivosinc.com, Daniel Borkmann Cc: Paul Walmsley , Albert Ou , Alexei Starovoitov , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Netdev , bpf , linux-riscv , LKML , Tong Tiangen X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220119_022430_644463_F7E1E20C X-CRM114-Status: GOOD ( 17.25 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org SmlzaGVuZy9QYWxtZXIsCgpPbiBNb24sIDEwIEphbiAyMDIyIGF0IDE4OjA1LCBKaXNoZW5nIFpo YW5nIDxqc3poYW5nQGtlcm5lbC5vcmc+IHdyb3RlOgo+Cj4gT24gVHVlLCBKYW4gMTEsIDIwMjIg YXQgMTI6NTI6MDhBTSArMDgwMCwgSmlzaGVuZyBaaGFuZyB3cm90ZToKPiA+IGVCUEYncyBleGNl cHRpb24gdGFibGVzIG5lZWRzIHRvIGJlIG1vZGlmaWVkIHRvIHJlbGF0aXZlIHN5bmNocm9ub3Vz bHkuCj4gPgo+ID4gU3VnZ2VzdGVkLWJ5OiBUb25nIFRpYW5nZW4gPHRvbmd0aWFuZ2VuQGh1YXdl aS5jb20+Cj4gPiBTaWduZWQtb2ZmLWJ5OiBKaXNoZW5nIFpoYW5nIDxqc3poYW5nQGtlcm5lbC5v cmc+CgpOaWNlIGNhdGNoLCBhbmQgYXBvbG9naWVzIGZvciB0aGUgc2xvdyByZXNwb25zZS4KCkFj a2VkLWJ5OiBCasO2cm4gVMO2cGVsIDxiam9ybkBrZXJuZWwub3JnPgoKPiA+IC0tLQo+ID4gIGFy Y2gvcmlzY3YvbmV0L2JwZl9qaXRfY29tcDY0LmMgfCAyICstCj4gPiAgMSBmaWxlIGNoYW5nZWQs IDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pCj4gPgo+ID4gZGlmZiAtLWdpdCBhL2FyY2gv cmlzY3YvbmV0L2JwZl9qaXRfY29tcDY0LmMgYi9hcmNoL3Jpc2N2L25ldC9icGZfaml0X2NvbXA2 NC5jCj4gPiBpbmRleCA2OWJhYjdlMjhmOTEuLjQ0Yzk3NTM1YmMxNSAxMDA2NDQKPiA+IC0tLSBh L2FyY2gvcmlzY3YvbmV0L2JwZl9qaXRfY29tcDY0LmMKPiA+ICsrKyBiL2FyY2gvcmlzY3YvbmV0 L2JwZl9qaXRfY29tcDY0LmMKPiA+IEBAIC00OTgsNyArNDk4LDcgQEAgc3RhdGljIGludCBhZGRf ZXhjZXB0aW9uX2hhbmRsZXIoY29uc3Qgc3RydWN0IGJwZl9pbnNuICppbnNuLAo+ID4gICAgICAg b2Zmc2V0ID0gcGMgLSAobG9uZykmZXgtPmluc247Cj4gPiAgICAgICBpZiAoV0FSTl9PTl9PTkNF KG9mZnNldCA+PSAwIHx8IG9mZnNldCA8IElOVF9NSU4pKQo+ID4gICAgICAgICAgICAgICByZXR1 cm4gLUVSQU5HRTsKPiA+IC0gICAgIGV4LT5pbnNuID0gcGM7Cj4gPiArICAgICBleC0+aW5zbiA9 IG9mZnNldDsKPgo+IEhpIFBhbG1lciwKPgo+IFRvbmcgcG9pbnRlZCBvdXQgdGhpcyBpc3N1ZSBi dXQgdGhlcmUgd2FzIHNvbWV0aGluZyB3cm9uZyB3aXRoIG15IGVtYWlsCj4gZm9yd2FyZGluZyBh ZGRyZXNzLCBzbyBJIGRpZG4ndCBnZXQgaGlzIHJlcGx5LiBUb2RheSwgSSBzZWFyY2hlZCBvbgo+ IGxvcmUua2VybmVsLm9yZyBqdXN0IGZvdW5kIGhpcyByZXBseSwgc29ycnkgZm9yIGluY29udmVu aWVuY2UuCj4KCkFGQUlLLCBKaXNoZW5nJ3MgZXh0YWJsZSB3b3JrIGlzIHN0aWxsIGluIFBhbG1l cidzIGZvci1uZXh0IHRyZWUuCgpEYW5pZWwvQWxleGVpOiBUaGlzIGVCUEYgbXVzdCBmb2xsb3cg Y29tbWl0IDFmNzdlZDk0MjJjYiAoInJpc2N2Ogpzd2l0Y2ggdG8gcmVsYXRpdmUgZXh0YWJsZSBh bmQgb3RoZXIgaW1wcm92ZW1lbnRzIiksIHdoaWNoIGlzIGluClBhbG1lcidzIHRyZWUuIEl0IGNh bm5vdCBnbyB2aWEgYnBmLW5leHQuCgpQYWxtZXIsIHBsZWFzZSBwdWxsIHRoaXMgdG8geW91ciBm b3ItbmV4dCB0cmVlLgoKClRoYW5rcywKQmrDtnJuCgpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1yaXNjdiBtYWlsaW5nIGxpc3QKbGludXgtcmlz Y3ZAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2xpbnV4LXJpc2N2Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8790CC433EF for ; Wed, 19 Jan 2022 10:25:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349003AbiASKZg (ORCPT ); Wed, 19 Jan 2022 05:25:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45540 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238936AbiASKYa (ORCPT ); Wed, 19 Jan 2022 05:24:30 -0500 Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2838BC061574; Wed, 19 Jan 2022 02:24:30 -0800 (PST) Received: by mail-wm1-x331.google.com with SMTP id h206-20020a1c21d7000000b0034d95625e1fso5297258wmh.4; Wed, 19 Jan 2022 02:24:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=23T4xOW2I0F1J8h1VBHMXa/Hl9U+ZT3rpxlsT4/aGfc=; b=YsEHE2FoxTIEDYdQkjHZoP/fMCSt7QDmBQ4JdVPHxM4mlnOCzYop6XchK4rNHKQtf+ EB550obMnV3f5ZhHcIk/AxpQ8rIFuitjP2WoGDxLwZPMERXqneeB/TZ8sQCaB/Na7dAD gBFFTaU95S2gXYoC1ejMoGbHiqPSliY7DgwtbQkFJB0qfSMMdRfOMiiSSiPIlGi9YkfW SF6KUmqLmY0Vm9eUK4+qdupPRPxxj4ZT74ftdKfK9m/t115DOzfVBBOGbky0j7JF+4xS /laydDlP6PnfNM7FjGBWQC6AyMUnubEMwTk5FqFL60694tozYxQKd8zFSgAVHk04Owxb LpWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=23T4xOW2I0F1J8h1VBHMXa/Hl9U+ZT3rpxlsT4/aGfc=; b=wp71PNOw7uY9/OJcFWEXNEREiiehw2o2wtyR0AoKRfpKxjOVNAeuHDsU1xQhR+e/pf 4vTLMgzUjcBEyzK6XVxR5IaAis1Q4HLs/k5aKuk3I941zWh4DmpY7sGlfLzZlB4wswj/ ibNtmpIIO90BCA+e7IE54qfvDQPO27MCokYnZGddxbpFxldZCdzepuIoaGugLW54xs56 oD8iMR7P+yrCYxQNXecxtfpAL46IQFs+voh3rL2sVh1SNaKN7Sj4zujtnNvX3UxnCpdg tfElr111tKLjJGKQb3yiZOPvW1hxw65giPYVy9B5zNqOVgtRXkIaJAzqxBrx9cCFhyIg 1ghA== X-Gm-Message-State: AOAM530N5Q7n+yD6DH151KyOplkCydNiKxJMv71N/7JN4E21sKh96hvL k0N3MKJuyq9P6kVac7v15wO+2kXi812TE7t8E44= X-Google-Smtp-Source: ABdhPJyQ5Tdq7m8t7iLiOJAS4JTEijMM4at1JFtGA1ZF2R8mUGyIx8zXbXyxAiL39Qfm4S+aXM2whQ60Ky+y/NvZSKQ= X-Received: by 2002:adf:d08b:: with SMTP id y11mr27706022wrh.384.1642587868723; Wed, 19 Jan 2022 02:24:28 -0800 (PST) MIME-Version: 1.0 References: <20220110165208.1826-1-jszhang@kernel.org> In-Reply-To: From: =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= Date: Wed, 19 Jan 2022 11:24:16 +0100 Message-ID: Subject: Re: [PATCH riscv-next] riscv: bpf: Fix eBPF's exception tables To: Jisheng Zhang , Palmer Dabbelt , palmer@rivosinc.com, Daniel Borkmann Cc: Paul Walmsley , Albert Ou , Alexei Starovoitov , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Netdev , bpf , linux-riscv , LKML , Tong Tiangen Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jisheng/Palmer, On Mon, 10 Jan 2022 at 18:05, Jisheng Zhang wrote: > > On Tue, Jan 11, 2022 at 12:52:08AM +0800, Jisheng Zhang wrote: > > eBPF's exception tables needs to be modified to relative synchronously. > > > > Suggested-by: Tong Tiangen > > Signed-off-by: Jisheng Zhang Nice catch, and apologies for the slow response. Acked-by: Bj=C3=B6rn T=C3=B6pel > > --- > > arch/riscv/net/bpf_jit_comp64.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/riscv/net/bpf_jit_comp64.c b/arch/riscv/net/bpf_jit_c= omp64.c > > index 69bab7e28f91..44c97535bc15 100644 > > --- a/arch/riscv/net/bpf_jit_comp64.c > > +++ b/arch/riscv/net/bpf_jit_comp64.c > > @@ -498,7 +498,7 @@ static int add_exception_handler(const struct bpf_i= nsn *insn, > > offset =3D pc - (long)&ex->insn; > > if (WARN_ON_ONCE(offset >=3D 0 || offset < INT_MIN)) > > return -ERANGE; > > - ex->insn =3D pc; > > + ex->insn =3D offset; > > Hi Palmer, > > Tong pointed out this issue but there was something wrong with my email > forwarding address, so I didn't get his reply. Today, I searched on > lore.kernel.org just found his reply, sorry for inconvenience. > AFAIK, Jisheng's extable work is still in Palmer's for-next tree. Daniel/Alexei: This eBPF must follow commit 1f77ed9422cb ("riscv: switch to relative extable and other improvements"), which is in Palmer's tree. It cannot go via bpf-next. Palmer, please pull this to your for-next tree. Thanks, Bj=C3=B6rn