From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: MIME-Version: 1.0 In-Reply-To: <20180228192823.5191-7-bart.vanassche@wdc.com> References: <20180228192823.5191-1-bart.vanassche@wdc.com> <20180228192823.5191-7-bart.vanassche@wdc.com> From: Michael Lyle Date: Wed, 28 Feb 2018 12:18:51 -0800 Message-ID: Subject: Re: [PATCH 06/11] bcache: Use the blk_queue_flag_{set,clear}() functions To: Bart Van Assche Cc: Jens Axboe , linux-block@vger.kernel.org, Christoph Hellwig , Kent Overstreet , Hannes Reinecke , Johannes Thumshirn , Ming Lei Content-Type: text/plain; charset="UTF-8" List-ID: LGTM On Wed, Feb 28, 2018 at 11:28 AM, Bart Van Assche wrote: > Use the blk_queue_flag_{set,clear}() functions instead of open-coding > these. > > Signed-off-by: Bart Van Assche > Cc: Michael Lyle > Cc: Kent Overstreet > Cc: Christoph Hellwig > Cc: Hannes Reinecke > Cc: Johannes Thumshirn > Cc: Ming Lei > --- > drivers/md/bcache/super.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c > index 312895788036..047e30cb93dc 100644 > --- a/drivers/md/bcache/super.c > +++ b/drivers/md/bcache/super.c > @@ -833,9 +833,9 @@ static int bcache_device_init(struct bcache_device *d, unsigned block_size, > q->limits.io_min = block_size; > q->limits.logical_block_size = block_size; > q->limits.physical_block_size = block_size; > - set_bit(QUEUE_FLAG_NONROT, &d->disk->queue->queue_flags); > - clear_bit(QUEUE_FLAG_ADD_RANDOM, &d->disk->queue->queue_flags); > - set_bit(QUEUE_FLAG_DISCARD, &d->disk->queue->queue_flags); > + blk_queue_flag_set(QUEUE_FLAG_NONROT, d->disk->queue); > + blk_queue_flag_clear(QUEUE_FLAG_ADD_RANDOM, d->disk->queue); > + blk_queue_flag_set(QUEUE_FLAG_DISCARD, d->disk->queue); > > blk_queue_write_cache(q, true, true); > > -- > 2.16.2 >