From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C1338C433EF for ; Fri, 18 Feb 2022 20:54:34 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B7BE983B82; Fri, 18 Feb 2022 21:54:32 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=gateworks.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gateworks-com.20210112.gappssmtp.com header.i=@gateworks-com.20210112.gappssmtp.com header.b="Ari2J88e"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id D465883B87; Fri, 18 Feb 2022 21:54:30 +0100 (CET) Received: from mail-pl1-x62a.google.com (mail-pl1-x62a.google.com [IPv6:2607:f8b0:4864:20::62a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id ED2CE83A70 for ; Fri, 18 Feb 2022 21:54:26 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=gateworks.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=tharvey@gateworks.com Received: by mail-pl1-x62a.google.com with SMTP id z17so8070420plb.9 for ; Fri, 18 Feb 2022 12:54:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gateworks-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pE+YWhbO4abuHdz6ZB/qy8xIDDvEN2evCUXbmocAglY=; b=Ari2J88edqMiuz1NRYndeU9MK3U7hFNhvG3IHvqdGHCRcxxp+dLhIJ8eZTQFJmeWVj /C6qxRPL5yXM8fozGojQd+ZI0IU+dfym/unG1+o2IpbaxVccdlUO0AWpDRK7PcZsEGMO HC30gjyGSnM4HVWPe0u1YhML8HKMrDFjEgwC5zZJol0iY/Ccs1jWIpNJwjLLTmGNfLJM vlBLx8iwUhHo3CoeXHaTRWBrKbR45mg8dIecXZ8sHxFFvdqPNgjTQDUm0mhGCE/FEEng lFVGWaooUeIXc9xm9UeKRbdq9GHr2AiSdrETH9+0pIqZL4EnPsF7UORRJtqtSATwNTuB xFjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pE+YWhbO4abuHdz6ZB/qy8xIDDvEN2evCUXbmocAglY=; b=5gUEGwxFs90FS+0Nb4RDcixkeEccUmtTR+0LPbBFRjIsH+ZeYAz1YE14yzrhkINpsT Fg9Uf8dEEBlVNYqWcOUQGGrikf5VuGLE1fusCSUwyD5+TLC1HZUSA7HhEUpkLfuIkZxe 3By7HE+3WnajyljiDJaDIv904wv7dUXmZMAoaSMI5GQ2NAxr+UMiyYCPE45Ve1FUouz+ uN5n6uvhlTn+1dWjyX14QsyeQcpyVp8nCm6xLKmNhqYz4hrHH/7TvMfPifgOSAgN8Zji gwUFDNYrJEUaxD5CJIUB4BgNha2b1SypkiypeW/m/O4eC4Katapc7Z6vaGzX18AqWjcR vNIA== X-Gm-Message-State: AOAM531/QXwx9UDznHFagl8ej+ylsjZVw/0DMSxkOLC/79wD2SKl+TE0 eZiMXx/kYO0tamzw1/rLgX+W8aeXAarDRGHMUZ2Jcg== X-Google-Smtp-Source: ABdhPJyc4q286DpGEsqTi4ddU3MfgoQUgBS0RgJoH65JK+xpFkdtdg1/Rbpg8uaAKq8hp2/pP9WTegTLunHWe7tVMhU= X-Received: by 2002:a17:90b:3755:b0:1b8:a1eb:f0db with SMTP id ne21-20020a17090b375500b001b8a1ebf0dbmr10086069pjb.155.1645217665051; Fri, 18 Feb 2022 12:54:25 -0800 (PST) MIME-Version: 1.0 References: <20220218204841.14467-1-heiko.thiery@gmail.com> In-Reply-To: <20220218204841.14467-1-heiko.thiery@gmail.com> From: Tim Harvey Date: Fri, 18 Feb 2022 12:54:13 -0800 Message-ID: Subject: Re: [PATCH] include: configs: *imx8*: remove IMX_FEC_BASE To: Heiko Thiery Cc: u-boot , Ying-Chun Liu , Adam Ford , Peng Fan , Fabio Estevam , Marco Franchi , Alifer Moraes , Marek Vasut , Marcel Ziswiler , Rick Chen , Sean Anderson Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On Fri, Feb 18, 2022 at 12:50 PM Heiko Thiery wrote: > > The IMX_FEC_BASE value is not used when CONFIG_DM_ETH is configured. So this > value can be removed. > > Signed-off-by: Heiko Thiery > --- > include/configs/imx8mm-cl-iot-gate.h | 2 -- > include/configs/imx8mm_beacon.h | 1 - > include/configs/imx8mm_evk.h | 2 -- > include/configs/imx8mm_venice.h | 1 - > include/configs/imx8mn_beacon.h | 1 - > include/configs/imx8mq_evk.h | 2 -- > include/configs/imx8mq_phanbell.h | 2 -- > include/configs/imx8ulp_evk.h | 2 -- > include/configs/kontron_pitx_imx8m.h | 1 - > include/configs/pico-imx8mq.h | 2 -- > include/configs/verdin-imx8mm.h | 1 - > 11 files changed, 17 deletions(-) > > diff --git a/include/configs/imx8mm-cl-iot-gate.h b/include/configs/imx8mm-cl-iot-gate.h > index 7e6be6050c..4413bdcc58 100644 > --- a/include/configs/imx8mm-cl-iot-gate.h > +++ b/include/configs/imx8mm-cl-iot-gate.h > @@ -157,8 +157,6 @@ > #define CONFIG_FEC_MXC_PHYADDR 0 > #define FEC_QUIRK_ENET_MAC > > -#define IMX_FEC_BASE 0x30BE0000 > - > /* USB Configs */ > #define CONFIG_EHCI_HCD_INIT_AFTER_RESET > #define CONFIG_MXC_USB_PORTSC (PORT_PTS_UTMI | PORT_PTS_PTW) > diff --git a/include/configs/imx8mm_beacon.h b/include/configs/imx8mm_beacon.h > index 77f062474d..029e8c4c7f 100644 > --- a/include/configs/imx8mm_beacon.h > +++ b/include/configs/imx8mm_beacon.h > @@ -109,6 +109,5 @@ > #define CONFIG_FEC_XCV_TYPE RGMII > #define CONFIG_FEC_MXC_PHYADDR 0 > #define FEC_QUIRK_ENET_MAC > -#define IMX_FEC_BASE 0x30BE0000 > > #endif > diff --git a/include/configs/imx8mm_evk.h b/include/configs/imx8mm_evk.h > index c7022ef0f7..771eaf80d5 100644 > --- a/include/configs/imx8mm_evk.h > +++ b/include/configs/imx8mm_evk.h > @@ -89,6 +89,4 @@ > #define CONFIG_FEC_MXC_PHYADDR 0 > #define FEC_QUIRK_ENET_MAC > > -#define IMX_FEC_BASE 0x30BE0000 > - > #endif > diff --git a/include/configs/imx8mm_venice.h b/include/configs/imx8mm_venice.h > index 7ab11cc8fb..a828f48d2e 100644 > --- a/include/configs/imx8mm_venice.h > +++ b/include/configs/imx8mm_venice.h > @@ -109,6 +109,5 @@ > #define CONFIG_FEC_XCV_TYPE RGMII > #define CONFIG_FEC_MXC_PHYADDR 0 > #define FEC_QUIRK_ENET_MAC > -#define IMX_FEC_BASE 0x30BE0000 > > #endif > diff --git a/include/configs/imx8mn_beacon.h b/include/configs/imx8mn_beacon.h > index e2e322bb4d..e54b87c76a 100644 > --- a/include/configs/imx8mn_beacon.h > +++ b/include/configs/imx8mn_beacon.h > @@ -126,7 +126,6 @@ > #define CONFIG_FEC_XCV_TYPE RGMII > #define CONFIG_FEC_MXC_PHYADDR 0 > #define FEC_QUIRK_ENET_MAC > -#define IMX_FEC_BASE 0x30BE0000 > #endif /* CONFIG_FEC_MXC */ > > #endif > diff --git a/include/configs/imx8mq_evk.h b/include/configs/imx8mq_evk.h > index 4aaed3ae7d..1a472588ac 100644 > --- a/include/configs/imx8mq_evk.h > +++ b/include/configs/imx8mq_evk.h > @@ -43,8 +43,6 @@ > #define CONFIG_FEC_XCV_TYPE RGMII > #define CONFIG_FEC_MXC_PHYADDR 0 > #define FEC_QUIRK_ENET_MAC > - > -#define IMX_FEC_BASE 0x30BE0000 > #endif > > #ifndef CONFIG_SPL_BUILD > diff --git a/include/configs/imx8mq_phanbell.h b/include/configs/imx8mq_phanbell.h > index 16a2c2cf9d..1e1c186aed 100644 > --- a/include/configs/imx8mq_phanbell.h > +++ b/include/configs/imx8mq_phanbell.h > @@ -37,8 +37,6 @@ > #define CONFIG_FEC_XCV_TYPE RGMII > #define CONFIG_FEC_MXC_PHYADDR 0 > #define FEC_QUIRK_ENET_MAC > - > -#define IMX_FEC_BASE 0x30BE0000 > #endif > > #define CONFIG_MFG_ENV_SETTINGS \ > diff --git a/include/configs/imx8ulp_evk.h b/include/configs/imx8ulp_evk.h > index 7da6802aa5..666306c028 100644 > --- a/include/configs/imx8ulp_evk.h > +++ b/include/configs/imx8ulp_evk.h > @@ -34,8 +34,6 @@ > > #define CONFIG_FEC_XCV_TYPE RMII > #define CONFIG_FEC_MXC_PHYADDR 1 > - > -#define IMX_FEC_BASE 0x29950000 > #endif > > #ifdef CONFIG_DISTRO_DEFAULTS > diff --git a/include/configs/kontron_pitx_imx8m.h b/include/configs/kontron_pitx_imx8m.h > index 0f96b905ab..6f426cb08c 100644 > --- a/include/configs/kontron_pitx_imx8m.h > +++ b/include/configs/kontron_pitx_imx8m.h > @@ -43,7 +43,6 @@ > #define CONFIG_FEC_MXC_PHYADDR 0 > #define FEC_QUIRK_ENET_MAC > > -#define IMX_FEC_BASE 0x30BE0000 > #define PHY_ANEG_TIMEOUT 20000 > > #endif > diff --git a/include/configs/pico-imx8mq.h b/include/configs/pico-imx8mq.h > index 7bfa79059a..08204779d8 100644 > --- a/include/configs/pico-imx8mq.h > +++ b/include/configs/pico-imx8mq.h > @@ -37,8 +37,6 @@ > #define CONFIG_FEC_XCV_TYPE RGMII > #define CONFIG_FEC_MXC_PHYADDR 1 > #define FEC_QUIRK_ENET_MAC > - > -#define IMX_FEC_BASE 0x30BE0000 > #endif > > /* Initial environment variables */ > diff --git a/include/configs/verdin-imx8mm.h b/include/configs/verdin-imx8mm.h > index 17583c0a6a..859b62d6f7 100644 > --- a/include/configs/verdin-imx8mm.h > +++ b/include/configs/verdin-imx8mm.h > @@ -107,7 +107,6 @@ > #define CONFIG_FEC_XCV_TYPE RGMII > #define CONFIG_FEC_MXC_PHYADDR 7 > #define FEC_QUIRK_ENET_MAC > -#define IMX_FEC_BASE 0x30BE0000 > > /* USB Configs */ > #define CONFIG_EHCI_HCD_INIT_AFTER_RESET > -- > 2.20.1 > Heiko, Thanks for the cleanup! Reviewed-By: Tim Harvey Best Regards, Tim