From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4B461C77B7A for ; Tue, 30 May 2023 17:23:53 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id D5B0B85E7B; Tue, 30 May 2023 19:23:50 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=gateworks.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gateworks-com.20221208.gappssmtp.com header.i=@gateworks-com.20221208.gappssmtp.com header.b="EaNxOE1A"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 6024885E7B; Tue, 30 May 2023 19:23:48 +0200 (CEST) Received: from mail-yb1-xb29.google.com (mail-yb1-xb29.google.com [IPv6:2607:f8b0:4864:20::b29]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id B678185E7B for ; Tue, 30 May 2023 19:23:42 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=gateworks.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=tharvey@gateworks.com Received: by mail-yb1-xb29.google.com with SMTP id 3f1490d57ef6-ba81f71dfefso6543460276.0 for ; Tue, 30 May 2023 10:23:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gateworks-com.20221208.gappssmtp.com; s=20221208; t=1685467421; x=1688059421; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=vxXjfnlPPBkWONuSlxV/B+PnJMvxa3WhNDiiU7Z0X/U=; b=EaNxOE1AOiu79nvPOaH43j8a59tUh6c9pOBIsQGr0lEtjQPlbaqGdrOHweQK2nqrMR /WOkOiQij2P7XNvSc/B8uj6nN5fAZptCbZuhktjkHIfKXnIo8juFGVTxSEf10BSy9hw7 Z0/CpNsAwhfSUjZ4GrJd1hU8eH13GzT/tZZw2gc8QVZeMgL+srgHdpK34wSoUDmmjHcl gR3NsJWFDJUdhuyPP6NnmCVATQ7zBWup6fp2kTJN4eW12npU/Qp8qRCXsnUHN/tMf7G9 mJ71/1Q71Tec1uBK6UK/B6nAq1wcorLM+y8HlFfc7zI/dXR9Vb119KbNrdDUADjnXDiH Lq1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685467421; x=1688059421; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vxXjfnlPPBkWONuSlxV/B+PnJMvxa3WhNDiiU7Z0X/U=; b=HBQHgr5XczojdAepoXVnKux2muCoQn1BLCiDQuJAdINnhWNpUJ1lkd4gwrZADeDM5H KcPUcksbjyyBFbF7FsGXJ757VP2uejUTJi4MY8w3nKzQbrqRb6DASRnL4zJRxRklyIH5 gd+ANg3cZ8rJ8MuRT6uFtJTQGQ3SgqecNawAFTHYRYbD0aOx9CE+2iAUIRUqXiWbroH2 s4NBQlxS84FLZssgqjla3u72OD7rSQBUonZ2OZx5MqTuLzYYqKU4MK8tuqvyFXQpjP4v UwzdY6z8gMKhmPAdLH44ZioRk3aUr07ZfJ+fhffc+IWB0tNR+/Ud930ROyumFyDDSWkX j+Jg== X-Gm-Message-State: AC+VfDyGyhor/+6dpEtdecIblXxb6lIoWKYsdchhiu+1mKnpjtoUjHOd UM2jIdjTXjQYFklq2dVlfQVfrwzjZ9RpHExC4MafzQ== X-Google-Smtp-Source: ACHHUZ7D6w6WWpMhXmNDqPkpZ0VOJd0l36YKvPdhAsFHAdIVyeP2K//0+IkKk6KfKZTvWWdZO4AIaCsJ4suFNRVnJlA= X-Received: by 2002:a25:2646:0:b0:baa:7855:131 with SMTP id m67-20020a252646000000b00baa78550131mr4216941ybm.14.1685467421267; Tue, 30 May 2023 10:23:41 -0700 (PDT) MIME-Version: 1.0 References: <20230427180845.127439-1-festevam@gmail.com> <20230427180845.127439-3-festevam@gmail.com> In-Reply-To: From: Tim Harvey Date: Tue, 30 May 2023 10:23:29 -0700 Message-ID: Subject: Re: [PATCH 3/3] arm: dts: imx8mp: Sync with Linux 6.3 To: Adam Ford Cc: Fabio Estevam , sbabic@denx.de, u-boot@lists.denx.de, Fabio Estevam Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On Mon, May 29, 2023 at 10:45=E2=80=AFAM Adam Ford wro= te: > > On Wed, May 24, 2023 at 9:02=E2=80=AFPM Fabio Estevam wrote: > > > > Hi Tim, > > > > On Fri, May 19, 2023 at 8:00=E2=80=AFPM Tim Harvey wrote: > > > > > Fabio, > > + Marek > I am adding Marek since he did the HSIO power domain driver. > > > > > > > There's more to be done here also. With this patch, and with the > > > spba-bus added to u-boot.dtsi, if you try to enable usb (usb start) > > > you get: > > > starting USB... > > > Bus usb@38200000: > > > Enable clock-controller@30380000 failed > > > probe failed, error -2 > > > No working controllers found > > > > Does this help? > > A bit. I finally got some time to try to troubleshoot USB on my 8MP. > > > > > --- a/drivers/clk/imx/clk-imx8mp.c > > +++ b/drivers/clk/imx/clk-imx8mp.c > > @@ -337,8 +337,8 @@ static int imx8mp_clk_probe(struct udevice *dev) > > clk_dm(IMX8MP_CLK_UART2_ROOT, imx_clk_gate4("uart2_root_clk", > > "uart2", base + 0x44a0, 0)); > > clk_dm(IMX8MP_CLK_UART3_ROOT, imx_clk_gate4("uart3_root_clk", > > "uart3", base + 0x44b0, 0)); > > clk_dm(IMX8MP_CLK_UART4_ROOT, imx_clk_gate4("uart4_root_clk", > > "uart4", base + 0x44c0, 0)); > > - clk_dm(IMX8MP_CLK_USB_ROOT, imx_clk_gate4("usb_root_clk", > > "usb_core_ref", base + 0x44d0, 0)); > > - clk_dm(IMX8MP_CLK_USB_PHY_ROOT, > > IMX8MP_CLK_USB_PHY_ROOT is also referenced in the device tree, so I > don't think we can delete it. I had keep IMX8MP_CLK_USB_ROOT, and > IMX8MP_CLK_USB_PHY_ROOT while also adding IMX8MP_CLK_USB_SUSP. > > > imx_clk_gate4("usb_phy_root_clk", "usb_phy_ref", base + 0x44f0, 0)); > > + clk_dm(IMX8MP_CLK_USB_ROOT, imx_clk_gate4("usb_root_clk", > > "hsio_axi", base + 0x44d0, 0)); > > + clk_dm(IMX8MP_CLK_USB_SUSP, imx_clk_gate4("usb_suspend_clk", > > "osc_32k", base + 0x44d0, 0)); > > clk_dm(IMX8MP_CLK_USDHC1_ROOT, > > imx_clk_gate4("usdhc1_root_clk", "usdhc1", base + 0x4510, 0)); > > clk_dm(IMX8MP_CLK_USDHC2_ROOT, > > imx_clk_gate4("usdhc2_root_clk", "usdhc2", base + 0x4520, 0)); > > clk_dm(IMX8MP_CLK_WDOG1_ROOT, imx_clk_gate4("wdog1_root_clk", > > "wdog", base + 0x4530, 0)); > > At this point, the missing clock errors go away, but it hangs. I > updated my 8MP USB clocks based on the latest Linux kernel so my > clocks looks like: > > clk_dm(IMX8MP_CLK_USB_ROOT, imx_clk_gate2("usb_root_clk", "hsio_axi", > base + 0x44d0, 0)); > clk_dm(IMX8MP_CLK_USB_SUSP, imx_clk_gate2("usb_suspend_clk", > "clock-osc-24m", base + 0x44d0, 0)); > clk_dm(IMX8MP_CLK_USB_PHY_ROOT, imx_clk_gate4("usb_phy_root_clk", > "usb_phy_ref", base + 0x44f0, 0)); > > The linux kernel uses gate2 for USB_ROOT and USB_SUSP while gate4 is > used for IMX8MP_CLK_USB_PHY_ROOT. I didn't verify this against the > reference manual. > > With some debugging enabled, it looks to me like it might be > power-domain related, but I am not 100% certain. > When I start the USB, it appears to go through some clocks, and start > one power domain, but I think we have a power-domain chain where one > power domain starts another. I saw a patch on another thread for > enabling parent power-domains, but it didn't seem to help me. > > u-boot=3D> usb start > starting USB... > Bus usb@38200000: ofnode_read_prop: maximum-speed: > ofnode_read_prop: dr_mode: host > dev_power_domain_on usb@32f10108 > ofnode_read_prop: assigned-clock-rates: > Looking for clock-controller@30380000 > Looking for clock-controller@30380000 > - result for clock-controller@30380000: clock-controller@30380000 (ret= =3D0) > - result for clock-controller@30380000: clock-controller@30380000 (ret= =3D0) > Looking for clock-controller@30380000 > Looking for clock-controller@30380000 > - result for clock-controller@30380000: clock-controller@30380000 (ret= =3D0) > - result for clock-controller@30380000: clock-controller@30380000 (ret= =3D0) > ofnode_read_prop: dr_mode: host > > > > I added some debug code to the imx8mp_hsiomix_on in HSIOmix power > domain driver, and it doesn't appear to be getting called, yet > dev_power_domain_on usb@32f10108 should be invoking it. > > I am not positive it's a power domain issue, that's my first guess. > > > Tim - have you had any success? > Adam, No success here yet but I don't have any time to work on it for at least another week. Best Regards, Tim