All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tim Harvey <tharvey@gateworks.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] U-boot hangs on imx6 pci driver
Date: Thu, 5 Jun 2014 21:35:27 -0700	[thread overview]
Message-ID: <CAJ+vNU1CPM1e_n9EarVzX4b1dGYGXPSjB36j_GhsvfKBpZUzzw@mail.gmail.com> (raw)
In-Reply-To: <CAOMZO5B2eTfHC2Rx7A3L5UhdmFV5r2jHpgLBwZpuxmGnEKd-zw@mail.gmail.com>

On Thu, Jun 5, 2014 at 8:27 AM, Fabio Estevam <festevam@gmail.com> wrote:
> Tim,
>
> On Wed, Jun 4, 2014 at 9:16 PM, Tim Harvey <tharvey@gateworks.com> wrote:
>
>> work-around the problem on my end as well. Note that I do not see this
>> issue unless I'm using one of our boards with a PCIe switch and If I
>> disable PCI support in u-boot this does not occur. This feels like a
>
> Does this help?
>
>  drivers/pci/pcie_imx.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/pci/pcie_imx.c b/drivers/pci/pcie_imx.c
> index c48737e..190cdec 100644
> --- a/drivers/pci/pcie_imx.c
> +++ b/drivers/pci/pcie_imx.c
> @@ -435,8 +435,7 @@ static int imx6_pcie_init_phy(void)
>      clrbits_le32(&iomuxc_regs->gpr[12], IOMUXC_GPR12_APPS_LTSSM_ENABLE);
>
>      clrsetbits_le32(&iomuxc_regs->gpr[12],
> -            IOMUXC_GPR12_DEVICE_TYPE_MASK,
> -            IOMUXC_GPR12_DEVICE_TYPE_RC);
> +            IOMUXC_GPR12_DEVICE_TYPE_MASK, 4 << 12);
>      clrsetbits_le32(&iomuxc_regs->gpr[12],
>              IOMUXC_GPR12_LOS_LEVEL_MASK,
>              IOMUXC_GPR12_LOS_LEVEL_9);

Fabio,

Good catch, but that doesn't resolve the issue i'm seeing here.

Any other ideas?

Regards,

Tim

  parent reply	other threads:[~2014-06-06  4:35 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-27 12:30 [U-Boot] U-boot hangs on imx6 pci driver Fabio Estevam
2014-05-27 13:25 ` Marek Vasut
2014-05-27 14:43   ` "David Müller (ELSOFT AG)"
2014-05-27 14:56     ` Marek Vasut
2014-05-28  7:40       ` "David Müller (ELSOFT AG)"
2014-05-28 16:43         ` Fabio Estevam
2014-05-30  7:04           ` "David Müller (ELSOFT AG)"
2014-06-05  0:16             ` Tim Harvey
2014-06-05  6:30               ` "David Müller (ELSOFT AG)"
2014-06-05 10:13                 ` Tim Harvey
2014-06-20  0:11                   ` Marek Vasut
2014-06-05 15:27               ` Fabio Estevam
2014-06-05 17:53                 ` Marek Vasut
2014-06-05 19:20                   ` Fabio Estevam
2014-06-05 22:04                     ` Marek Vasut
2014-06-05 22:14                       ` Fabio Estevam
2014-06-05 22:15                         ` Marek Vasut
2014-06-06  4:35                 ` Tim Harvey [this message]
2014-06-17 14:14                   ` Fabio Estevam
2014-06-20  0:22                     ` Marek Vasut
2014-05-28 16:42 ` Fabio Estevam
2014-05-28 18:31   ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJ+vNU1CPM1e_n9EarVzX4b1dGYGXPSjB36j_GhsvfKBpZUzzw@mail.gmail.com \
    --to=tharvey@gateworks.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.