From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 840D6C433F5 for ; Wed, 13 Apr 2022 16:09:16 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id A5CC783D9B; Wed, 13 Apr 2022 18:09:14 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=gateworks.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gateworks-com.20210112.gappssmtp.com header.i=@gateworks-com.20210112.gappssmtp.com header.b="DysIM+bW"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 6FDEC83BE5; Wed, 13 Apr 2022 18:09:13 +0200 (CEST) Received: from mail-pj1-x1030.google.com (mail-pj1-x1030.google.com [IPv6:2607:f8b0:4864:20::1030]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 9E16B83DFE for ; Wed, 13 Apr 2022 18:09:10 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=gateworks.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=tharvey@gateworks.com Received: by mail-pj1-x1030.google.com with SMTP id ll10so2482614pjb.5 for ; Wed, 13 Apr 2022 09:09:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gateworks-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5mudkPyQeRX1hxsW8TerV9US4bh2OrUBV4DDmQwCItY=; b=DysIM+bW7NUdV0hGeHv/edzY5/xtgyTfrWU/h68chjqDPvaVyFfjxIY13S77QUa8nd 4tMW3DLfUN7Vt8x/elNc/gF3aLWLF+RCjBaAfH9veKmNiRdWmuOII9DfhZR4460/RA6z 8gSH/zfp8SFHz4TUjevVMSduRW53hOLK2PNReuWvV5Pdb+LLujrf6fHgYmGIRz4r6Jf8 ZdkqZ9qp7pX8aGWZqeWeFzBXC51L/ZKD8NCWJ7njG2Cy3vhX2X/1rHwtTUt4rpiPC8G/ wYCcV+U+wsACYYBoJMITDfCUgeE05hXvMLT54MSvvFhdFMuUmCdEv6Zsp1AyMKlqBTLS H/nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5mudkPyQeRX1hxsW8TerV9US4bh2OrUBV4DDmQwCItY=; b=K6yXZ5hMyfZR2/WMYbWcWw/eJvZObxevPkPOUubzxe/k659Llw6RMZN/KA4MM5NLUV 8PG+KzQFlyZlpd7GWjTv422KVNyGYqTutbzWpmKYquDgZyK2H8yG1l5OvMyu9hneucw7 MGHPQq6Z+Tg29qIIUrbWxBqAC5oi+h9xWOvxVfapl8X6p3e1mnipNBQa25QeLi+JJvge ptIRmgO7kKgzGrWGx3YFbYZg8kH8nX0PRjImUMYw+iOC2FPnedTFreQkXEf2J5fRL5TW ZD4hfKkOZuZg1PvFAdLn6omurtdXJgHgb2pqW+Rlc8bx8RLVN0kasp0AI0iDrfccst44 M+Wg== X-Gm-Message-State: AOAM532/ZdAQq10cL8gEHTK0YqTyDPLUtspqcdPW6e7v+h7OV4hB4RHh GYrlAYeT359ADqSqy+QMN1+rfuP9bVx1g5SKnvZIEgDHotA= X-Google-Smtp-Source: ABdhPJxZoqmKv46Vs1CFinFMx9AdV8cQuYqb3RMdj7vrHGfR7yYqcXU8LU5Mk3DokmK765skh/SP8/hFR4JoKdaZUmI= X-Received: by 2002:a17:902:c405:b0:158:642f:bb1d with SMTP id k5-20020a170902c40500b00158642fbb1dmr16175077plk.63.1649866148859; Wed, 13 Apr 2022 09:09:08 -0700 (PDT) MIME-Version: 1.0 References: <20220413154719.20433-1-tharvey@gateworks.com> In-Reply-To: From: Tim Harvey Date: Wed, 13 Apr 2022 09:08:55 -0700 Message-ID: Subject: Re: [PATCH v2] board: gateworks: venice: enable DM_SERIAL To: Michael Nazzareno Trimarchi Cc: Stefano Babic , Fabio Estevam , "NXP i . MX U-Boot Team" , u-boot Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On Wed, Apr 13, 2022 at 8:56 AM Michael Nazzareno Trimarchi wrote: > > Hi Tim > > On Wed, Apr 13, 2022 at 5:47 PM Tim Harvey wrote: > > > > Enable DM_SERIAL. > > > > Signed-off-by: Tim Harvey > > --- > > v2: rebase on imx/master > > --- > > configs/imx8mm_venice_defconfig | 2 ++ > > configs/imx8mn_venice_defconfig | 2 ++ > > 2 files changed, 4 insertions(+) > > > > diff --git a/configs/imx8mm_venice_defconfig b/configs/imx8mm_venice_defconfig > > index dd61ec9b70fb..09f7d8a58ca7 100644 > > --- a/configs/imx8mm_venice_defconfig > > +++ b/configs/imx8mm_venice_defconfig > > @@ -110,6 +110,8 @@ CONFIG_SPL_DM_PMIC_MP5416=y > > CONFIG_DM_REGULATOR=y > > CONFIG_DM_REGULATOR_FIXED=y > > CONFIG_DM_REGULATOR_GPIO=y > > +CONFIG_DM_SERIAL=y > > +# CONFIG_SPL_DM_SERIAL is not set > > CONFIG_MXC_UART=y > > CONFIG_SYSRESET=y > > CONFIG_SPL_SYSRESET=y > > diff --git a/configs/imx8mn_venice_defconfig b/configs/imx8mn_venice_defconfig > > index c3a96a378553..41898da4aecf 100644 > > --- a/configs/imx8mn_venice_defconfig > > +++ b/configs/imx8mn_venice_defconfig > > @@ -108,6 +108,8 @@ CONFIG_SPL_DM_PMIC_MP5416=y > > CONFIG_DM_REGULATOR=y > > CONFIG_DM_REGULATOR_FIXED=y > > CONFIG_DM_REGULATOR_GPIO=y > > +CONFIG_DM_SERIAL=y > > +# CONFIG_SPL_DM_SERIAL is not set > > CONFIG_MXC_UART=y > > CONFIG_SYSRESET=y > > CONFIG_SPL_SYSRESET=y > > -- > > 2.17.1 > > > > Should not select in your board kconfig? > Michael, I don't think it really matters. The other conversions to DM_SERIAL are going in defconfigs as well. Best Regards, Tim