From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DAC3CC77B73 for ; Thu, 27 Apr 2023 22:25:23 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 4341C85EEB; Fri, 28 Apr 2023 00:25:21 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=gateworks.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gateworks-com.20221208.gappssmtp.com header.i=@gateworks-com.20221208.gappssmtp.com header.b="hMbiRZs0"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id A0E0A8617E; Fri, 28 Apr 2023 00:25:19 +0200 (CEST) Received: from mail-yw1-x1132.google.com (mail-yw1-x1132.google.com [IPv6:2607:f8b0:4864:20::1132]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 7D99F86271 for ; Fri, 28 Apr 2023 00:25:16 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=gateworks.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=tharvey@gateworks.com Received: by mail-yw1-x1132.google.com with SMTP id 00721157ae682-54fb9384c2dso107865207b3.2 for ; Thu, 27 Apr 2023 15:25:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gateworks-com.20221208.gappssmtp.com; s=20221208; t=1682634315; x=1685226315; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=8/wrpTHgBC+ugzfQ0MGW0cSf7ceaG0U/rsCPwM52r7Q=; b=hMbiRZs0ZGZSqyyrzUtHKSnX71Y5pHBWBYMkCG+vJw/MqKoTl7VGkx40eMUEdQDB4w lgfbdHR7n33yMoyPzuIeAtzZfCNLRwux4V+Fu/nvzFvgop/Xq/kQsP/q5UalwfxYQgEw qSqe8WpCBF9p9vJF0MmCgXTPpxPTdkFd2SSmouPZv1oWUsSDpAzcvGqYJtDbXajWMbqG 6noWQjZ/cRxdJ+pQtDeNti4B18RbpmXnorgepokwS8EfCN8RurXVJ2aT5Jum3Kuxb+yw gWlRTSMX5WQu8dA1rgQOr5f4iksCWUXCUiYl7egg0ZiNkyfGf91zUPnkBcQUynzq6Jg3 +Pgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682634315; x=1685226315; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8/wrpTHgBC+ugzfQ0MGW0cSf7ceaG0U/rsCPwM52r7Q=; b=Hi1n/+EbRcZicDoc0RYBkdg8r8lIDS9kqK3wQrV28VmYsLdne60KDdfqiyeyACUZJj ccFyXzHgF9kUpdqXG8f0GfJYtwTf8DzjJ1aGaoUPn5o94n9rXgqSzss7H4pRfzyQQbSc L4GEHXseqU5Y9c+HpkkPTLLugpdz4QHAzctq2iA/l96vKZKK7m+PjTT8Qlwhs6BRxtT4 qz4BCcqued5uDGcmM45iHr5i4CLdob135YoIa29eIOdEi256PKh2eKU4JJK7eN40ZaOk DbJsJq57LFdG3A37FXyJ2zUGcym98oO3SUtrqF67P4l3JG97LI7JbViFXPOkHNif1bGe qPuQ== X-Gm-Message-State: AC+VfDxs9GzVkNZ99xZm1sFaxEzOdWw3nlCO6pttbPvZ06k2Yfywbbu8 NQaMh1/N7aNoU1pV8/5T41bM4PzRhR/VwxfMHxJKjw== X-Google-Smtp-Source: ACHHUZ7Nxw+2s45LejJWpyhrqx+9fA+IKZjT8Kz+6d/M53cg0Et/17pjBCYjP2C1WC9rDBoCK2yPgTFCq3pdNKrDcR4= X-Received: by 2002:a81:91d3:0:b0:54f:92b3:5459 with SMTP id i202-20020a8191d3000000b0054f92b35459mr2453538ywg.6.1682634315028; Thu, 27 Apr 2023 15:25:15 -0700 (PDT) MIME-Version: 1.0 References: <20230427180845.127439-1-festevam@gmail.com> In-Reply-To: From: Tim Harvey Date: Thu, 27 Apr 2023 15:25:03 -0700 Message-ID: Subject: Re: [PATCH 1/3] arm: dts: imx8mm: Sync with Linux 6.3 To: Fabio Estevam Cc: aford173@gmail.com, sbabic@denx.de, u-boot@lists.denx.de, Fabio Estevam Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On Thu, Apr 27, 2023 at 12:49=E2=80=AFPM Fabio Estevam = wrote: > > On Thu, Apr 27, 2023 at 4:44=E2=80=AFPM Tim Harvey wrote: > > > Fabio, > > > > Sorry for the confusion. > > > > This imx8mm dt sync patch will hang on imx8mm boards that use 'both' > > usbotg1 and usbotg2. You can reproduce this hang on your imx8mm-evk by > > enabling usbotg2 in the dt (the board has it but it is not enabled due > > to the gpio based usb 3.0 mux not being sorted out yet): > > +&usbotg2 { > > + dr_mode =3D "otg"; > > + status =3D "okay"; > > +}; > > + > > > > u-boot=3D> usb start && usb tree > > starting USB... > > Bus usb@32e40000: Bus usb@32e50000: > > ^^^ imx8mm-evk hangs > > Yes, I can reproduce the hang, but it happens with or without the > imx8mm dt sync. > Fabio, I do 'not' see a hang on imx8mm-evk on 'usb start && usb tree' on master (my other issue was on a 'usb stop' but only with usb controllers in host mode). > This hang is a separate issue, not dt related, as far as I understand. > > The imx8mm dts sync does solve the issue of running 'ums' after CTRL+C. I don't agree. The hang 'is' related because all my imx8mm-venice-* boards which use 'both' USB controllers hang with this patch on a 'usb start' and don't hang without it. While a basic 'review' of the patch looks good but actual product testing shows issues. As a maintainer for ARM FREESCALE IMX you must have another imx8mm board which uses both usbotg devices to test against and verify you see what I see? Until we know what other fix is needed to go along with this: Nacked-by: Tim Harvey I've verified that it's the changes from Linux commit 4585c79ff477f ("arm64: dts: imx8mm: correct usb power domains") that causes the hang, but I don't know why yet. Why are we seeing different behavior on the imx8mm-evk? Are we on different branches? My testing today is on caf0a88d9f31 Best Regards, Tim