From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94FEFC11F67 for ; Fri, 2 Jul 2021 00:49:20 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CADBC613F0 for ; Fri, 2 Jul 2021 00:49:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CADBC613F0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=gateworks.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 68DC382BC9; Fri, 2 Jul 2021 02:49:17 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=gateworks.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gateworks-com.20150623.gappssmtp.com header.i=@gateworks-com.20150623.gappssmtp.com header.b="qAZoy1NN"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 8812682BB4; Fri, 2 Jul 2021 02:49:16 +0200 (CEST) Received: from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com [IPv6:2607:f8b0:4864:20::1029]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 9F42082BB4 for ; Fri, 2 Jul 2021 02:49:13 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=gateworks.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=tharvey@gateworks.com Received: by mail-pj1-x1029.google.com with SMTP id g24so5389366pji.4 for ; Thu, 01 Jul 2021 17:49:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gateworks-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Fp142NKOT9O7FP3kpp2POZ5wRrBl+VM3nGzeLaGkiIg=; b=qAZoy1NNPdT0gi4c96JUHjmAIoOvYmFZ2vsEsrDDmzWeSsPHfMQUeKarG5PTEJRwd3 aA3YriC99CdGQFPKDhCxX3/71FpBkuh1PCGuHCiy8UyKuR1Z5AgyItufavXHBlWMGmOG YMxYtI+s5ryMzbFK7uClHlmWA2dYSIEvCHiArxjQZmcRsOEbwB3xdCNb7BGpjQrEJZYu gfgSjHEsKqz4MxxZg1wTXe3echa8gXnZ5BzMSKyA153Un3WC7etzkARCwQfqPwKToeXi pkF8hluIdXDTUOzp0/5i73zb9iFVPRLsQ2p6T+FMTPhxZd2I1HU3GyCFQlxSDmgs6nsr wGdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Fp142NKOT9O7FP3kpp2POZ5wRrBl+VM3nGzeLaGkiIg=; b=jvQTZlCN5cjPhPVpPyElD+hBHfceQ7i66uf+CCY15/TMCENaCwwUqHP1Gk3aYyUsFm Dq0LU4dsuhsm9Pm7wz/jPkmltw8fUUFb67DKM6ouCfdDEI7HUHTIipb/POnbJUWS+oYb t7jezmoyYkvucxhXL8oFtPZ1xhXucSYPXJ+GvF0SQjsLUJPQuy1IojRmfBG6lUlbj862 yaNR9ZIS/qdYyMCoJAdZt+vayYey0isVuYIq5eGyiQjZp/zn2A78aLscgphtYvBHZpja G0lE19ZiP8Xj5v2h54Zoz73BQlojiqXQQjVHo7ZVGg8fiGJj5ukgTihtQIevAm3fqHJH V5uw== X-Gm-Message-State: AOAM5303/w1bzOGPaxhncIJSoQi9I45tHZusb9vbZ4VXIeNLJxtC30iB QaTzB1X1V8g1bacxCrDGKdIw3jt1IVITpldLQuww4w== X-Google-Smtp-Source: ABdhPJyZDgGNbA8EUEdugV4FAErrVTl2zIFFYPPzj4XVcvMxTDI0ZB0cHC6/a06jMjnBrs38qpRYpH7KY2YqZdeEx3k= X-Received: by 2002:a17:902:c408:b029:129:3680:32f1 with SMTP id k8-20020a170902c408b0290129368032f1mr1908095plk.81.1625186951856; Thu, 01 Jul 2021 17:49:11 -0700 (PDT) MIME-Version: 1.0 References: <42254730-c8fb-8b1e-0b6e-dd5dd9da57a4@kontron.de> <99d1790f-101a-a09e-503a-4f90775f9d3e@kontron.de> <9d7f8b3a-6e54-9b3b-c820-06678b2c225c@kontron.de> In-Reply-To: From: Tim Harvey Date: Thu, 1 Jul 2021 17:49:00 -0700 Message-ID: Subject: Re: iMX8MM USB support? To: Fabio Estevam Cc: Schrempf Frieder , u-boot , Peng Fan Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Thu, Jul 1, 2021 at 5:36 PM Fabio Estevam wrote: > > Hi Tim, > > On Thu, Jul 1, 2021 at 8:58 PM Tim Harvey wrote: > > > Fabio, > > > > I no longer have the patches/config around and am not sure I even have > > a working imx8mm-evk anymore. > > > > Do you have the patches I submitted to enable USB OTG in general on IMX= 8MM? > > usb: ehci-mx6: add IMX8MM and IMX8MN OTG support > > usb: ehci-mx6: move mode set/detect to probe > > Thanks for pointing out these patches. Does "ums 0 mmc 0" work for you? > Yes, this works on my board. I just sent a v2 of these patches (cc'd you). By the way, I took a quick stab at enabling SDP on imx8mm-venice-gw73xx-0x and found compile issues so I configured for an imx8mm_evk using your diffs and hit the same issues. drivers/usb/host/ehci-mx6.c: In function =E2=80=98ehci_hcd_init=E2=80=99: drivers/usb/host/ehci-mx6.c:360:46: error: =E2=80=98USB_BASE_ADDR=E2=80=99 = undeclared (first use in this function); did you mean =E2=80=98SRC_BASE_ADDR=E2=80=99? struct usb_ehci *ehci =3D (struct usb_ehci *)(USB_BASE_ADDR + ^~~~~~~~~~~~~ SRC_BASE_ADDR drivers/usb/host/ehci-mx6.c:360:46: note: each undeclared identifier is reported only once for each function it appears in drivers/usb/host/ehci-mx6.c:361:4: error: =E2=80=98controller_spacing=E2=80= =99 undeclared (first use in this function); did you mean =E2=80=98console_star= t=E2=80=99? (controller_spacing * index)); ^~~~~~~~~~~~~~~~~~ ... The above is resolved with CONFIG_DM_USB=3Dy and CONFIG_SPL_DM_USB=3Dy After enabling those I just run into other issues with things such as: WARNING 'mkimage.flash.mkimage' not found, resulting binary is not-function= al ... aarch64-linux-ld.bfd: cmd/nvedit.o: in function `env_match': /usr/src/venice/uboot-master/cmd/nvedit.c:824: undefined reference to `env_get_char' aarch64-linux-ld.bfd: /usr/src/venice/uboot-master/cmd/nvedit.c:828: undefined reference to `env_get_char' ... What branch were you working with here? I tried the above with v2021.07-rc5 Tim