All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tim Harvey <tharvey@gateworks.com>
To: u-boot@lists.denx.de
Subject: [PATCH 02/26] imx8mm_evk: Update to latest LPDDR4 script
Date: Wed, 24 Mar 2021 14:19:39 -0700	[thread overview]
Message-ID: <CAJ+vNU2Pos1Oim+OT43hsxSRoH0VfwTRxVi5v=LwCi9ktbR-sw@mail.gmail.com> (raw)
In-Reply-To: <20210319075718.14181-3-peng.fan@oss.nxp.com>

On Fri, Mar 19, 2021 at 12:26 AM Peng Fan (OSS) <peng.fan@oss.nxp.com> wrote:
>
> From: Ye Li <ye.li@nxp.com>
>
> Update LPDDR4 script to sync with v2020.04 u-boot
>
> Signed-off-by: Ye Li <ye.li@nxp.com>

Peng,

The commit log does not make sense. I believe you want to say
something like 'Update LPDDR4 script to sync with <xyz> version of the
NXP MX8M_DDR_tool'.

> ---
>  board/freescale/imx8mm_evk/lpddr4_timing.c | 692 +++++++++------------
>  1 file changed, 280 insertions(+), 412 deletions(-)
>
> diff --git a/board/freescale/imx8mm_evk/lpddr4_timing.c b/board/freescale/imx8mm_evk/lpddr4_timing.c
> index 8e48b9d81b..4373ca624e 100644
> --- a/board/freescale/imx8mm_evk/lpddr4_timing.c
> +++ b/board/freescale/imx8mm_evk/lpddr4_timing.c
> @@ -1,129 +1,162 @@
>  // SPDX-License-Identifier: GPL-2.0+
>  /*
> - * Copyright 2019 NXP
> + * Copyright 2018-2019 NXP
> + *
> + * Generated code from MX8M_DDR_tool
>   */

I understand that this file is a direct output of the NXP MX8M_DDR
tool but it would be nice to see you add to the comment above what
version of the tool you used to produce this what functional
differences it makes. If you knew what version of the tool produced
the original file one could compare versions.

As I am the maintainer of an IMX8M Mini board also, I try to pay
attention to NXP's updates to the DDR timing config files to let me
know if something important has changed.

Best Regards,

Tim

  reply	other threads:[~2021-03-24 21:19 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-19  7:56 [PATCH 00/26] imx: update for i.MX8M Peng Fan
2021-03-19  7:56 ` [PATCH 01/26] tools: imx image: fix write warning Peng Fan
2021-03-19  7:56 ` [PATCH 02/26] imx8mm_evk: Update to latest LPDDR4 script Peng Fan
2021-03-24 21:19   ` Tim Harvey [this message]
2021-03-25  1:15     ` Peng Fan
2021-03-19  7:56 ` [PATCH 03/26] imx8mm_evk: Switch to new imx8mm evk board Peng Fan
2021-05-12 21:47   ` ZHIZHIKIN Andrey
2021-05-14 12:30     ` Fabio Estevam
2021-05-14 15:29       ` Ricardo Salveti
2021-05-14 15:59         ` Fabio Estevam
2021-05-16 14:31         ` ZHIZHIKIN Andrey
2021-05-18 13:14           ` Vanessa Maegima
2021-05-18 19:51             ` ZHIZHIKIN Andrey
2021-05-16 14:21       ` ZHIZHIKIN Andrey
2021-05-17  0:34     ` Peng Fan
2021-03-19  7:56 ` [PATCH 04/26] imx8mm/p: remove boot.cmd Peng Fan
2021-03-19  7:56 ` [PATCH 05/26] imx8mm_evk: add/cleanup variable for distro Peng Fan
2021-03-19  7:56 ` [PATCH 06/26] imx8mp_evk: " Peng Fan
2021-03-19  7:56 ` [PATCH 07/26] imx8mp: ddr: Add inline ECC feature support Peng Fan
2021-03-19  7:57 ` [PATCH 08/26] imx8mp_evk: Update LPDDR4 timing for new FW 202006 Peng Fan
2021-03-19  7:57 ` [PATCH 09/26] imx8mp_evk: Update LPDDR4 refresh time Peng Fan
2021-03-19  7:57 ` [PATCH 10/26] imx8mp: refine power on imx8mp board Peng Fan
2021-03-19  7:57 ` [PATCH 11/26] imx8mp_evk: spl: clean up including headers Peng Fan
2021-03-19  7:57 ` [PATCH 12/26] imx8mp_evk: Increase VDD_ARM to 0.95v Overdrive voltage Peng Fan
2021-03-19  7:57 ` [PATCH 13/26] imx8mn: Update the DDR4 timing script on imx8mn ddr4 evk Peng Fan
2021-03-19  7:57 ` [PATCH 14/26] power: pca9450: add a new parameter for power_pca9450_init Peng Fan
2021-03-21 22:41   ` Jaehoon Chung
2021-03-19  7:57 ` [PATCH 15/26] imx8mn_evk: drop duplicated code Peng Fan
2021-03-19  7:57 ` [PATCH 16/26] imx8mn: Add LPDDR4 EVK board support Peng Fan
2021-03-19  7:57 ` [PATCH 17/26] imx8mn: Add low drive mode support for DDR4/LPDDR4 EVK Peng Fan
2021-03-19  7:57 ` [PATCH 18/26] imx: logos: use NXP logo Peng Fan
2021-03-19  7:57 ` [PATCH 19/26] imx8mn: Add support for 11x11 UltraLite part number Peng Fan
2021-03-19  7:57 ` [PATCH 20/26] imx8m: Update thermal and PMU kernel nodes for dual/single cores Peng Fan
2021-03-19  7:57 ` [PATCH 21/26] imx8m: soc: update fuse path Peng Fan
2021-03-19  7:57 ` [PATCH 22/26] imx8m: ddr: Disable CA VREF Training for LPDDR4 Peng Fan
2021-03-24 21:25   ` Tim Harvey
2021-03-25  8:14     ` Stefano Babic
2021-03-25  8:35       ` Peng Fan
2021-03-19  7:57 ` [PATCH 23/26] arch: mach-imx: imx8m: fix unique_id read error for imx8mp Peng Fan
2021-03-19  7:57 ` [PATCH 24/26] iMX8MQ: Recognize the B2 revision Peng Fan
2021-03-19  7:57 ` [PATCH 25/26] misc: ocotp: Update OCOTP driver for iMX8MQ B2 Peng Fan
2021-03-19  7:57 ` [PATCH 26/26] imx8mq_evk: Applying default LPDDR4 script for B2 Peng Fan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJ+vNU2Pos1Oim+OT43hsxSRoH0VfwTRxVi5v=LwCi9ktbR-sw@mail.gmail.com' \
    --to=tharvey@gateworks.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.