From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB681C433EF for ; Thu, 9 Dec 2021 16:40:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237655AbhLIQoA (ORCPT ); Thu, 9 Dec 2021 11:44:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37234 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241244AbhLIQn6 (ORCPT ); Thu, 9 Dec 2021 11:43:58 -0500 Received: from mail-pj1-x1033.google.com (mail-pj1-x1033.google.com [IPv6:2607:f8b0:4864:20::1033]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 74110C061746 for ; Thu, 9 Dec 2021 08:40:24 -0800 (PST) Received: by mail-pj1-x1033.google.com with SMTP id nh10-20020a17090b364a00b001a69adad5ebso5299965pjb.2 for ; Thu, 09 Dec 2021 08:40:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gateworks-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=XjBC6XUZJtPnhjTwfnkF808Zuq6NSOID5LVmEgkaOSQ=; b=w7Km7X5aTXVv4afJepuvvxUzlxaeKJkB6sKRFHDAPKphveY5UYuehMBl5Zgkz0c48s YW0+gmxf9V2Rn4oBHSkEY+MkK/J2o8HT5yUcBuotgbi/x1Odki/kiCJhSyeB7riY6+MD cBfNgfvIHQD33UUdIa9M2zULndAZv97MPUEOdlV7TLd1uqfCgKd8ipQkXx91qxCkq2xg 17Q20lXqHkjWN3telzgJhms20L7mwI+EZUmNZXX39+EIZPqVOcZ6WeWf+nI+oApi6cvV jcnrdiMnASvfcpGnePC4rZ3bsOYr82BR5kCL7XWML42AipHPxITYKGmEekVIaU2dYZBx 9byQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XjBC6XUZJtPnhjTwfnkF808Zuq6NSOID5LVmEgkaOSQ=; b=ygHCyWlMeub67/tbpOJt2U9B8ttn1sGN13txUfuSeOfFtxmhsryDIGXMcXasC1tHiK 4u3F+WvHAcJMRIJ21aBpjTL5V/VWscuF0SgMRuVevQ1jtKjvYVMGgx+RQBwIAEKGmIh5 waiztrMhWEqhCtDm6KQFcVTm9zdXtPL+8NHGeb+fHszblYjl8GG5BpstNAYUBnG50iSG yj4x0+ERQ/hTqW3ent5/gjLg440hyP872VwuxYGT25B3cRSMH3zPmCS+UYZf5Q71K5JC jYZGv2DXc8UG/Xl+CKHWxN6BNvVsJNCEbAy+6uAloUq60jV/FKfV0L3jxeS3iEYTJb0G WQQQ== X-Gm-Message-State: AOAM533GR/6EDjLzelhxOza49Es9Z65zfC9RSTbiUSE3+8mOVUfg47Y6 jlQVk3iOTrBFdGJIxG+XBWU8K00dHdiL+hf6VMScJA== X-Google-Smtp-Source: ABdhPJzx3c4r0U+1q6LMafUGVo/WqdHyJSDJX1lRvhv0uEvpW1qCUNrk01ja1Jr5pkapoYydNfefkbMsZ9ornAF1028= X-Received: by 2002:a17:90b:4b4c:: with SMTP id mi12mr16962368pjb.66.1639068023870; Thu, 09 Dec 2021 08:40:23 -0800 (PST) MIME-Version: 1.0 References: <20210704090230.26489-1-jagan@amarulasolutions.com> In-Reply-To: From: Tim Harvey Date: Thu, 9 Dec 2021 08:40:12 -0800 Message-ID: Subject: Re: [RFC PATCH 00/17] drm: bridge: Samsung MIPI DSIM bridge To: Michael Nazzareno Trimarchi Cc: Jagan Teki , Sam Ravnborg , Marek Vasut , devicetree , linux-samsung-soc , Joonyoung Shim , Neil Armstrong , linux-amarula , dri-devel , Krzysztof Kozlowski , Seung-Woo Kim , Robert Foss , Frieder Schrempf , Andrzej Hajda , Kyungmin Park , Laurent Pinchart , Daniel Vetter , linux-arm-kernel , NXP Linux Team Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, Dec 9, 2021 at 12:36 AM Michael Nazzareno Trimarchi wrote: > > Hi Tim > > On Tue, Oct 5, 2021 at 11:43 PM Tim Harvey wrote: > > > > On Sun, Jul 25, 2021 at 10:14 AM Jagan Teki wrote: > > > > > > Hi Sam, > > > > > > On Sun, Jul 25, 2021 at 10:35 PM Sam Ravnborg wrote: > > > > > > > > Hi Jagan, > > > > > > > > On Sun, Jul 04, 2021 at 02:32:13PM +0530, Jagan Teki wrote: > > > > > This series supports common bridge support for Samsung MIPI DSIM > > > > > which is used in Exynos and i.MX8MM SoC's. > > > > > > > > > > The final bridge supports both the Exynos and i.MX8MM DSI devices. > > > > > > > > > > Right now bridge offers two sets of implementations. > > > > > > > > > > A. With component_ops and exynos specific code exclusively for > > > > > exynos dsi drivers and it's legacy bindings. > > > > > > > > > > B. Without componenet_ops for newly implemented bridges and its > > > > > users like i.MX8MM. > > > > > > > > > > The future plan is to fix the implementation A) by dropping > > > > > component_ops and fixing exynos specific code in order to make > > > > > the bridge more mature to use and the same is mentioned in > > > > > drivers TODO. > > > > > > > > > > Patch 0001 - 0006: Bridge conversion > > > > > Patch 0007 - 0017: Samsung MIPI DSIM bridge fixes, additions > > > > > > > > > > Tested in Engicam i.Core MX8M Mini SoM. > > > > > > > > > > Anyone interest, please have a look on this repo > > > > > https://github.com/openedev/linux/tree/070421-imx8mm-dsim > > > > > > > > > > Would appreciate anyone from the exynos team to test it on > > > > > the exynos platform? > > > > > > > > > > Any inputs? > > > > > > > > I really like where you are headign with this! > > > > No testing - sorry. But I will try to provide a bit of feedback on the > > > > individual patches. > > > > > > > > I hope you find a way to move forward with this. > > > > > > Thanks for the response. > > > > > > We have found some issues with Bridge conversion on existing exynos > > > drivers. The component based DSI drivers(like exynos) are difficult to > > > attach if it involves kms hotplug. kms hotplug would require drm > > > pointer and that pointer would only available after the bind call > > > finishes. But the bridge attach in bind call will defer till it find > > > the attached bridge. > > > > > > Right now I'm trying to find the proper way to attach the bridges for > > > component based DSI drivers which involves kms hot-plug. > > > > > > If you have any ideas on this, please let me know. > > > > > > > Jagan, > > > > How is your progress on this series? Looking at your repo it looks > > like you've rebased on top of 5.13-rc3 in your 070121-imx8mm-dsim > > branch but you've got a lot of things there that are likely not > > related to this series? > > I have a bit of work on those patches and tested on imx8mn. Basically: > > - add the dsi timing calculation > - change few difference with samsung bridge > - fix crashes of my dsi panels > - compare with NXP driver the final results > > I found that I have one problem that gives me some instability. In the > NXP original driver the panel needs to be > enabled in bridge_enable before out the standby. If I understand > correctly, our standby should be done after. > I would like to have some feedback and help and testing on other > boards/devices and some suggestions on how to handle > some of the differences. Another big problem is etnavi that is not stable > Michael, Where can I find your patches? What do you mean by etnaviv not being stable? I did some limited testing with etnaviv on imx8mm with 5.15 + dsi patches on an Ubuntu focal root filesystem by: apt update apt install gnome-session gnome-terminal ^^^ 2D hardware acceleration appears to be working (dragging opaque windows around) apt install mesa-utils glmark2 glxgears ^^^ ~160fps on IMX8MM glmark2 ^^^ score of 39 on IMX8MM I haven't seen any updates from Jagan since Nov 24 (https://www.spinics.net/lists/dri-devel/msg324059.html) and am not sure if he's been able to work through drm/exynos issues that have been blocking his progress. Best regards, Tim From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C823CC433F5 for ; Thu, 9 Dec 2021 16:42:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qIf389P4RJNNJp6/0zRdLhVeiQyKAt2dtsKDz+V7VP4=; b=fFn/Oo970t2em9 Pzwj5/m+SnhWAL4UViKfQM65BIZrLzQPSknnLIXk6uys4qhyixa2YTFTixGpch53RsrdkJzJA3VCO KLLzMy2cz959L/6zSx/w582XjPrPd4Kb6HuD5l92THONZdFCDui5jxwxSOAZscrH8zU9F8FaBkNbW 92H3qqUjvMBjVUdITWyHHYRFf5n+0I/nfC1XomA+C/rbaI1gJwPw0elylckn2O8eqGY0mRWbEMtmA O0fW3XYCJ1UxMtE/yjGAdzfGQfL6s2sd5vjLT3iwBUShW+s5nlsoSTrZWY19aL1ltBzeE+bBPQrtJ 03LrZTCcbw3W3Pa2khvA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mvMTB-00Gig9-00; Thu, 09 Dec 2021 16:40:33 +0000 Received: from mail-pj1-x102d.google.com ([2607:f8b0:4864:20::102d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mvMT4-00Giea-6W for linux-arm-kernel@lists.infradead.org; Thu, 09 Dec 2021 16:40:28 +0000 Received: by mail-pj1-x102d.google.com with SMTP id fv9-20020a17090b0e8900b001a6a5ab1392so5301573pjb.1 for ; Thu, 09 Dec 2021 08:40:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gateworks-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=XjBC6XUZJtPnhjTwfnkF808Zuq6NSOID5LVmEgkaOSQ=; b=w7Km7X5aTXVv4afJepuvvxUzlxaeKJkB6sKRFHDAPKphveY5UYuehMBl5Zgkz0c48s YW0+gmxf9V2Rn4oBHSkEY+MkK/J2o8HT5yUcBuotgbi/x1Odki/kiCJhSyeB7riY6+MD cBfNgfvIHQD33UUdIa9M2zULndAZv97MPUEOdlV7TLd1uqfCgKd8ipQkXx91qxCkq2xg 17Q20lXqHkjWN3telzgJhms20L7mwI+EZUmNZXX39+EIZPqVOcZ6WeWf+nI+oApi6cvV jcnrdiMnASvfcpGnePC4rZ3bsOYr82BR5kCL7XWML42AipHPxITYKGmEekVIaU2dYZBx 9byQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XjBC6XUZJtPnhjTwfnkF808Zuq6NSOID5LVmEgkaOSQ=; b=OAEYnmVTPX7MdV3BHEKF9h6EmvaiAWGMot9DZrpij87LMH2gvXJxCjKFZcH6CI4B8Q nNge4FRXKPTGXVKznq7tAmi7v66GDtS4kC6EkcvmskjHSSv0n1WGHHNHTKE/pUmj51Oo /70ChO8ewC2Cw3Cog5JeW2SfJM2YpbaL2hjRVpv5ybaVJm+J0q/W0yHycdHz+ZXUWrum 6MJ6cWCBLe8hzWsdnOkjwBjjQXypf9PqRkQfsLPKOtW/HcFu1GnDlzNLYQHEi0ZFfaNf RjTIeUvGHErRlQZOAxGmPbrimuE+W3yO+Xc6zlmKyjdeapP0yCq7qmLMGLPaTMxuWHhS aWqA== X-Gm-Message-State: AOAM530a8PjIQbtUskh/Sfs2fMAAnzwO5XqGJSRTT9uRMk27O+vm+daT hpms4OwerTSkJHkp0htGqzm0aPJzkxssd9yr4UxQSw== X-Google-Smtp-Source: ABdhPJzx3c4r0U+1q6LMafUGVo/WqdHyJSDJX1lRvhv0uEvpW1qCUNrk01ja1Jr5pkapoYydNfefkbMsZ9ornAF1028= X-Received: by 2002:a17:90b:4b4c:: with SMTP id mi12mr16962368pjb.66.1639068023870; Thu, 09 Dec 2021 08:40:23 -0800 (PST) MIME-Version: 1.0 References: <20210704090230.26489-1-jagan@amarulasolutions.com> In-Reply-To: From: Tim Harvey Date: Thu, 9 Dec 2021 08:40:12 -0800 Message-ID: Subject: Re: [RFC PATCH 00/17] drm: bridge: Samsung MIPI DSIM bridge To: Michael Nazzareno Trimarchi Cc: Jagan Teki , Sam Ravnborg , Marek Vasut , devicetree , linux-samsung-soc , Joonyoung Shim , Neil Armstrong , linux-amarula , dri-devel , Krzysztof Kozlowski , Seung-Woo Kim , Robert Foss , Frieder Schrempf , Andrzej Hajda , Kyungmin Park , Laurent Pinchart , Daniel Vetter , linux-arm-kernel , NXP Linux Team X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211209_084026_307895_DC442227 X-CRM114-Status: GOOD ( 44.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Dec 9, 2021 at 12:36 AM Michael Nazzareno Trimarchi wrote: > > Hi Tim > > On Tue, Oct 5, 2021 at 11:43 PM Tim Harvey wrote: > > > > On Sun, Jul 25, 2021 at 10:14 AM Jagan Teki wrote: > > > > > > Hi Sam, > > > > > > On Sun, Jul 25, 2021 at 10:35 PM Sam Ravnborg wrote: > > > > > > > > Hi Jagan, > > > > > > > > On Sun, Jul 04, 2021 at 02:32:13PM +0530, Jagan Teki wrote: > > > > > This series supports common bridge support for Samsung MIPI DSIM > > > > > which is used in Exynos and i.MX8MM SoC's. > > > > > > > > > > The final bridge supports both the Exynos and i.MX8MM DSI devices. > > > > > > > > > > Right now bridge offers two sets of implementations. > > > > > > > > > > A. With component_ops and exynos specific code exclusively for > > > > > exynos dsi drivers and it's legacy bindings. > > > > > > > > > > B. Without componenet_ops for newly implemented bridges and its > > > > > users like i.MX8MM. > > > > > > > > > > The future plan is to fix the implementation A) by dropping > > > > > component_ops and fixing exynos specific code in order to make > > > > > the bridge more mature to use and the same is mentioned in > > > > > drivers TODO. > > > > > > > > > > Patch 0001 - 0006: Bridge conversion > > > > > Patch 0007 - 0017: Samsung MIPI DSIM bridge fixes, additions > > > > > > > > > > Tested in Engicam i.Core MX8M Mini SoM. > > > > > > > > > > Anyone interest, please have a look on this repo > > > > > https://github.com/openedev/linux/tree/070421-imx8mm-dsim > > > > > > > > > > Would appreciate anyone from the exynos team to test it on > > > > > the exynos platform? > > > > > > > > > > Any inputs? > > > > > > > > I really like where you are headign with this! > > > > No testing - sorry. But I will try to provide a bit of feedback on the > > > > individual patches. > > > > > > > > I hope you find a way to move forward with this. > > > > > > Thanks for the response. > > > > > > We have found some issues with Bridge conversion on existing exynos > > > drivers. The component based DSI drivers(like exynos) are difficult to > > > attach if it involves kms hotplug. kms hotplug would require drm > > > pointer and that pointer would only available after the bind call > > > finishes. But the bridge attach in bind call will defer till it find > > > the attached bridge. > > > > > > Right now I'm trying to find the proper way to attach the bridges for > > > component based DSI drivers which involves kms hot-plug. > > > > > > If you have any ideas on this, please let me know. > > > > > > > Jagan, > > > > How is your progress on this series? Looking at your repo it looks > > like you've rebased on top of 5.13-rc3 in your 070121-imx8mm-dsim > > branch but you've got a lot of things there that are likely not > > related to this series? > > I have a bit of work on those patches and tested on imx8mn. Basically: > > - add the dsi timing calculation > - change few difference with samsung bridge > - fix crashes of my dsi panels > - compare with NXP driver the final results > > I found that I have one problem that gives me some instability. In the > NXP original driver the panel needs to be > enabled in bridge_enable before out the standby. If I understand > correctly, our standby should be done after. > I would like to have some feedback and help and testing on other > boards/devices and some suggestions on how to handle > some of the differences. Another big problem is etnavi that is not stable > Michael, Where can I find your patches? What do you mean by etnaviv not being stable? I did some limited testing with etnaviv on imx8mm with 5.15 + dsi patches on an Ubuntu focal root filesystem by: apt update apt install gnome-session gnome-terminal ^^^ 2D hardware acceleration appears to be working (dragging opaque windows around) apt install mesa-utils glmark2 glxgears ^^^ ~160fps on IMX8MM glmark2 ^^^ score of 39 on IMX8MM I haven't seen any updates from Jagan since Nov 24 (https://www.spinics.net/lists/dri-devel/msg324059.html) and am not sure if he's been able to work through drm/exynos issues that have been blocking his progress. Best regards, Tim _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 400F4C433FE for ; Thu, 9 Dec 2021 17:03:42 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C82C610F955; Thu, 9 Dec 2021 16:55:49 +0000 (UTC) Received: from mail-pl1-x62f.google.com (mail-pl1-x62f.google.com [IPv6:2607:f8b0:4864:20::62f]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7FC3810E116 for ; Thu, 9 Dec 2021 16:40:24 +0000 (UTC) Received: by mail-pl1-x62f.google.com with SMTP id m24so4282904pls.10 for ; Thu, 09 Dec 2021 08:40:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gateworks-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=XjBC6XUZJtPnhjTwfnkF808Zuq6NSOID5LVmEgkaOSQ=; b=w7Km7X5aTXVv4afJepuvvxUzlxaeKJkB6sKRFHDAPKphveY5UYuehMBl5Zgkz0c48s YW0+gmxf9V2Rn4oBHSkEY+MkK/J2o8HT5yUcBuotgbi/x1Odki/kiCJhSyeB7riY6+MD cBfNgfvIHQD33UUdIa9M2zULndAZv97MPUEOdlV7TLd1uqfCgKd8ipQkXx91qxCkq2xg 17Q20lXqHkjWN3telzgJhms20L7mwI+EZUmNZXX39+EIZPqVOcZ6WeWf+nI+oApi6cvV jcnrdiMnASvfcpGnePC4rZ3bsOYr82BR5kCL7XWML42AipHPxITYKGmEekVIaU2dYZBx 9byQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XjBC6XUZJtPnhjTwfnkF808Zuq6NSOID5LVmEgkaOSQ=; b=fX6HKE3n4nqX3SITcytljbw5oQ8ljYAtqBoZy54HF7ykuVwIfX5LjsSq+XQCKDkzM9 t46Zo3nUjoJ2TCfx4GYRMKSFK+DOMOE9aMno6pJruVNZSJqOcwP2vZfeSAU3GPOZAf78 8WgmozkOqeXHbaB52j26Ci/dF7+0pc5TKbqidGuxeZiN2u5suzbqcaaqZT5ZiUIMpa3e ItfCSRcsHvHGntyKMYyYNnk65TThFLwdlOG3dirnTPQbwaXr1J7X6S95uxdCZVWJieox gE4v4eyKQP4AO84kruzPLH3zYcy4EMKL25oDics61Xfka82eGSOL+Z8dfhR5sOKb99G2 7ENQ== X-Gm-Message-State: AOAM5338E+8T8R5BhyRnU/Zzz4fZF/VmMklO364Sdc6xAFdfxZyDHi+B Noqq9TuPygj6yHq3tdmPC1jSvR33dKsNyvEtp6lUHg== X-Google-Smtp-Source: ABdhPJzx3c4r0U+1q6LMafUGVo/WqdHyJSDJX1lRvhv0uEvpW1qCUNrk01ja1Jr5pkapoYydNfefkbMsZ9ornAF1028= X-Received: by 2002:a17:90b:4b4c:: with SMTP id mi12mr16962368pjb.66.1639068023870; Thu, 09 Dec 2021 08:40:23 -0800 (PST) MIME-Version: 1.0 References: <20210704090230.26489-1-jagan@amarulasolutions.com> In-Reply-To: From: Tim Harvey Date: Thu, 9 Dec 2021 08:40:12 -0800 Message-ID: Subject: Re: [RFC PATCH 00/17] drm: bridge: Samsung MIPI DSIM bridge To: Michael Nazzareno Trimarchi Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marek Vasut , devicetree , linux-samsung-soc , Joonyoung Shim , linux-arm-kernel , Neil Armstrong , linux-amarula , Krzysztof Kozlowski , Seung-Woo Kim , NXP Linux Team , dri-devel , Frieder Schrempf , Andrzej Hajda , Kyungmin Park , Jagan Teki , Daniel Vetter , Sam Ravnborg , Robert Foss , Laurent Pinchart Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, Dec 9, 2021 at 12:36 AM Michael Nazzareno Trimarchi wrote: > > Hi Tim > > On Tue, Oct 5, 2021 at 11:43 PM Tim Harvey wrote: > > > > On Sun, Jul 25, 2021 at 10:14 AM Jagan Teki wrote: > > > > > > Hi Sam, > > > > > > On Sun, Jul 25, 2021 at 10:35 PM Sam Ravnborg wrote: > > > > > > > > Hi Jagan, > > > > > > > > On Sun, Jul 04, 2021 at 02:32:13PM +0530, Jagan Teki wrote: > > > > > This series supports common bridge support for Samsung MIPI DSIM > > > > > which is used in Exynos and i.MX8MM SoC's. > > > > > > > > > > The final bridge supports both the Exynos and i.MX8MM DSI devices. > > > > > > > > > > Right now bridge offers two sets of implementations. > > > > > > > > > > A. With component_ops and exynos specific code exclusively for > > > > > exynos dsi drivers and it's legacy bindings. > > > > > > > > > > B. Without componenet_ops for newly implemented bridges and its > > > > > users like i.MX8MM. > > > > > > > > > > The future plan is to fix the implementation A) by dropping > > > > > component_ops and fixing exynos specific code in order to make > > > > > the bridge more mature to use and the same is mentioned in > > > > > drivers TODO. > > > > > > > > > > Patch 0001 - 0006: Bridge conversion > > > > > Patch 0007 - 0017: Samsung MIPI DSIM bridge fixes, additions > > > > > > > > > > Tested in Engicam i.Core MX8M Mini SoM. > > > > > > > > > > Anyone interest, please have a look on this repo > > > > > https://github.com/openedev/linux/tree/070421-imx8mm-dsim > > > > > > > > > > Would appreciate anyone from the exynos team to test it on > > > > > the exynos platform? > > > > > > > > > > Any inputs? > > > > > > > > I really like where you are headign with this! > > > > No testing - sorry. But I will try to provide a bit of feedback on the > > > > individual patches. > > > > > > > > I hope you find a way to move forward with this. > > > > > > Thanks for the response. > > > > > > We have found some issues with Bridge conversion on existing exynos > > > drivers. The component based DSI drivers(like exynos) are difficult to > > > attach if it involves kms hotplug. kms hotplug would require drm > > > pointer and that pointer would only available after the bind call > > > finishes. But the bridge attach in bind call will defer till it find > > > the attached bridge. > > > > > > Right now I'm trying to find the proper way to attach the bridges for > > > component based DSI drivers which involves kms hot-plug. > > > > > > If you have any ideas on this, please let me know. > > > > > > > Jagan, > > > > How is your progress on this series? Looking at your repo it looks > > like you've rebased on top of 5.13-rc3 in your 070121-imx8mm-dsim > > branch but you've got a lot of things there that are likely not > > related to this series? > > I have a bit of work on those patches and tested on imx8mn. Basically: > > - add the dsi timing calculation > - change few difference with samsung bridge > - fix crashes of my dsi panels > - compare with NXP driver the final results > > I found that I have one problem that gives me some instability. In the > NXP original driver the panel needs to be > enabled in bridge_enable before out the standby. If I understand > correctly, our standby should be done after. > I would like to have some feedback and help and testing on other > boards/devices and some suggestions on how to handle > some of the differences. Another big problem is etnavi that is not stable > Michael, Where can I find your patches? What do you mean by etnaviv not being stable? I did some limited testing with etnaviv on imx8mm with 5.15 + dsi patches on an Ubuntu focal root filesystem by: apt update apt install gnome-session gnome-terminal ^^^ 2D hardware acceleration appears to be working (dragging opaque windows around) apt install mesa-utils glmark2 glxgears ^^^ ~160fps on IMX8MM glmark2 ^^^ score of 39 on IMX8MM I haven't seen any updates from Jagan since Nov 24 (https://www.spinics.net/lists/dri-devel/msg324059.html) and am not sure if he's been able to work through drm/exynos issues that have been blocking his progress. Best regards, Tim