From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A08C8C4332F for ; Thu, 14 Apr 2022 17:42:31 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 7D5FF83E63; Thu, 14 Apr 2022 19:42:29 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=gateworks.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gateworks-com.20210112.gappssmtp.com header.i=@gateworks-com.20210112.gappssmtp.com header.b="Yh6m9r+W"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 83B9983AD0; Thu, 14 Apr 2022 19:42:27 +0200 (CEST) Received: from mail-pg1-x530.google.com (mail-pg1-x530.google.com [IPv6:2607:f8b0:4864:20::530]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 8929E83EB7 for ; Thu, 14 Apr 2022 19:42:20 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=gateworks.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=tharvey@gateworks.com Received: by mail-pg1-x530.google.com with SMTP id 125so5351650pgc.11 for ; Thu, 14 Apr 2022 10:42:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gateworks-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=T7fWhbjEcTmVWWi4SvEjLHMYv0CyK6f7rY3GzTo90eU=; b=Yh6m9r+WQc77BKalsYv/khgV6RgXGRIhws5ZdzCc1m7veJ7ATgiaADwUyl+INRw/vr HZMTqbZJUQEpslZB0rS46rFHBR9BRsn4iHddMX72RxUH0B5JEn2eAgVQIOyfy9ORhQz2 Zk+KMdzgPiYuJ8WwHHASs4TEm0DTsEvmC6A1j2xo9fJoVmaLU6qMeaBXYao3dRj3Tu6A RWV3F2MfhuFKxybLkjT3jKLCPDhuhLV491iax6mpzLMo3o5P6xFZ/ovqVL0wILqeOaa+ JDDZKyN+aygqkNWrOig5jsM8u3FZYmxUWQRdb4Rzz1xPubl6C/wZMNk9AB9PP0o2xZgY 46lQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=T7fWhbjEcTmVWWi4SvEjLHMYv0CyK6f7rY3GzTo90eU=; b=55XgqYhhmIoHlCaEE6wme1+SvQGojdYN4vfK1XJwec28OzGZSju52VfunujdMBj9HU /Vz+0p38J2udgHmd7DZxNyFBtf/ji/s93z/8GULU2fGuEdLZdxwG6up+/QPsuLr98FlK 6cBtkjCCJltoAR5IssTIn2U0jCmQo0RRQGgaRmV4Uss5bQKixYqiEgwhSk8qp8M5QxKl lsPyxAbjNaYQ/pTu5yE5djST0rH5FRMzh+ZP5snRn+dAKYOpTkOMVramyvh2XggFpxb2 W0pQIJdRP3SPVSdFZlqAG0rkHfxS7/gQH7qQ0M9E+lWlpV9iyXR8i6TYjDkdGT4TOvh4 yYEg== X-Gm-Message-State: AOAM530CcM1HOsYfdB7yZaajJUgNywhpRyf9Kor7f9NJ0g5s7/PLaTI3 NlKWhIkJdjOONKJXNoJ61dLTxSkgjiM/i0KenVe18Q== X-Google-Smtp-Source: ABdhPJzM5YTPRM/LnP0o/um3Sz5Gz0/jPGXMNkMyYQvf50iz9dP0t7kB7b3TG+AioWEiynWF28pLmDcFVGI00C/Qee0= X-Received: by 2002:a05:6a00:14ca:b0:4fb:5d3e:5f77 with SMTP id w10-20020a056a0014ca00b004fb5d3e5f77mr5014559pfu.34.1649958138972; Thu, 14 Apr 2022 10:42:18 -0700 (PDT) MIME-Version: 1.0 References: <20220413154719.20433-1-tharvey@gateworks.com> In-Reply-To: From: Tim Harvey Date: Thu, 14 Apr 2022 10:42:07 -0700 Message-ID: Subject: Re: [PATCH v2] board: gateworks: venice: enable DM_SERIAL To: Michael Nazzareno Trimarchi Cc: Stefano Babic , Fabio Estevam , "NXP i . MX U-Boot Team" , u-boot Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On Thu, Apr 14, 2022 at 9:10 AM Tim Harvey wrote: > > On Wed, Apr 13, 2022 at 10:21 AM Michael Nazzareno Trimarchi > wrote: > > > > Hi > > > > On Wed, Apr 13, 2022 at 6:09 PM Tim Harvey wrote: > > > > > > On Wed, Apr 13, 2022 at 8:56 AM Michael Nazzareno Trimarchi > > > wrote: > > > > > > > > Hi Tim > > > > > > > > On Wed, Apr 13, 2022 at 5:47 PM Tim Harvey wrote: > > > > > > > > > > Enable DM_SERIAL. > > > > > > > > > > Signed-off-by: Tim Harvey > > > > > --- > > > > > v2: rebase on imx/master > > > > > --- > > > > > configs/imx8mm_venice_defconfig | 2 ++ > > > > > configs/imx8mn_venice_defconfig | 2 ++ > > > > > 2 files changed, 4 insertions(+) > > > > > > > > > > diff --git a/configs/imx8mm_venice_defconfig b/configs/imx8mm_venice_defconfig > > > > > index dd61ec9b70fb..09f7d8a58ca7 100644 > > > > > --- a/configs/imx8mm_venice_defconfig > > > > > +++ b/configs/imx8mm_venice_defconfig > > > > > @@ -110,6 +110,8 @@ CONFIG_SPL_DM_PMIC_MP5416=y > > > > > CONFIG_DM_REGULATOR=y > > > > > CONFIG_DM_REGULATOR_FIXED=y > > > > > CONFIG_DM_REGULATOR_GPIO=y > > > > > +CONFIG_DM_SERIAL=y > > > > > +# CONFIG_SPL_DM_SERIAL is not set > > > > > CONFIG_MXC_UART=y > > > > > CONFIG_SYSRESET=y > > > > > CONFIG_SPL_SYSRESET=y > > > > > diff --git a/configs/imx8mn_venice_defconfig b/configs/imx8mn_venice_defconfig > > > > > index c3a96a378553..41898da4aecf 100644 > > > > > --- a/configs/imx8mn_venice_defconfig > > > > > +++ b/configs/imx8mn_venice_defconfig > > > > > @@ -108,6 +108,8 @@ CONFIG_SPL_DM_PMIC_MP5416=y > > > > > CONFIG_DM_REGULATOR=y > > > > > CONFIG_DM_REGULATOR_FIXED=y > > > > > CONFIG_DM_REGULATOR_GPIO=y > > > > > +CONFIG_DM_SERIAL=y > > > > > +# CONFIG_SPL_DM_SERIAL is not set > > > > > CONFIG_MXC_UART=y > > > > > CONFIG_SYSRESET=y > > > > > CONFIG_SPL_SYSRESET=y > > > > > -- > > > > > 2.17.1 > > > > > > > > > > > > > Should not select in your board kconfig? > > > > > > > > > > Michael, > > > > > > I don't think it really matters. The other conversions to DM_SERIAL > > > are going in defconfigs as well. > > > > Do we know why without # CONFIG_SPL_DM_SERIAL is not set > > > > board hang? > > > > Michael, > > yes, if I also enable CONFIG_SPL_DM_SERIAL I get no serial output and > the board hangs even if I add 'u-boot,dm-pre-proper' to > uart2/pinctrl_uart2 nodes. I see that Peng has a series [1] that moves imx8mn_evk, imx8mm_evk, imx8mp_evk to DM_SERIAL and has figured out the hang. I will re-submit the patch also enabling DM_SERIAL for SPL. Best Regards, Tim [1] https://patchwork.ozlabs.org/project/uboot/list/?series=294869 > > The requirement is to use DM_SERIAL in U-Boot, not in the SPL. I'm > doing the same as was done for imx8mn-evk in ff1c7961d813 ("ARM: imx: > imx8mn-evk: enable DM_SERIAL"). > > Thus far, no ARCH_IMX8M boards have enabled CONFIG_SPL_DM_SERIAL so I > suppose others have run into this as well but again the requirement is > to enable CONFIG_DM_SERIAL not necessarily the SPL. > > Best Regards, > > Tim