From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757665AbcCaSCB (ORCPT ); Thu, 31 Mar 2016 14:02:01 -0400 Received: from mail-oi0-f50.google.com ([209.85.218.50]:35240 "EHLO mail-oi0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751703AbcCaSB7 (ORCPT ); Thu, 31 Mar 2016 14:01:59 -0400 MIME-Version: 1.0 In-Reply-To: <20160331015714.GM28207@tiger> References: <20151106220249.GA19791@roeck-us.net> <565F4244.7090502@timesys.com> <20151228162923.GA31680@spo001.leaseweb.nl> <56AA79DA.2010305@timesys.com> <56F991C3.8030201@timesys.com> <20160330012226.GD28207@tiger> <20160330210916.GB21993@roeck-us.net> <20160331015714.GM28207@tiger> Date: Thu, 31 Mar 2016 11:01:58 -0700 Message-ID: Subject: Re: [PATCH v4 1/2] watchdog: imx2_wdt: add external reset support via 'ext-reset-output' dt prop From: Tim Harvey To: Shawn Guo , Guenter Roeck Cc: Akshay Bhat , Fabio Estevam , Rob Herring , Wim Van Sebroeck , linux-watchdog@vger.kernel.org, Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Sascha Hauer , Russell King - ARM Linux , "linux-arm-kernel@lists.infradead.org" , Justin Waters , Lucas Stach , Stefan Roese Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 30, 2016 at 6:57 PM, Shawn Guo wrote: > On Wed, Mar 30, 2016 at 02:09:16PM -0700, Guenter Roeck wrote: >> The question was if the property name should be ext-reset-output or >> fsl,ext-reset-output. In my opinion, it should be fsl,ext-reset-output >> because it is not a generic property. Tim disagrees. >> Guenter, My issue regarding the vendor prefix was not a hard dissagreement but was more about me understanding the rational behind using vendor prefixes. In this case the imx2_wdt driver 'is' a vendor specific driver as its compatible strings are prefixed with 'fsl,' so isn't 'any' property added to devicetree/bindings/watchdog/fsl-imx-wdt.txt inherently a vendor specific properly already? I assume that is why the 'big-endian' property isn't 'fsl,big-endian'. Maybe it's more about if it 'is' marked as a vendor specific property its much easier to get approval and accepted by a vendor-specific maintainer? >> So we have two options: Change the property name to fsl,ext-reset-output, >> which I would accept, or wait for a devicetree maintainer to make a decision. > > Guenter, > > I agree with you on this point. Before everyone agrees that this is a > generic binding, we should have vendor prefix for the property. > > Tim, > > This is a small change which, IMO, shouldn't hold an useful patch from being > merged. Care to resend with the suggested change? > > Shawn Shawn, Sure - I'll rebase and re-submit. Tim From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tim Harvey Subject: Re: [PATCH v4 1/2] watchdog: imx2_wdt: add external reset support via 'ext-reset-output' dt prop Date: Thu, 31 Mar 2016 11:01:58 -0700 Message-ID: References: <20151106220249.GA19791@roeck-us.net> <565F4244.7090502@timesys.com> <20151228162923.GA31680@spo001.leaseweb.nl> <56AA79DA.2010305@timesys.com> <56F991C3.8030201@timesys.com> <20160330012226.GD28207@tiger> <20160330210916.GB21993@roeck-us.net> <20160331015714.GM28207@tiger> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <20160331015714.GM28207@tiger> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Shawn Guo , Guenter Roeck Cc: Akshay Bhat , Fabio Estevam , Rob Herring , Wim Van Sebroeck , linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Sascha Hauer , Russell King - ARM Linux , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , Justin Waters , Lucas Stach , Stefan Roese List-Id: devicetree@vger.kernel.org On Wed, Mar 30, 2016 at 6:57 PM, Shawn Guo wrote: > On Wed, Mar 30, 2016 at 02:09:16PM -0700, Guenter Roeck wrote: >> The question was if the property name should be ext-reset-output or >> fsl,ext-reset-output. In my opinion, it should be fsl,ext-reset-output >> because it is not a generic property. Tim disagrees. >> Guenter, My issue regarding the vendor prefix was not a hard dissagreement but was more about me understanding the rational behind using vendor prefixes. In this case the imx2_wdt driver 'is' a vendor specific driver as its compatible strings are prefixed with 'fsl,' so isn't 'any' property added to devicetree/bindings/watchdog/fsl-imx-wdt.txt inherently a vendor specific properly already? I assume that is why the 'big-endian' property isn't 'fsl,big-endian'. Maybe it's more about if it 'is' marked as a vendor specific property its much easier to get approval and accepted by a vendor-specific maintainer? >> So we have two options: Change the property name to fsl,ext-reset-output, >> which I would accept, or wait for a devicetree maintainer to make a decision. > > Guenter, > > I agree with you on this point. Before everyone agrees that this is a > generic binding, we should have vendor prefix for the property. > > Tim, > > This is a small change which, IMO, shouldn't hold an useful patch from being > merged. Care to resend with the suggested change? > > Shawn Shawn, Sure - I'll rebase and re-submit. Tim -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: MIME-Version: 1.0 In-Reply-To: <20160331015714.GM28207@tiger> References: <20151106220249.GA19791@roeck-us.net> <565F4244.7090502@timesys.com> <20151228162923.GA31680@spo001.leaseweb.nl> <56AA79DA.2010305@timesys.com> <56F991C3.8030201@timesys.com> <20160330012226.GD28207@tiger> <20160330210916.GB21993@roeck-us.net> <20160331015714.GM28207@tiger> Date: Thu, 31 Mar 2016 11:01:58 -0700 Message-ID: Subject: Re: [PATCH v4 1/2] watchdog: imx2_wdt: add external reset support via 'ext-reset-output' dt prop From: Tim Harvey To: Shawn Guo , Guenter Roeck Cc: Akshay Bhat , Fabio Estevam , Rob Herring , Wim Van Sebroeck , linux-watchdog@vger.kernel.org, Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Sascha Hauer , Russell King - ARM Linux , "linux-arm-kernel@lists.infradead.org" , Justin Waters , Lucas Stach , Stefan Roese Content-Type: text/plain; charset=UTF-8 List-ID: On Wed, Mar 30, 2016 at 6:57 PM, Shawn Guo wrote: > On Wed, Mar 30, 2016 at 02:09:16PM -0700, Guenter Roeck wrote: >> The question was if the property name should be ext-reset-output or >> fsl,ext-reset-output. In my opinion, it should be fsl,ext-reset-output >> because it is not a generic property. Tim disagrees. >> Guenter, My issue regarding the vendor prefix was not a hard dissagreement but was more about me understanding the rational behind using vendor prefixes. In this case the imx2_wdt driver 'is' a vendor specific driver as its compatible strings are prefixed with 'fsl,' so isn't 'any' property added to devicetree/bindings/watchdog/fsl-imx-wdt.txt inherently a vendor specific properly already? I assume that is why the 'big-endian' property isn't 'fsl,big-endian'. Maybe it's more about if it 'is' marked as a vendor specific property its much easier to get approval and accepted by a vendor-specific maintainer? >> So we have two options: Change the property name to fsl,ext-reset-output, >> which I would accept, or wait for a devicetree maintainer to make a decision. > > Guenter, > > I agree with you on this point. Before everyone agrees that this is a > generic binding, we should have vendor prefix for the property. > > Tim, > > This is a small change which, IMO, shouldn't hold an useful patch from being > merged. Care to resend with the suggested change? > > Shawn Shawn, Sure - I'll rebase and re-submit. Tim From mboxrd@z Thu Jan 1 00:00:00 1970 From: tharvey@gateworks.com (Tim Harvey) Date: Thu, 31 Mar 2016 11:01:58 -0700 Subject: [PATCH v4 1/2] watchdog: imx2_wdt: add external reset support via 'ext-reset-output' dt prop In-Reply-To: <20160331015714.GM28207@tiger> References: <20151106220249.GA19791@roeck-us.net> <565F4244.7090502@timesys.com> <20151228162923.GA31680@spo001.leaseweb.nl> <56AA79DA.2010305@timesys.com> <56F991C3.8030201@timesys.com> <20160330012226.GD28207@tiger> <20160330210916.GB21993@roeck-us.net> <20160331015714.GM28207@tiger> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Mar 30, 2016 at 6:57 PM, Shawn Guo wrote: > On Wed, Mar 30, 2016 at 02:09:16PM -0700, Guenter Roeck wrote: >> The question was if the property name should be ext-reset-output or >> fsl,ext-reset-output. In my opinion, it should be fsl,ext-reset-output >> because it is not a generic property. Tim disagrees. >> Guenter, My issue regarding the vendor prefix was not a hard dissagreement but was more about me understanding the rational behind using vendor prefixes. In this case the imx2_wdt driver 'is' a vendor specific driver as its compatible strings are prefixed with 'fsl,' so isn't 'any' property added to devicetree/bindings/watchdog/fsl-imx-wdt.txt inherently a vendor specific properly already? I assume that is why the 'big-endian' property isn't 'fsl,big-endian'. Maybe it's more about if it 'is' marked as a vendor specific property its much easier to get approval and accepted by a vendor-specific maintainer? >> So we have two options: Change the property name to fsl,ext-reset-output, >> which I would accept, or wait for a devicetree maintainer to make a decision. > > Guenter, > > I agree with you on this point. Before everyone agrees that this is a > generic binding, we should have vendor prefix for the property. > > Tim, > > This is a small change which, IMO, shouldn't hold an useful patch from being > merged. Care to resend with the suggested change? > > Shawn Shawn, Sure - I'll rebase and re-submit. Tim