From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE48BC07E95 for ; Fri, 16 Jul 2021 14:54:14 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BF3A4600D3 for ; Fri, 16 Jul 2021 14:54:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BF3A4600D3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=gateworks.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jqrAhmIOgwNSGk6CQqxopc1xCVn0Ux8CQHc5+fOwjnw=; b=iOJneWR2Xp/y/D 1YvIbOATdelYd64oCJaZzvw5xv0hv7ygwCDXq7+Upqr4/svV0V3HbKB1PVBNQljMRY29hRWEv6gNZ QWOx1oyvGRJgMTzVYhgJHkwCDU6Yc1bfERmnf68QhBEzGggs/hHO5CE/YaLIgxWr1KELkN0oLIH8S 7j60mRy9ar1P+dRj1RLCeg8OGwqsIR3+8hg8ZJZSzhmUn8yxvnSU3y7yo4y9l+2v7sS/rpjbFMpIu SyhMONyusErjorV6CQAICyiekS+wWKKaUWyPdlfPEgJPBzbo46wiNCBy/jYfnOMQ09hfCt1WIFiti XYBw3h0w9oxvBj/Zeouw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m4PC7-004eEY-S3; Fri, 16 Jul 2021 14:52:04 +0000 Received: from mail-pl1-x630.google.com ([2607:f8b0:4864:20::630]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m4PC1-004eCM-HB for linux-arm-kernel@lists.infradead.org; Fri, 16 Jul 2021 14:52:00 +0000 Received: by mail-pl1-x630.google.com with SMTP id b2so866348plx.1 for ; Fri, 16 Jul 2021 07:51:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gateworks-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=K05SBxhdP0/yIejaUzEp/P8Y8ZgKzV8V2K5/ipY90Wc=; b=Vv/g5kj4uPmxHXB0P/xuFjLneM+37A5JxFEbmzX+srciU656/njs2QLJr6OG4JDY0U VBcmvleGgQoQ+nHpVKFF/03aFdmU3FOIbfZGl/V12zdGAvwUZjzzNMMYGJ/lI/8Z42eV 0s1G0X5C6RqQO1Ya9V45Y4YddOTXcD8i8dXIin6npqPL65EfSU84GigFso8D1C6L1jyB XpQvflSsLQSTj7tkHVERUCPv8wrThDp8Swu4a9crGwzhdAl8wW4OvvDHeEo2dp48IwHK mF0U+TIodbu6tjy9a+TzS5BkZr3QgXvvlkiyZOLPdDNN4CFz9V1JE12l2fBGuLAYbKrx kvjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=K05SBxhdP0/yIejaUzEp/P8Y8ZgKzV8V2K5/ipY90Wc=; b=CDIf2GWyNq/Pc0scEffIkfThKzNKBl+VZnkUfq7IyAksF/48YhESXA1bHKlKqkMkRk PvEB9xPeGLPxBL4l5gC13GdCJ21QOhbgcJbRo8pB+HqQA5hevTcbuudAxKJ5SApUyH9F +7IdzCznlznEkoMdSe1Fi5owKetiLSdudFTheV6oGJHvRRelxAQkKMlwEICMg21x2HZ0 p6daxC8lHAKWj2SE2swvg2pgGvhG/CU8ujcLpKT3mIJ7nt4t98KVgL9Z3TddSoJNa+vd zaQGQaPYEHBaE7sWPi75UK5btg6VnOJbwl+WEjhCqn/1xK/c6Z435ftI/4sRgJt2gpUk TYUQ== X-Gm-Message-State: AOAM531OAaTk7XyPNcDZP+1s8i95xqjbpIIZxexpEQ9CML7tVqeCUDP5 SSwe4xIjM3xnQ8uvOOmPhfirsyBwd/GtCvJyfBiDjQ== X-Google-Smtp-Source: ABdhPJzHQAW9fAjQj4IM7s4PM387hwzw2vfiCs2OFexLzn+ob31oB1w22iGdyR/Vg2+EueEL1L57YGc50Gm1zbdYhtQ= X-Received: by 2002:a17:90b:14a:: with SMTP id em10mr10292786pjb.125.1626447115871; Fri, 16 Jul 2021 07:51:55 -0700 (PDT) MIME-Version: 1.0 References: <20210716132845.3371666-1-festevam@gmail.com> <20210716132845.3371666-2-festevam@gmail.com> In-Reply-To: <20210716132845.3371666-2-festevam@gmail.com> From: Tim Harvey Date: Fri, 16 Jul 2021 07:51:44 -0700 Message-ID: Subject: Re: [PATCH 2/2] arm64: dts: imx8mm-venice: Fix the SPI chipselect polarity To: Fabio Estevam Cc: Shawn Guo , Linux ARM Mailing List , Schrempf Frieder X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210716_075157_701840_7FBE2097 X-CRM114-Status: GOOD ( 23.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jul 16, 2021 at 6:29 AM Fabio Estevam wrote: > > The conversion of the spi-imx driver to use GPIO descriptors > in commit 8cdcd8aeee28 ("spi: imx/fsl-lpspi: Convert to GPIO descriptors") > helped to detect the following SPI chipselect polarity mismatch on an > imx6q-sabresd for example: > > [ 4.854337] m25p80@0 enforce active low on chipselect handle > > Prior to the above commit, the chipselect polarity passed via cs-gpios > property was ignored and considered active-low. > > The reason for such mismatch is clearly explained in the comments inside > drivers/gpio/gpiolib-of.c: > > * SPI children have active low chip selects > * by default. This can be specified negatively > * by just omitting "spi-cs-high" in the > * device node, or actively by tagging on > * GPIO_ACTIVE_LOW as flag in the device > * tree. If the line is simultaneously > * tagged as active low in the device tree > * and has the "spi-cs-high" set, we get a > * conflict and the "spi-cs-high" flag will > * take precedence. > > To properly represent the SPI chipselect polarity, change it to active-low > when the "spi-cs-high" property is absent. > > Signed-off-by: Fabio Estevam > --- > arch/arm64/boot/dts/freescale/imx8mm-venice-gw71xx.dtsi | 2 +- > arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx.dtsi | 2 +- > arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx.dtsi | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw71xx.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw71xx.dtsi > index 905b68a3daa5..138bb8c9bf56 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw71xx.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw71xx.dtsi > @@ -57,7 +57,7 @@ reg_usb_otg1_vbus: regulator-usb-otg1 { > &ecspi2 { > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_spi2>; > - cs-gpios = <&gpio5 13 GPIO_ACTIVE_HIGH>; > + cs-gpios = <&gpio5 13 GPIO_ACTIVE_LOW>; > status = "okay"; > }; > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx.dtsi > index b7c91bdc21dd..27afa46a253a 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx.dtsi > @@ -76,7 +76,7 @@ reg_usb_otg2_vbus: regulator-usb-otg2 { > &ecspi2 { > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_spi2>; > - cs-gpios = <&gpio5 13 GPIO_ACTIVE_HIGH>; > + cs-gpios = <&gpio5 13 GPIO_ACTIVE_LOW>; > status = "okay"; > }; > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx.dtsi > index d2ffd62a3bd4..a59e849c7be2 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx.dtsi > @@ -96,7 +96,7 @@ reg_wifi_en: regulator-wifi-en { > &ecspi2 { > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_spi2>; > - cs-gpios = <&gpio5 13 GPIO_ACTIVE_HIGH>; > + cs-gpios = <&gpio5 13 GPIO_ACTIVE_LOW>; > status = "okay"; > }; > > -- > 2.25.1 > Fabio, Thanks for finding this and submitting the patch! Reviewed-By: Tim Harvey _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel