From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F21BC4338F for ; Mon, 26 Jul 2021 18:20:50 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ADF7C60F37 for ; Mon, 26 Jul 2021 18:20:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org ADF7C60F37 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=gateworks.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id D71ED833BA; Mon, 26 Jul 2021 20:20:47 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=gateworks.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gateworks-com.20150623.gappssmtp.com header.i=@gateworks-com.20150623.gappssmtp.com header.b="v1abd4bE"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 38BD9833BA; Mon, 26 Jul 2021 20:20:46 +0200 (CEST) Received: from mail-pl1-x633.google.com (mail-pl1-x633.google.com [IPv6:2607:f8b0:4864:20::633]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 59314833A8 for ; Mon, 26 Jul 2021 20:20:38 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=gateworks.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=tharvey@gateworks.com Received: by mail-pl1-x633.google.com with SMTP id d1so5418243pll.1 for ; Mon, 26 Jul 2021 11:20:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gateworks-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=tUBiEfo6uZA3hHVaUR5suL/NJJRI70C/hHDhebeAYww=; b=v1abd4bELmmXHeX0VWJMIHgbzsehr77rPbtmLqqaVEFEcSgHvgCs69tj20Wxl6CkMq EHzBBQTMHdzGarKlfCorACjUt0b8uFtQxyGbdp/tZgF77HS+ZFhuaI9uNSv4Ae2I//09 FjC0VC1Fu3gXYTackPVQNwobEi8lCpl4q+c66/lOM4zST6uZ0MXv87VevbwPKPnJ+SnJ 1/F5dyEp0jmeMWI/B2hGct62xotHAQH5t/ZAUj5CnsSbbVAxSCAmGxRJDbMwTsmPVzQc 4b8LL9m5aXC+y0nRh+VF0rSrio9V4BkFU406IfzyT0Qs+m9KBMGqWg8aqNUGaIPmrIgy ENRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tUBiEfo6uZA3hHVaUR5suL/NJJRI70C/hHDhebeAYww=; b=QO9Ti2Xpk8ZnW2iSimkgZxNXYI4gGH91FwnCu0Bb4YI8DZnf59SaRuSUqfzY83HZCh w4kU5FVPEe6aEFKKBbX7yFiTx8eRt0rEBUMI6eYk6bcqnFuf4hP3sapxRC7gDqDKjBO9 PlE1vSKbrk71shq6TO/TycAm9r3WgSbDXIfINn5kCtcDzRSSifpxLttJOpe/ngX5hLka YsxYPWcwFHWI/YS7ZyWTYrG/4G6wCvLdIoKPu2NWjTkSiOyqwwH2LWiwcEvHtAXNkpRj wsLkxlWDdKakwrLd4XSMjf0FUJT4Y3KP9lCzFvO8nUtPbw8raE47mglw4XYLxZmYWDx6 ivmg== X-Gm-Message-State: AOAM532tbb83gs5DfJCdu1bhuvTRNvEJ1kOk48OQSh/AZ6EgRfRHQgKz TI3Wp0FxjvnYvrc4K/dupCKiOG32ivFqeAoxTS1fsQ== X-Google-Smtp-Source: ABdhPJxBxwzZuiTihFD+5VpHHgJFWllrvRPvHavmZPoqgqJ+U4XpGgDkPAhZoawhe0a04sIGDKP7n3vTmziUgO9UgsU= X-Received: by 2002:a63:4e51:: with SMTP id o17mr19754330pgl.126.1627323636607; Mon, 26 Jul 2021 11:20:36 -0700 (PDT) MIME-Version: 1.0 References: <20210725165416.470735-1-sjg@chromium.org> <20210725165416.470735-2-sjg@chromium.org> In-Reply-To: <20210725165416.470735-2-sjg@chromium.org> From: Tim Harvey Date: Mon, 26 Jul 2021 11:20:25 -0700 Message-ID: Subject: Re: [PATCH v2 2/3] arm: Add an __image_copy_start symbol for ARMv8 To: Simon Glass Cc: U-Boot Mailing List , Albert Aribaud , =?UTF-8?B?TWFyZWsgQmVow7pu?= , Tom Rini Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Sun, Jul 25, 2021 at 9:54 AM Simon Glass wrote: > > This symbol is needed for binman to locate the start of the image. Add it. > > Note: the existing line to bring in the .__image_copy_start symbol does > not appear to do anything. > > Signed-off-by: Simon Glass > --- > > Changes in v2: > - Add new patch to add an __image_copy_start symbol for ARMv8 > > arch/arm/cpu/armv8/u-boot-spl.lds | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/cpu/armv8/u-boot-spl.lds b/arch/arm/cpu/armv8/u-boot-spl.lds > index 9edb662b094..2827a07590d 100644 > --- a/arch/arm/cpu/armv8/u-boot-spl.lds > +++ b/arch/arm/cpu/armv8/u-boot-spl.lds > @@ -22,6 +22,7 @@ ENTRY(_start) > SECTIONS > { > .text : { > + __image_copy_start = .; > . = ALIGN(8); > *(.__image_copy_start) > CPUDIR/start.o (.text*) > -- > 2.32.0.432.gabb21c7263-goog > Sould the '*(.__image_copy_start)' be removed? I'll admit that I'm not very knowledgable when it comes to linker files. I did verify removing it boots fine. Tim