From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7C704C77B60 for ; Fri, 28 Apr 2023 15:48:57 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 5F700860AB; Fri, 28 Apr 2023 17:48:55 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=gateworks.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gateworks-com.20221208.gappssmtp.com header.i=@gateworks-com.20221208.gappssmtp.com header.b="mJYG4wXm"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id B852086068; Fri, 28 Apr 2023 17:48:53 +0200 (CEST) Received: from mail-yb1-xb2a.google.com (mail-yb1-xb2a.google.com [IPv6:2607:f8b0:4864:20::b2a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D628E860AB for ; Fri, 28 Apr 2023 17:48:49 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=gateworks.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=tharvey@gateworks.com Received: by mail-yb1-xb2a.google.com with SMTP id 3f1490d57ef6-b980e16b27bso8336731276.2 for ; Fri, 28 Apr 2023 08:48:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gateworks-com.20221208.gappssmtp.com; s=20221208; t=1682696928; x=1685288928; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=XE9Ghv9c47YGW7mvi8gVAQcZLTb3XYLmAD7jus0kEnQ=; b=mJYG4wXm1ZBRM7Ns0mAjZW4xVeiCjIHPaykKzhqqDpcSDePgswIxpVHjWAINNwOZAw u5ryiMrZZ80P5TFa/AjMxPogqPoWaaXEMHKA5NstZkemPyrtRK31jbzRPBuklOFXxXA6 +cl0uaR+3tYijCSKE2PEcGhox4Y7OI03w02l+hMnGVu9A/w4q+DldUiIXZaY/9BgU59X cGpJEZZKGOggboKgL1HiY0mDHGzOAkgEVAMPxc45puvvRnxtMZzqtSSdfuWgT5ynf2jA t1Zs+GEKt/IAcBSAivqHLoWXvHMg2UU1DJT03u6JG/lcKUPLBorgsnEP7TijoHpRXLqg z0+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682696928; x=1685288928; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XE9Ghv9c47YGW7mvi8gVAQcZLTb3XYLmAD7jus0kEnQ=; b=OZFPQAd8Gp43k1YdmCIXjgvvlUy49DTnGwXl8yM3fm5HGt0Qaa9xYGW9qmNi9nRzqM mDqQRd3pDWCYpNPgmjlmQ3m3bb0xwHW0LK378HFWRdPo395tqKrulUVJOaOHYTOxUo6q qorbtVThNWAii6JEv+PoWFBI8nTw99BDcp//S5rEuM8LcL0kzCGcAD+WvDyWTjZaK2bh q1BAN8iaoWqNDNer//92+BYXCLcb49+2FGjPlHe9y3Vb16ZxtjdNZaSX206d6kxjK8IV 9HnQcmeyPSwETk/lwcaxVEUp6lWMUDM/V1wagcTZGQoiVbUOwVdlnu75TTAD45+he8GQ K84g== X-Gm-Message-State: AC+VfDzIWrUL1rW6ZVQKcXKRIr/Ej7YifK7z28LE3yik0sf6bYXTkfsc pM1Xls7cVoSJVwAAEKpnVpthzh3Z4VKG5GAHeqrLVyRSEThMEq496nI= X-Google-Smtp-Source: ACHHUZ5O58lAACtxRKOqoumajSrT0SWmmewtSfnDo+7KBD1+MEnr2aOc/iMM+/Nr5GfQyxh6dp2YT/pgYyu0ZkU1ICs= X-Received: by 2002:a25:b318:0:b0:b8f:1841:8084 with SMTP id l24-20020a25b318000000b00b8f18418084mr4699374ybj.11.1682696928608; Fri, 28 Apr 2023 08:48:48 -0700 (PDT) MIME-Version: 1.0 References: <20230427180845.127439-1-festevam@gmail.com> In-Reply-To: From: Tim Harvey Date: Fri, 28 Apr 2023 08:48:37 -0700 Message-ID: Subject: Re: [PATCH 1/3] arm: dts: imx8mm: Sync with Linux 6.3 To: Adam Ford Cc: Fabio Estevam , sbabic@denx.de, u-boot@lists.denx.de, Fabio Estevam Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On Fri, Apr 28, 2023 at 8:32=E2=80=AFAM Adam Ford wrot= e: > > On Fri, Apr 28, 2023 at 10:27=E2=80=AFAM Tim Harvey wrote: > > > > On Fri, Apr 28, 2023 at 4:57=E2=80=AFAM Adam Ford = wrote: > > > > > > On Thu, Apr 27, 2023 at 5:25=E2=80=AFPM Tim Harvey wrote: > > > > > > > > On Thu, Apr 27, 2023 at 12:49=E2=80=AFPM Fabio Estevam wrote: > > > > > > > > > > On Thu, Apr 27, 2023 at 4:44=E2=80=AFPM Tim Harvey wrote: > > > > > > > > > > > Fabio, > > > > > > > > > > > > Sorry for the confusion. > > > > > > > > > > > > This imx8mm dt sync patch will hang on imx8mm boards that use '= both' > > > > > > usbotg1 and usbotg2. You can reproduce this hang on your imx8mm= -evk by > > > > > > enabling usbotg2 in the dt (the board has it but it is not enab= led due > > > > > > to the gpio based usb 3.0 mux not being sorted out yet): > > > > > > +&usbotg2 { > > > > > > + dr_mode =3D "otg"; > > > > > > + status =3D "okay"; > > > > > > +}; > > > > > > + > > > > > > > > > > > > u-boot=3D> usb start && usb tree > > > > > > starting USB... > > > > > > Bus usb@32e40000: Bus usb@32e50000: > > > > > > ^^^ imx8mm-evk hangs > > > > > > > > > > Yes, I can reproduce the hang, but it happens with or without the > > > > > imx8mm dt sync. > > > > > > > > > > > > > Fabio, > > > > > > > > I do 'not' see a hang on imx8mm-evk on 'usb start && usb tree' on > > > > master (my other issue was on a 'usb stop' but only with usb > > > > controllers in host mode). > > > > > > > > > This hang is a separate issue, not dt related, as far as I unders= tand. > > > > > > > > > > The imx8mm dts sync does solve the issue of running 'ums' after C= TRL+C. > > > > > > > > I don't agree. The hang 'is' related because all my imx8mm-venice-* > > > > boards which use 'both' USB controllers hang with this patch on a '= usb > > > > start' and don't hang without it. While a basic 'review' of the pat= ch > > > > looks good but actual product testing shows issues. As a maintainer > > > > for ARM FREESCALE IMX you must have another imx8mm board which uses > > > > both usbotg devices to test against and verify you see what I see? > > > > > > > > Until we know what other fix is needed to go along with this: > > > > Nacked-by: Tim Harvey > > > > > > What is the harm is sync'ing the device tree with the kernel? I seeme= d > > > like you found a solution with the regulator patch. Did I > > > misunderstand that? > > > > > > adam > > > > Adam, > > > > No, the regulator patch did 'not' resolve the issue created by syncing > > the imx8mm dt (I caused confusion by responding to the wrong thread - > > the regulator patch resolved a different issue). > > Ok. > > > > Could you please verify my results on a board that uses both usbotg1 > > and usbotg2? What I see is on master + this imx8mm dt sync > > (specifically the changes from Linux commit 4585c79ff477f ("arm64: > > dts: imx8mm: correct usb power domains")) the board hangs on usb start > > when bringing up usbotg2. Adam, Sorry to hear that :( > > I can, but I am about to board a plane to go visit some sick family, > but I'll try to do it early next week. > I have a board with both USB controllers enabled. My OTG2 is > host-only, so I think it's similar to your setup. Yes I think that is similar enough to test. In my experience simply enabling otg2 via dt on imx8mm-evk shows the issue I see here but Fabio says he sees a hang on 'usb start' even before this dt sync and I don't know why my results on an imx8mm-evk differ. > > Should I apply the regulator patch when I test? No, don't apply that as this exposes another issue: Error enabling VBUS supply (ret=3D-114) I'm still looking into that. I'm assuming when the regulaor refcnt support gets merged it may expose a lot of issues from unbalanced regulator enable/disable calls. The regulator refcnt series resolved the hang I see on 'usb stop' for boards where otg2 is in host mode (internal usb_hub device powers down the power domain before ehci_shutdown tries to access the registers to disable the ports). Tim