From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7CDEC43217 for ; Fri, 18 Nov 2022 00:54:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240756AbiKRAyZ (ORCPT ); Thu, 17 Nov 2022 19:54:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53212 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234053AbiKRAyX (ORCPT ); Thu, 17 Nov 2022 19:54:23 -0500 Received: from mail-pf1-x42c.google.com (mail-pf1-x42c.google.com [IPv6:2607:f8b0:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1B36F7EBED for ; Thu, 17 Nov 2022 16:54:23 -0800 (PST) Received: by mail-pf1-x42c.google.com with SMTP id 140so3426017pfz.6 for ; Thu, 17 Nov 2022 16:54:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gateworks-com.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=eRHZ8HxlKkpc/rQw9TF/Vjc6A04s7AH3fGHGNV8IcdM=; b=EMdaRR5ywe+TV/FYyD9a2i+UB/WspihcuIixd5Dr21nxmE+kcbN8TtOmL46bnAWEJZ kOMiPHdykN4qZbMIGafcSieL2JCDwRT1Gn5eDVMjpDrz6ejrGhrSbXWcjDVzKmH4t0kI elpclmBAb7rzG6BXcOB8kac8xK+aTsSO/BR5vCsDUvAsEuE/cvxFv1w+4ff1loBLW96l 0yyqyGGuegV0UUvNRmtSwuv2elmshJ+Uldj5RrMlnESTdSN+SpgwZSPmNoQlgf2HfRo7 1pcksb6gWej+VA9v9FvtxqoTUtsJVb/9HwmI9H6HwxDLzZlotYwNIr+cOvTN/Ul7FA4r e5cA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=eRHZ8HxlKkpc/rQw9TF/Vjc6A04s7AH3fGHGNV8IcdM=; b=hmXxwMJE/sia2ep6r6/APRAk1EqcHh3edXkmwNoTvBENYSwLQBhoJubJHjR3/HsfMw zM4C8jFXgkAvAwqZVeJgb+1BeURenD1u73da4ZzJFm01LWeqXV6ATSz31x5Zau72Dgga YTCRT12eDHGV2r2Fkxu+ZmAlMiaLvBS6QNHqf467SQnyHG/ekLNwe6IWbGcNvG/Kcy/N tJwiSdQZUZ1/gyZRpPV5woED4XL2Ve4Tk4dvUznsgfIdGljA0FSbsDHqYIq8/JfmaaWx rdJjDyYyz4RhZQ8AYAUlxIWT1vKQHvAFD533S+qahvw417GGCs8s3Hn22owMyODd5nmQ /RMQ== X-Gm-Message-State: ANoB5pljxpEfOPJQitMp0mxDAmuIhyMvLBg3si8FI6rTr+tHSiH4mIql Kcmhmdwx8g9jPHYO+ZOolojPVYuPNO/5uE+yU1S4gQ== X-Google-Smtp-Source: AA0mqf577aAwYGvH4qpaYZECY2LNNaZytgtXT9uUrDcNBCNowZCpDJhrRK4S5gagrFXZqiA33J0kBMych14iLw5Etbc= X-Received: by 2002:a05:6a00:4009:b0:563:2ada:30a3 with SMTP id by9-20020a056a00400900b005632ada30a3mr5481609pfb.27.1668732862572; Thu, 17 Nov 2022 16:54:22 -0800 (PST) MIME-Version: 1.0 References: <20221118001548.635752-1-tharvey@gateworks.com> In-Reply-To: From: Tim Harvey Date: Thu, 17 Nov 2022 16:54:11 -0800 Message-ID: Subject: Re: [PATCH 0/3] add dt configuration for dp83867 led modes To: Andrew Lunn Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, netdev@vger.kernel.org, Heiner Kallweit , Russell King , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Rob Herring , Krzysztof Kozlowski Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 17, 2022 at 4:27 PM Andrew Lunn wrote: > > On Thu, Nov 17, 2022 at 04:15:45PM -0800, Tim Harvey wrote: > > This series adds a dt-prop ti,led-modes to configure dp83867 PHY led > > modes, adds the code to implement it, and updates some board dt files > > to use the new property. > > Sorry, but NACK. > > We need PHY leds to be controlled via /sys/class/leds. Everybody keeps > trying to add there own way to configure these things, rather than > have just one uniform way which all PHYs share. > > Andrew Andrew, I completely agree with you but I haven't seen how that can be done yet. What support exists for a PHY driver to expose their LED configuration to be used that way? Can you point me to an example? Best Regards, Tim From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ACA39C4332F for ; Fri, 18 Nov 2022 00:55:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zLFc/DVRDPOU2WPB0rh1f6vmPgfPkdaiBveivfzsIro=; b=sHIcfI+JCcgRx8 PnGuchAhodAn/aqOzAup8K4i3w2pWA7CB+fSwS+UUM0PdIhbTdg2lpQtkUczTg2pFHer/9gtf9USG eu44ZRS9QwijD4S/KJ2tixbhPz1HxinHpywfQjNG6AXGJW6QfZq5Hwdx71f4Tg9rH7DOGNTdXAk1h kOt2mOObb0GB4mDs0oK50VDjgkF+l+LBcKBlT2INSc6Oi9cSV3P5xgmD5uWuokrpO/6IYki1KNARp I7Ve4YhAz+aVnTba1kQZ+WqxCOOtV0mKPpxb/U5ClDhuxYqdvTqg+V6x5zYAak7rXqL1gDX5yFOeG F/43r4evvAgghjyvREcw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ovpeF-0015yI-Qh; Fri, 18 Nov 2022 00:54:27 +0000 Received: from mail-pf1-x42a.google.com ([2607:f8b0:4864:20::42a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ovpeB-0015xE-Sd for linux-arm-kernel@lists.infradead.org; Fri, 18 Nov 2022 00:54:25 +0000 Received: by mail-pf1-x42a.google.com with SMTP id z26so3445603pff.1 for ; Thu, 17 Nov 2022 16:54:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gateworks-com.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=eRHZ8HxlKkpc/rQw9TF/Vjc6A04s7AH3fGHGNV8IcdM=; b=EMdaRR5ywe+TV/FYyD9a2i+UB/WspihcuIixd5Dr21nxmE+kcbN8TtOmL46bnAWEJZ kOMiPHdykN4qZbMIGafcSieL2JCDwRT1Gn5eDVMjpDrz6ejrGhrSbXWcjDVzKmH4t0kI elpclmBAb7rzG6BXcOB8kac8xK+aTsSO/BR5vCsDUvAsEuE/cvxFv1w+4ff1loBLW96l 0yyqyGGuegV0UUvNRmtSwuv2elmshJ+Uldj5RrMlnESTdSN+SpgwZSPmNoQlgf2HfRo7 1pcksb6gWej+VA9v9FvtxqoTUtsJVb/9HwmI9H6HwxDLzZlotYwNIr+cOvTN/Ul7FA4r e5cA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=eRHZ8HxlKkpc/rQw9TF/Vjc6A04s7AH3fGHGNV8IcdM=; b=yk/CWW8f+Jr4YoeyiWwG808x68mrvqb02qfwt8A6xVyZNyM9SdZo4BK187fhVCqXgr JGKyRi5G7dA6KncEHBs9FV0SW3NX/xVtLDhpZQA1QUhrsfG+9KKn9dIwMU+xVYwNxHf+ T0d+FViux3IGQwpnIQS3s3d9Dm45es0NGKOpsYsOnUczS3lqVK03yIFrxADNdaN+PPIs NR4Url017W5rmUo4XhTV0oIfHKHysNE7kuYhuTMs2uI0yE5thN48PLJma5Ywj/Zx9NSa pVHN3ZU0SGcf6JrLVnvGQ5/70q4V+h5gpBTw8t75cya9X4nS2HSyOvWealgmxpsAgthi 4rag== X-Gm-Message-State: ANoB5pnO0wdGH8FgS9s16G+Jvp50YGITsnnVtEVYBXGtdS2Ow1XkUTHt OmGXVWMjfYTtKwae8q6WYAN+Ud9lr6xPnW2nILRjXSiyhls= X-Google-Smtp-Source: AA0mqf577aAwYGvH4qpaYZECY2LNNaZytgtXT9uUrDcNBCNowZCpDJhrRK4S5gagrFXZqiA33J0kBMych14iLw5Etbc= X-Received: by 2002:a05:6a00:4009:b0:563:2ada:30a3 with SMTP id by9-20020a056a00400900b005632ada30a3mr5481609pfb.27.1668732862572; Thu, 17 Nov 2022 16:54:22 -0800 (PST) MIME-Version: 1.0 References: <20221118001548.635752-1-tharvey@gateworks.com> In-Reply-To: From: Tim Harvey Date: Thu, 17 Nov 2022 16:54:11 -0800 Message-ID: Subject: Re: [PATCH 0/3] add dt configuration for dp83867 led modes To: Andrew Lunn Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, netdev@vger.kernel.org, Heiner Kallweit , Russell King , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Rob Herring , Krzysztof Kozlowski X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221117_165424_156878_81B6479C X-CRM114-Status: GOOD ( 15.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Nov 17, 2022 at 4:27 PM Andrew Lunn wrote: > > On Thu, Nov 17, 2022 at 04:15:45PM -0800, Tim Harvey wrote: > > This series adds a dt-prop ti,led-modes to configure dp83867 PHY led > > modes, adds the code to implement it, and updates some board dt files > > to use the new property. > > Sorry, but NACK. > > We need PHY leds to be controlled via /sys/class/leds. Everybody keeps > trying to add there own way to configure these things, rather than > have just one uniform way which all PHYs share. > > Andrew Andrew, I completely agree with you but I haven't seen how that can be done yet. What support exists for a PHY driver to expose their LED configuration to be used that way? Can you point me to an example? Best Regards, Tim _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel