All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tim Harvey <tharvey@gateworks.com>
To: Marcel Ziswiler <marcel@ziswiler.com>
Cc: Simon Glass <sjg@chromium.org>, u-boot <u-boot@lists.denx.de>
Subject: Re: [PATCH v2] imx8mm_venice: switch to use binman to pack images
Date: Thu, 7 Oct 2021 10:26:52 -0700	[thread overview]
Message-ID: <CAJ+vNU3Vjw_k+WZgy1BHwwFu_FhX4TCGU1rv77_OUOg+9SsN-Q@mail.gmail.com> (raw)
In-Reply-To: <426797a830231136b527bda16ea490d65a3383dc.camel@ziswiler.com>

On Thu, Oct 7, 2021 at 10:12 AM Marcel Ziswiler <marcel@ziswiler.com> wrote:
>
> Hi Tim
>
> On Thu, 2021-10-07 at 08:52 -0700, Tim Harvey wrote:
> > )On Wed, Oct 6, 2021 at 2:44 PM Marcel Ziswiler <marcel@ziswiler.com> wrote:
> > >
> > > On Wed, 2021-10-06 at 13:17 -0700, Tim Harvey wrote:
> > > > Use binman to pack images.
> > > >
> > > > Note that imx8mm_venice supports several boards via multiple DTB's thus
> > > > in the fit node we must use:
> > > > - fit,fdt-list = "of-list"
> > > > - fdt-SEQ
> > > > - config-SEQ
> > > >
> > > > Signed-off-by: Tim Harvey <tharvey@gateworks.com>
> > >
> > > Reviewed-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> > >
> > > > ---
> > > > v2:
> > > >  - rebase on origin/mater
> > >
> > > You probably meant master (;-p).
> > >
> > > Rest look legit.
> >
> > Marcel,
> >
> > Thanks for the review. I will submit a v3 as I forgot to include a few
> > other patches required for this that I had in v1 (using a common
> > u-boot.dtsi file)
> >
> > I am seeing 'WARNING 'u-boot-spl-ddr.bin' not found, resulting binary
> > is not-functional' until I do a 'make' a second time so there is some
> > sort of race condition with the binman blobs.
>
> Yes, remember, this still needs Peng's Makefile fix [1] as otherwise, it may not quite generate all binman
> artefacts in the right order as discussed here [2].
>
> [1] https://marc.info/?l=u-boot&m=162908373904742
> [2] https://marc.info/?l=u-boot&m=162945614207220
>
> Cheers
>
> Marcel

Marvell,

Indeed that patch resolves the issue - thanks for reminding me that
hasn't made it in yet!

Best regards,

Tim

  reply	other threads:[~2021-10-07 17:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-06 20:17 [PATCH v2] imx8mm_venice: switch to use binman to pack images Tim Harvey
2021-10-06 21:44 ` Marcel Ziswiler
2021-10-07 15:52   ` Tim Harvey
2021-10-07 17:12     ` Marcel Ziswiler
2021-10-07 17:26       ` Tim Harvey [this message]
2021-10-07 17:30         ` Marcel Ziswiler
2021-10-07 18:08           ` Tim Harvey
2021-10-07 18:37             ` Stefano Babic
2021-10-07 18:48               ` Tim Harvey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJ+vNU3Vjw_k+WZgy1BHwwFu_FhX4TCGU1rv77_OUOg+9SsN-Q@mail.gmail.com \
    --to=tharvey@gateworks.com \
    --cc=marcel@ziswiler.com \
    --cc=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.