From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14077C282C8 for ; Mon, 28 Jan 2019 20:19:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D00282171F for ; Mon, 28 Jan 2019 20:19:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="FZA07DX4" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726862AbfA1UTq (ORCPT ); Mon, 28 Jan 2019 15:19:46 -0500 Received: from mail-yw1-f67.google.com ([209.85.161.67]:38563 "EHLO mail-yw1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726792AbfA1UTq (ORCPT ); Mon, 28 Jan 2019 15:19:46 -0500 Received: by mail-yw1-f67.google.com with SMTP id d190so7277628ywb.5 for ; Mon, 28 Jan 2019 12:19:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=g0RoEbehmxQIYiHZUqjNeZ5YNr/WroLHwd8LB4/ek44=; b=FZA07DX4SqqxUIae6bgIQarCb0gfcmtcNDY0PLzc3b6Q89o+vBGxnOasQyH5M/5Pbq UKkkuQ9i9wounpWf1oIXx6HZDY60gYKw+MyvGzDk1LKFIWFQ0nYfcXxc64XesCqNFunA 4W5AUfWCI0ghw0RsvdXQAO/5o4Gt2xezk38vw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=g0RoEbehmxQIYiHZUqjNeZ5YNr/WroLHwd8LB4/ek44=; b=APX3KaLKdY3vgyvLKmxSG0zMMCVBrN/kbmV9W7v3wNBzGpT0TZlWhZD411LgQLsrrQ bRjAGYmCyqglW4vsVJY1EBYUNZwTgX6FTrSudcKbEGdyBnz0eCBrd+GLABKVTG1N9bHY QMCX6K4xjM+S76qlzxGEEsfa57ioUgXMVBzi12ynVWp/nRjV1xp2VA77TasUWT4WlRbn SuOMdpdvgroDDGgnKoPjjnTJfT7x5x7vrOQzqpM2X3EaBQLfi5m9sXreeVtAq3sGe+cY Q2jLkI5HowVLpZXRk6vsuWGMoqR9mu4x9KEo22V/9Ya3aTA2UukzWYkYWNjVTaQ7m9pU ITfQ== X-Gm-Message-State: AJcUukceiwDOV5+FotDV4r/8t/y98HkIe7f8v8j+7TVydKnUf8dZLgcS 4kXciX7TJmHg+vafFlPKyMY8tV7DJX6jOY8j+mgxMQ== X-Google-Smtp-Source: ALg8bN4dUdJJPH57ZeONz/ZmBxJ7idsWGDwiUr9ImRJZxaqofs8H3QImVh4dawd8mbxw3sl6+WFRcOJmEpxort9I90o= X-Received: by 2002:a81:b61a:: with SMTP id u26mr21867488ywh.428.1548706785501; Mon, 28 Jan 2019 12:19:45 -0800 (PST) MIME-Version: 1.0 References: <20190116154606.92331-1-mortonm@chromium.org> In-Reply-To: From: Micah Morton Date: Mon, 28 Jan 2019 12:19:34 -0800 Message-ID: Subject: Re: [PATCH v5 2/2] LSM: add SafeSetID module that gates setid calls To: Kees Cook Cc: James Morris , "Serge E. Hallyn" , Casey Schaufler , Stephen Smalley , linux-security-module Content-Type: text/plain; charset="UTF-8" Sender: owner-linux-security-module@vger.kernel.org Precedence: bulk List-ID: On Mon, Jan 28, 2019 at 11:56 AM Kees Cook wrote: > > On Tue, Jan 29, 2019 at 8:47 AM Micah Morton wrote: > > > > I'm getting the following crash when booting after compiling a kernel > > with this LSM enabled, so I'll have to figure out what is going on. > > All the "core" functionality of this LSM has been tested thoroughly > > (we're already using this LSM on ChromeOS), but looks like there's > > some debugging of the initialization that still needs to be done. > > > +DEFINE_LSM(safesetid_security_init) = { > + .init = safesetid_security_init, > +}; > > I think this is from not having: > > .name = "safesetid", That fixed it for me! Thanks > > I missed that in the review, sorry! > > -- > Kees Cook