All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adrian Chadd <adrian@freebsd.org>
To: Robert Shade <robert.shade@gmail.com>
Cc: Ben Greear <greearb@candelatech.com>,
	Christian Lamparter <chunkeey@googlemail.com>,
	ath9k-devel@venema.h4ckr.net, linux-wireless@vger.kernel.org,
	Marco Fonseca <marco@tampabay.rr.com>
Subject: Re: [ath9k-devel] Auth Packet TX Delay
Date: Wed, 27 Mar 2013 09:33:38 -0700	[thread overview]
Message-ID: <CAJ-Vmomp2gS34jwWuh7046Y+6mBGCpirG6nk-E37enE3mSh5GA@mail.gmail.com> (raw)
In-Reply-To: <CAMgrJ3bENvfezMSge9_oOJiSsoMpMVFGk+QaSgsHSDASczgn0A@mail.gmail.com>

Good catch! Can you add that to the bugzilla bug please?



Adrian


On 26 March 2013 20:11, Robert Shade <robert.shade@gmail.com> wrote:
> Think I found it:  In ath_reset_internal, before we reset, we call
> ath_prepare_reset, which calls ath9k_hw_disable_interrupts.  If the
> channel change fails, we never call ath_complete_reset, which calls
> ath9k_hw_enable_interrupts.
>
> ath9k_hw_{enable|disable}_interrupts calls definitely needs to be
> balanced.  Looking at an old log, IER never gets re-enabled after the
> channel set failure.
>
> Any suggestions on the proper cleanup?  Could we just call
> ath_complete_reset anyway?  Some sort of special handling?
>
> On Tue, Mar 26, 2013 at 8:55 PM, Robert Shade <robert.shade@gmail.com> wrote:
>> On Tue, Mar 26, 2013 at 1:13 PM, Ben Greear <greearb@candelatech.com> wrote:
>>> Can you cat out the /debug/ieee80211/wiphy0/ath9k/xmit
>>> file when it gets in this hung state?  I saw issues where
>>> the xmit queues got hung in our AR9380 NIC systems and
>>> ended up adding an ugly bit of cleanup/reset logic to
>>> get them working again...
>>
>> Dumps are attached on to the bug.  I remember being hopeful when
>> reading your thread that we stumbled on the same issue, but the
>> symptoms don't look the same to me because pending-frames goes back to
>> 0 in my case.

WARNING: multiple messages have this Message-ID (diff)
From: Adrian Chadd <adrian@freebsd.org>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] Auth Packet TX Delay
Date: Wed, 27 Mar 2013 09:33:38 -0700	[thread overview]
Message-ID: <CAJ-Vmomp2gS34jwWuh7046Y+6mBGCpirG6nk-E37enE3mSh5GA@mail.gmail.com> (raw)
In-Reply-To: <CAMgrJ3bENvfezMSge9_oOJiSsoMpMVFGk+QaSgsHSDASczgn0A@mail.gmail.com>

Good catch! Can you add that to the bugzilla bug please?



Adrian


On 26 March 2013 20:11, Robert Shade <robert.shade@gmail.com> wrote:
> Think I found it:  In ath_reset_internal, before we reset, we call
> ath_prepare_reset, which calls ath9k_hw_disable_interrupts.  If the
> channel change fails, we never call ath_complete_reset, which calls
> ath9k_hw_enable_interrupts.
>
> ath9k_hw_{enable|disable}_interrupts calls definitely needs to be
> balanced.  Looking at an old log, IER never gets re-enabled after the
> channel set failure.
>
> Any suggestions on the proper cleanup?  Could we just call
> ath_complete_reset anyway?  Some sort of special handling?
>
> On Tue, Mar 26, 2013 at 8:55 PM, Robert Shade <robert.shade@gmail.com> wrote:
>> On Tue, Mar 26, 2013 at 1:13 PM, Ben Greear <greearb@candelatech.com> wrote:
>>> Can you cat out the /debug/ieee80211/wiphy0/ath9k/xmit
>>> file when it gets in this hung state?  I saw issues where
>>> the xmit queues got hung in our AR9380 NIC systems and
>>> ended up adding an ugly bit of cleanup/reset logic to
>>> get them working again...
>>
>> Dumps are attached on to the bug.  I remember being hopeful when
>> reading your thread that we stumbled on the same issue, but the
>> symptoms don't look the same to me because pending-frames goes back to
>> 0 in my case.

  reply	other threads:[~2013-03-27 16:33 UTC|newest]

Thread overview: 74+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-20 18:45 [ath9k-devel] Auth Packet TX Delay Robert Shade
2013-01-15 22:06 ` Robert Shade
2013-01-15 22:06   ` [ath9k-devel] " Robert Shade
2013-01-16 23:09   ` Adrian Chadd
2013-01-16 23:09     ` [ath9k-devel] " Adrian Chadd
2013-01-17  1:00     ` Robert Shade
2013-01-17  1:00       ` [ath9k-devel] " Robert Shade
2013-01-17  3:12       ` Adrian Chadd
2013-01-17  3:12         ` [ath9k-devel] " Adrian Chadd
2013-02-06  2:51         ` Robert Shade
2013-02-06  2:51           ` [ath9k-devel] " Robert Shade
2013-02-06  3:08           ` Adrian Chadd
2013-02-06  3:08             ` [ath9k-devel] " Adrian Chadd
2013-02-06 12:53             ` Robert Shade
2013-02-06 12:53               ` [ath9k-devel] " Robert Shade
2013-02-06 22:58               ` Robert Shade
2013-02-06 22:58                 ` [ath9k-devel] " Robert Shade
2013-02-07  5:06                 ` Adrian Chadd
2013-02-07  5:06                   ` [ath9k-devel] " Adrian Chadd
2013-02-07 16:25                   ` David Littell
2013-02-07 16:25                     ` David Littell
2013-02-07 19:43                   ` Robert Shade
2013-02-07 19:43                     ` [ath9k-devel] " Robert Shade
2013-02-07 21:40                     ` Adrian Chadd
2013-02-07 21:40                       ` [ath9k-devel] " Adrian Chadd
2013-02-08 18:48                       ` Robert Shade
2013-02-08 18:48                         ` [ath9k-devel] " Robert Shade
2013-02-09  7:39                         ` Adrian Chadd
2013-02-09  7:39                           ` [ath9k-devel] " Adrian Chadd
2013-03-24 18:55                           ` Robert Shade
2013-03-24 18:55                             ` [ath9k-devel] " Robert Shade
2013-03-24 21:52                             ` Adrian Chadd
2013-03-24 21:52                               ` [ath9k-devel] " Adrian Chadd
2013-03-24 22:40                               ` Robert Shade
2013-03-24 22:40                                 ` [ath9k-devel] " Robert Shade
2013-03-24 22:58                                 ` Christian Lamparter
2013-03-24 22:58                                   ` [ath9k-devel] " Christian Lamparter
2013-03-25  0:03                                   ` Adrian Chadd
2013-03-25  0:03                                     ` [ath9k-devel] " Adrian Chadd
2013-03-25  2:23                                     ` Adrian Chadd
2013-03-25  2:23                                       ` [ath9k-devel] " Adrian Chadd
2013-03-25 16:12                                       ` Christian Lamparter
2013-03-25 16:12                                         ` [ath9k-devel] " Christian Lamparter
2013-03-25 16:45                                         ` Adrian Chadd
2013-03-25 16:45                                           ` [ath9k-devel] " Adrian Chadd
2013-03-26 12:21                                           ` Robert Shade
2013-03-26 12:21                                             ` [ath9k-devel] " Robert Shade
2013-03-26 13:23                                             ` Robert Shade
2013-03-26 13:23                                               ` [ath9k-devel] " Robert Shade
2013-03-26 16:28                                             ` Adrian Chadd
2013-03-26 16:28                                               ` [ath9k-devel] " Adrian Chadd
2013-03-26 16:29                                               ` Robert Shade
2013-03-26 16:29                                                 ` [ath9k-devel] " Robert Shade
2013-03-26 17:13                                                 ` Ben Greear
2013-03-26 17:13                                                   ` Ben Greear
2013-03-26 17:16                                                   ` Adrian Chadd
2013-03-26 17:16                                                     ` Adrian Chadd
2013-03-26 17:27                                                     ` Ben Greear
2013-03-26 17:27                                                       ` Ben Greear
2013-03-26 17:33                                                       ` Adrian Chadd
2013-03-26 17:33                                                         ` Adrian Chadd
2013-03-26 17:45                                                         ` Ben Greear
2013-03-26 17:45                                                           ` Ben Greear
2013-03-27  0:55                                                   ` Robert Shade
2013-03-27  0:55                                                     ` Robert Shade
2013-03-27  3:11                                                     ` Robert Shade
2013-03-27  3:11                                                       ` Robert Shade
2013-03-27 16:33                                                       ` Adrian Chadd [this message]
2013-03-27 16:33                                                         ` Adrian Chadd
2013-03-26 17:14                                                 ` Adrian Chadd
2013-03-26 17:14                                                   ` [ath9k-devel] " Adrian Chadd
2013-03-26 14:13                                           ` Marco Fonseca
2013-03-26 14:13                                             ` [ath9k-devel] " Marco Fonseca
2013-01-17 18:48 David Littell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJ-Vmomp2gS34jwWuh7046Y+6mBGCpirG6nk-E37enE3mSh5GA@mail.gmail.com \
    --to=adrian@freebsd.org \
    --cc=ath9k-devel@venema.h4ckr.net \
    --cc=chunkeey@googlemail.com \
    --cc=greearb@candelatech.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=marco@tampabay.rr.com \
    --cc=robert.shade@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.